Re: [FFmpeg-devel] [Getting Started]

2020-02-12 Thread Andreas Rheinhardt 
On Thu, Feb 13, 2020 at 6:23 AM Goutham Kancherla <
kancherlagout...@gmail.com> wrote:

> Greetings
> There are 3 binaries at the end
> ffmpeg , play ,probe
> where is the main for each one
> Just Getting Started , pardon the naive question
> Cheers


The binaries are in the fftools/ folder and the main function of these are
in ffmpeg.c, ffprobe.c and ffplay.c respectively.

- Andreas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [Getting Started]

2020-02-12 Thread Goutham Kancherla 
Greetings
There are 3 binaries at the end
ffmpeg , play ,probe
where is the main for each one
Just Getting Started , pardon the naive question
Cheers
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] compat/os2threads:define INCL_DOSERRORS

2020-02-12 Thread Dave Yeo 


From 6182a7f6b83905fb2315b416ae714a329ec2d0df Mon Sep 17 00:00:00 2001
From: Dave Yeo 
Date: Wed, 12 Feb 2020 20:13:00 -0800
Subject: [PATCH] compat/os2threads:define INCL_DOSERRORS

This is needed to pull in the define for ERROR_TIMEOUT

Signed-off-by: Dave Yeo 
---
 compat/os2threads.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/compat/os2threads.h b/compat/os2threads.h
index eec6f40ae7..a061eaa63d 100644
--- a/compat/os2threads.h
+++ b/compat/os2threads.h
@@ -27,6 +27,7 @@
 #define COMPAT_OS2THREADS_H
 
 #define INCL_DOS
+#define INCL_DOSERRORS
 #include 
 
 #undef __STRICT_ANSI__  /* for _beginthread() */
-- 
2.11.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] Getting Started :: Need for render API

2020-02-12 Thread Goutham Kancherla 
Greetings!
I have been going through the repos and find that there are dependencies on
VULAKN
and other render API's ,
my question is what is the need?
isnt ffmpeg a command line tool?
Pardon me for asking such a naive question
cheers
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avcodec/cbs_av1: add missing value constrains to point_y_value, point_cb_value and point_cr_value

2020-02-12 Thread James Almer 
If i is greater than 0, it is a requirement of bitstream conformance that 
point_y_value[ i ] is greater than point_y_value[ i - 1 ].
If i is greater than 0, it is a requirement of bitstream conformance that 
point_cb_value[ i ] is greater than point_cb_value[ i - 1 ].
If i is greater than 0, it is a requirement of bitstream conformance that 
point_cr_value[ i ] is greater than point_cr_value[ i - 1 ].

Signed-off-by: James Almer 
---
 libavcodec/cbs_av1_syntax_template.c | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/libavcodec/cbs_av1_syntax_template.c 
b/libavcodec/cbs_av1_syntax_template.c
index b62e07fb11..614097bc7e 100644
--- a/libavcodec/cbs_av1_syntax_template.c
+++ b/libavcodec/cbs_av1_syntax_template.c
@@ -1156,7 +1156,8 @@ static int FUNC(film_grain_params)(CodedBitstreamContext 
*ctx, RWContext *rw,
 
 fc(4, num_y_points, 0, 14);
 for (i = 0; i < current->num_y_points; i++) {
-fbs(8, point_y_value[i],   1, i);
+fcs(8, point_y_value[i],
+i ? current->point_y_value[i - 1] + 1 : 0, MAX_UINT_BITS(8), 1, i);
 fbs(8, point_y_scaling[i], 1, i);
 }
 
@@ -1175,12 +1176,14 @@ static int 
FUNC(film_grain_params)(CodedBitstreamContext *ctx, RWContext *rw,
 } else {
 fc(4, num_cb_points, 0, 10);
 for (i = 0; i < current->num_cb_points; i++) {
-fbs(8, point_cb_value[i],   1, i);
+fcs(8, point_cb_value[i],
+i ? current->point_cb_value[i - 1] + 1 : 0, MAX_UINT_BITS(8), 
1, i);
 fbs(8, point_cb_scaling[i], 1, i);
 }
 fc(4, num_cr_points, 0, 10);
 for (i = 0; i < current->num_cr_points; i++) {
-fbs(8, point_cr_value[i],   1, i);
+fcs(8, point_cr_value[i],
+i ? current->point_cr_value[i - 1] + 1 : 0, MAX_UINT_BITS(8), 
1, i);
 fbs(8, point_cr_scaling[i], 1, i);
 }
 }
-- 
2.25.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavformat/utils.c: Fixed URL parsing

2020-02-12 Thread Gautam Ramakrishnan 
On Thu, Feb 13, 2020 at 12:31 AM Marton Balint  wrote:
>
>
>
> On Wed, 12 Feb 2020, gautamr...@gmail.com wrote:
>
> > From: Gautam Ramakrishnan 
> >
> > This commit fixes bug #8466 wherein URLs with query string
> > not preceeded by the '/' symbol in a URL was failing to get
> > parsed. The av_url_split() function now checks if the path
> > starts with a '/' and prepends it if it does not.
> > ---
> > libavformat/utils.c | 7 +++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/libavformat/utils.c b/libavformat/utils.c
> > index 81ea239a66..a14d4ef90d 100644
> > --- a/libavformat/utils.c
> > +++ b/libavformat/utils.c
> > @@ -4819,6 +4819,13 @@ void av_url_split(char *proto, int proto_size,
> > av_strlcpy(path, ls, path_size);
> > else
> > ls = [strlen(p)];  // XXX
> > +/* if path does not start with a /, prepend a / */
> > +if (path[0] != '/') {
> > +char temp[1024];
> > +av_strlcpy(temp, path, path_size);
> > +path[0] = '/';
> > +av_strlcpy(path + 1, temp, path_size - 1);
> > +}
>
> I made a patch which fixes this in the HTTP protocol, as modifying the
> empty path to / is a HTTP requirement, other protocols might not need
> this.
>
Oh I just found this on patchwork. I think my patch becomes redundant
then. I guess the patch has not been merged yet?
> http://mplayerhq.hu/pipermail/ffmpeg-devel/2020-February/256902.html
>
> Regards,
> Marton



-- 
-
Gautam |
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264_ps: Return error if pps has FMO parameters

2020-02-12 Thread James Almer 
On 2/12/2020 8:36 PM, Andriy Gelman wrote:
> From: Andriy Gelman 
> 
> FMO is not supported and fields related to FMO are not parsed, meaning
> that any fields which follow will be corrupt.
> ---
>  libavcodec/h264_ps.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c
> index d36921e47bf..708594954cb 100644
> --- a/libavcodec/h264_ps.c
> +++ b/libavcodec/h264_ps.c
> @@ -794,7 +794,9 @@ int ff_h264_decode_picture_parameter_set(GetBitContext 
> *gb, AVCodecContext *avct
>  pps->slice_group_count = get_ue_golomb(gb) + 1;
>  if (pps->slice_group_count > 1) {
>  pps->mb_slice_group_map_type = get_ue_golomb(gb);
> -av_log(avctx, AV_LOG_ERROR, "FMO not supported\n");
> +avpriv_report_missing_feature(avctx, "FMO");
> +ret = AVERROR_PATCHWELCOME;
> +goto fail;
>  }
>  pps->ref_count[0] = get_ue_golomb(gb) + 1;
>  pps->ref_count[1] = get_ue_golomb(gb) + 1;

Applied, thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] MAINTAINERS: Add myself as libzmq maintainer

2020-02-12 Thread Andriy Gelman 
From: Andriy Gelman 

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5244d9237a9..55e2b385b5a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -507,6 +507,7 @@ Protocols:
   ftp.c Lukasz Marek
   http.cRonald S. Bultje
   libssh.c  Lukasz Marek
+  libzmq.c  Andriy Gelman
   mms*.cRonald S. Bultje
   udp.c Luca Abeni
   icecast.c Marvin Scholz
-- 
2.25.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 11/11] avcodec/avcodec: Nits

2020-02-12 Thread Michael Niedermayer 
On Tue, Dec 10, 2019 at 10:59:55PM +0100, Andreas Rheinhardt wrote:
> Signed-off-by: Andreas Rheinhardt 
> ---
>  libavcodec/avcodec.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

will apply

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg: Integrate two checks

2020-02-12 Thread Michael Niedermayer 
On Sat, Oct 12, 2019 at 05:18:39AM +0200, Andreas Rheinhardt wrote:
> For audio packets with dts != AV_NOPTS_VALUEs the dts was converted
> twice to the muxer's timebase during streamcopy, once as a normal
> packet and once specifically as an audio packet. This has been changed.
> 
> Signed-off-by: Andreas Rheinhardt 
> ---
>  fftools/ffmpeg.c | 20 ++--
>  1 file changed, 10 insertions(+), 10 deletions(-)

will apply

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Whats the most studid thing your enemy could do ? Blow himself up
Whats the most studid thing you could do ? Give up your rights and
freedom because your enemy blew himself up.



signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/h264_pc: Return error if pps has FMO parameters

2020-02-12 Thread Andriy Gelman 
On Sat, 08. Feb 21:30, James Almer wrote:
> On 2/8/2020 7:20 PM, Andriy Gelman wrote:
> > From: Andriy Gelman 
> > 
> > FMO is not supported and fields related to FMO are not parsed, meaning
> > that any fields which follow will be corrupt.
> > ---
> >  libavcodec/h264_ps.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c
> > index edbaa96b64e..80216854079 100644
> > --- a/libavcodec/h264_ps.c
> > +++ b/libavcodec/h264_ps.c
> > @@ -794,6 +794,8 @@ int ff_h264_decode_picture_parameter_set(GetBitContext 
> > *gb, AVCodecContext *avct
> >  if (pps->slice_group_count > 1) {
> >  pps->mb_slice_group_map_type = get_ue_golomb(gb);
> >  av_log(avctx, AV_LOG_ERROR, "FMO not supported\n");

> 
> Should probably be avpriv_report_missing_feature() instead. Look right
> above this chunk for an usage example of this function.
> 

Thanks, I've resent with this change.

-- 
Andriy
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/1] ffmpeg: gnutls: ignore TLS rehandshake requests

2020-02-12 Thread Tristan Matthews 
Log a warning instead of terminating.

TLS does not explicitly require that the client initiate the handshake when
requested by the server, it can be ignored (although the server is free to
break the connection if no handshake is forthcoming).

https://www.gnutls.org/manual/html_node/Core-TLS-API.html#gnutls_005frehandshake
---
 libavformat/tls_gnutls.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavformat/tls_gnutls.c b/libavformat/tls_gnutls.c
index f32bc2821b..db9d50b586 100644
--- a/libavformat/tls_gnutls.c
+++ b/libavformat/tls_gnutls.c
@@ -81,6 +81,9 @@ static int print_tls_error(URLContext *h, int ret)
 case GNUTLS_E_PREMATURE_TERMINATION:
 #endif
 break;
+case GNUTLS_E_REHANDSHAKE:
+av_log(h, AV_LOG_WARNING, "%s\n", gnutls_strerror(ret));
+return 0;
 case GNUTLS_E_WARNING_ALERT_RECEIVED:
 av_log(h, AV_LOG_WARNING, "%s\n", gnutls_strerror(ret));
 break;
-- 
2.20.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2] avcodec/h264_ps: Return error if pps has FMO parameters

2020-02-12 Thread Andriy Gelman 
From: Andriy Gelman 

FMO is not supported and fields related to FMO are not parsed, meaning
that any fields which follow will be corrupt.
---
 libavcodec/h264_ps.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c
index d36921e47bf..708594954cb 100644
--- a/libavcodec/h264_ps.c
+++ b/libavcodec/h264_ps.c
@@ -794,7 +794,9 @@ int ff_h264_decode_picture_parameter_set(GetBitContext *gb, 
AVCodecContext *avct
 pps->slice_group_count = get_ue_golomb(gb) + 1;
 if (pps->slice_group_count > 1) {
 pps->mb_slice_group_map_type = get_ue_golomb(gb);
-av_log(avctx, AV_LOG_ERROR, "FMO not supported\n");
+avpriv_report_missing_feature(avctx, "FMO");
+ret = AVERROR_PATCHWELCOME;
+goto fail;
 }
 pps->ref_count[0] = get_ue_golomb(gb) + 1;
 pps->ref_count[1] = get_ue_golomb(gb) + 1;
-- 
2.25.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/midivid: Check dimensions to be the multiple assumed by the implementation

2020-02-12 Thread Reino Wijnsma 
On 2020-02-12T23:17:09+0100, Paul B Mahol  wrote:
> This is incorrect.
>
> On 2/12/20, Michael Niedermayer  wrote:
>> Fixes: out of array access
>> Fixes:
>> 20626/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MVDV_fuzzer-6279905350516736
>>
>> Found-by: continuous fuzzing process
>> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
>> Signed-off-by: Michael Niedermayer 
>> [...]

Wow! What a wonderful nicely bottom-posted expressed opinion 
! That 
certainly must have been very helpful for Michael.

-- Reino
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/midivid: Check dimensions to be the multiple assumed by the implementation

2020-02-12 Thread Paul B Mahol 
This is incorrect.

On 2/12/20, Michael Niedermayer  wrote:
> Fixes: out of array access
> Fixes:
> 20626/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MVDV_fuzzer-6279905350516736
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer 
> ---
>  libavcodec/midivid.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/libavcodec/midivid.c b/libavcodec/midivid.c
> index 8d4c3b369e..a30cf25207 100644
> --- a/libavcodec/midivid.c
> +++ b/libavcodec/midivid.c
> @@ -236,6 +236,9 @@ static av_cold int decode_init(AVCodecContext *avctx)
>  MidiVidContext *s = avctx->priv_data;
>  int ret = av_image_check_size(avctx->width, avctx->height, 0, avctx);
>
> +if (avctx->width%32 || avctx->height%4)
> +ret = AVERROR_INVALIDDATA;
> +
>  if (ret < 0) {
>  av_log(avctx, AV_LOG_ERROR, "Invalid image size %dx%d.\n",
> avctx->width, avctx->height);
> --
> 2.17.1
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/2] avcodec/midivid: Check dimensions to be the multiple assumed by the implementation

2020-02-12 Thread Michael Niedermayer 
Fixes: out of array access
Fixes: 
20626/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MVDV_fuzzer-6279905350516736

Found-by: continuous fuzzing process 
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer 
---
 libavcodec/midivid.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavcodec/midivid.c b/libavcodec/midivid.c
index 8d4c3b369e..a30cf25207 100644
--- a/libavcodec/midivid.c
+++ b/libavcodec/midivid.c
@@ -236,6 +236,9 @@ static av_cold int decode_init(AVCodecContext *avctx)
 MidiVidContext *s = avctx->priv_data;
 int ret = av_image_check_size(avctx->width, avctx->height, 0, avctx);
 
+if (avctx->width%32 || avctx->height%4)
+ret = AVERROR_INVALIDDATA;
+
 if (ret < 0) {
 av_log(avctx, AV_LOG_ERROR, "Invalid image size %dx%d.\n",
avctx->width, avctx->height);
-- 
2.17.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/2] avcodec/adpcm: Fix integer overflow in ADPCM THP

2020-02-12 Thread Michael Niedermayer 
The reference (thp.txt) uses floats so wrap around would seem incorrect.

Fixes: signed integer overflow: 1073741824 + 1073741824 cannot be represented 
in type 'int'
Fixes: 
20658/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_THP_fuzzer-5646302555930624

Found-by: continuous fuzzing process 
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer 
---
 libavcodec/adpcm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c
index 0cd28431d7..3728279525 100644
--- a/libavcodec/adpcm.c
+++ b/libavcodec/adpcm.c
@@ -1698,8 +1698,8 @@ static int adpcm_decode_frame(AVCodecContext *avctx, void 
*data,
 int byte = bytestream2_get_byteu();
 int index = (byte >> 4) & 7;
 unsigned int exp = byte & 0x0F;
-int factor1 = table[ch][index * 2];
-int factor2 = table[ch][index * 2 + 1];
+int64_t factor1 = table[ch][index * 2];
+int64_t factor2 = table[ch][index * 2 + 1];
 
 /* Decode 14 samples.  */
 for (n = 0; n < 14 && (i * 14 + n < nb_samples); n++) {
-- 
2.17.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec: add cdtoons decoder

2020-02-12 Thread Carl Eugen Hoyos 
Am Mi., 12. Feb. 2020 um 20:50 Uhr schrieb Paul B Mahol :

> +c->pal[i] = (0xff << 24) | (r << 16) | (g << 8) | (b);

Should be "0xffu" iirc, and we usually have less parentheses.

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avcodec: add cdtoons decoder

2020-02-12 Thread Paul B Mahol 
From: Alyssa Milburn 

This adds a decoder for Broderbund's sprite-based QuickTime CDToons
codec, based on the decoder I wrote for ScummVM.

Signed-off-by: Alyssa Milburn 
Signed-off-by: Paul B Mahol 
---
 doc/general.texi|   2 +
 libavcodec/Makefile |   1 +
 libavcodec/allcodecs.c  |   1 +
 libavcodec/avcodec.h|   1 +
 libavcodec/cdtoons.c| 445 
 libavcodec/codec_desc.c |   7 +
 libavformat/isom.c  |   1 +
 7 files changed, 458 insertions(+)
 create mode 100644 libavcodec/cdtoons.c

diff --git a/doc/general.texi b/doc/general.texi
index 85db50462c..01d2748f28 100644
--- a/doc/general.texi
+++ b/doc/general.texi
@@ -846,6 +846,8 @@ following image formats are supported:
 @tab Codec used in Delphine Software International games.
 @item Discworld II BMV Video @tab @tab  X
 @item Canopus Lossless Codec @tab @tab  X
+@item CDToons@tab @tab  X
+@tab Codec used in various Broderbund games.
 @item Cinepak@tab @tab  X
 @item Cirrus Logic AccuPak   @tab  X  @tab  X
 @tab fourcc: CLJR
diff --git a/libavcodec/Makefile b/libavcodec/Makefile
index 7825f2741b..b49328aed7 100644
--- a/libavcodec/Makefile
+++ b/libavcodec/Makefile
@@ -244,6 +244,7 @@ OBJS-$(CONFIG_CAVS_DECODER)+= cavs.o cavsdec.o 
cavsdsp.o \
   cavsdata.o
 OBJS-$(CONFIG_CCAPTION_DECODER)+= ccaption_dec.o ass.o
 OBJS-$(CONFIG_CDGRAPHICS_DECODER)  += cdgraphics.o
+OBJS-$(CONFIG_CDTOONS_DECODER) += cdtoons.o
 OBJS-$(CONFIG_CDXL_DECODER)+= cdxl.o
 OBJS-$(CONFIG_CFHD_DECODER)+= cfhd.o cfhddata.o
 OBJS-$(CONFIG_CINEPAK_DECODER) += cinepak.o
diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
index 0ad3338f9a..aff0b88d2d 100644
--- a/libavcodec/allcodecs.c
+++ b/libavcodec/allcodecs.c
@@ -68,6 +68,7 @@ extern AVCodec ff_brender_pix_decoder;
 extern AVCodec ff_c93_decoder;
 extern AVCodec ff_cavs_decoder;
 extern AVCodec ff_cdgraphics_decoder;
+extern AVCodec ff_cdtoons_decoder;
 extern AVCodec ff_cdxl_decoder;
 extern AVCodec ff_cfhd_decoder;
 extern AVCodec ff_cinepak_encoder;
diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 77eb890549..207322b55f 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
@@ -460,6 +460,7 @@ enum AVCodecID {
 AV_CODEC_ID_IMM5,
 AV_CODEC_ID_MVDV,
 AV_CODEC_ID_MVHA,
+AV_CODEC_ID_CDTOONS,
 
 /* various PCM "codecs" */
 AV_CODEC_ID_FIRST_AUDIO = 0x1, ///< A dummy id pointing at the 
start of audio codecs
diff --git a/libavcodec/cdtoons.c b/libavcodec/cdtoons.c
new file mode 100644
index 00..41bd3d02f1
--- /dev/null
+++ b/libavcodec/cdtoons.c
@@ -0,0 +1,445 @@
+/*
+ * CDToons video decoder
+ * Copyright (C) 2011 The FFmpeg project
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * FFmpeg is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with FFmpeg; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+/**
+ * @file
+ * CDToons video decoder
+ * @author Alyssa Milburn 
+ */
+
+#include 
+
+#include "libavutil/attributes.h"
+#include "libavutil/internal.h"
+#include "avcodec.h"
+#include "bytestream.h"
+#include "internal.h"
+
+#define CDTOONS_HEADER_SIZE   44
+#define CDTOONS_MAX_SPRITES 1200
+
+typedef struct CDToonsSprite {
+uint16_t flags;
+uint16_t owner_frame;
+uint16_t start_frame;
+uint16_t end_frame;
+uint32_t size;
+uint8_t *data;
+} CDToonsSprite;
+
+typedef struct CDToonsContext {
+AVCodecContext *avctx;
+AVFrame *frame;
+
+uint16_t last_pal_id;   ///< The index of the active palette sprite.
+uint32_t pal[256];  ///< The currently-used palette data.
+CDToonsSprite sprites[CDTOONS_MAX_SPRITES];
+} CDToonsContext;
+
+static int cdtoons_render_sprite(AVCodecContext *avctx, const uint8_t *data,
+ uint32_t data_size,
+ int dst_x, int dst_y, int width, int height)
+{
+CDToonsContext *c = avctx->priv_data;
+const uint8_t *next_line = data;
+const uint8_t *end = data + data_size;;
+uint16_t line_size;
+uint8_t *dest;
+int skip = 0, to_skip, x;
+
+if (dst_x + width > avctx->width)
+width = avctx->width - dst_x;
+if (dst_y + height > avctx->height)
+height = avctx->height - dst_y;
+
+

[FFmpeg-devel] [avfomat/rtp: source ips lost when specified as URL options] Patch for ffmpeg using rtp protocol where sources option is not retained

2020-02-12 Thread phunkyfish 
---
 libavformat/rtsp.c | 26 --
 1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 859defa592..f922055134 100644
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -2334,7 +2334,9 @@ static int sdp_read_header(AVFormatContext *s)
 RTSPStream *rtsp_st;
 int size, i, err;
 char *content;
+const char *p, *sp="", *sources="", *sp2, *sources2;
 char url[1024];
+char sources_buf[1024];
 
 if (!ff_network_init())
 return AVERROR(EIO);
@@ -2360,6 +2362,16 @@ static int sdp_read_header(AVFormatContext *s)
 av_freep();
 if (err) goto fail;
 
+/* Search for sources= tag in original URL for rtp protocol only */
+if (strncmp(s->url, "rtp://", 6) == 0) {
+p = strchr(s->url, '?');
+if (p && av_find_info_tag(sources_buf, sizeof(sources_buf), "sources", 
p)) {
+/* av_log(s, AV_LOG_VERBOSE, "sdp_read_header found sources %s\n", 
sources_buf);  */
+sp = sources_buf;
+sources = "=";
+}
+}
+
 /* open each RTP stream */
 for (i = 0; i < rt->nb_rtsp_streams; i++) {
 char namebuf[50];
@@ -2377,12 +2389,22 @@ static int sdp_read_header(AVFormatContext *s)
 av_dict_free();
 goto fail;
 }
+
+/* Prepare to add sources to the url to be opened.
+   Otherwise the join to the source specific muliticast will be 
missing */
+sources2 = sources;
+sp2 = sp;
+/* ignore sources from original URL, when sources are already set 
in rtsp_st */
+if (rtsp_st->nb_include_source_addrs > 0)
+sources2 = sp2 = "";
+
 ff_url_join(url, sizeof(url), "rtp", NULL,
 namebuf, rtsp_st->sdp_port,
-"?localport=%d=%d=%d_to_source=%d",
+
"?localport=%d=%d=%d_to_source=%d%s%s",
 rtsp_st->sdp_port, rtsp_st->sdp_ttl,
 rt->rtsp_flags & RTSP_FLAG_FILTER_SRC ? 1 : 0,
-rt->rtsp_flags & RTSP_FLAG_RTCP_TO_SOURCE ? 1 : 0);
+rt->rtsp_flags & RTSP_FLAG_RTCP_TO_SOURCE ? 1 : 0,
+sources2, sp2);
 
 append_source_addrs(url, sizeof(url), "sources",
 rtsp_st->nb_include_source_addrs,
-- 
2.20.1 (Apple Git-117)

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [avfomat/rtp: source ips lost when specified as URL options] Patch for ffmpeg using rtp protocol where sources option is not retained

2020-02-12 Thread Ross Nicholson 
The patch was created as a workaround to an issue from in kodi (apologies,
it's a rather long thread):
https://forum.kodi.tv/showthread.php?tid=350901=2923550#pid2923550

As an example, here is a URL: rtp://87.141.215.251@232.0.10.234:1

Taking this URL we should be able to either reformat it to: rtp://
232.0.10.234:1?sources=87.141.215.251 or pass the sources as an av_dict
to avfomat_open_input.

Neither option works however. Instead the above workaround was created but
it's not really the right way to fix this. Would be great to get some
guidance on the right place to fix this in the right way.

Thanks in advance.

On Wed, 12 Feb 2020 at 19:40, phunkyfish  wrote:

> ---
>  libavformat/rtsp.c | 26 --
>  1 file changed, 24 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
> index 859defa592..f922055134 100644
> --- a/libavformat/rtsp.c
> +++ b/libavformat/rtsp.c
> @@ -2334,7 +2334,9 @@ static int sdp_read_header(AVFormatContext *s)
>  RTSPStream *rtsp_st;
>  int size, i, err;
>  char *content;
> +const char *p, *sp="", *sources="", *sp2, *sources2;
>  char url[1024];
> +char sources_buf[1024];
>
>  if (!ff_network_init())
>  return AVERROR(EIO);
> @@ -2360,6 +2362,16 @@ static int sdp_read_header(AVFormatContext *s)
>  av_freep();
>  if (err) goto fail;
>
> +/* Search for sources= tag in original URL for rtp protocol only */
> +if (strncmp(s->url, "rtp://", 6) == 0) {
> +p = strchr(s->url, '?');
> +if (p && av_find_info_tag(sources_buf, sizeof(sources_buf),
> "sources", p)) {
> +/* av_log(s, AV_LOG_VERBOSE, "sdp_read_header found sources
> %s\n", sources_buf);  */
> +sp = sources_buf;
> +sources = "=";
> +}
> +}
> +
>  /* open each RTP stream */
>  for (i = 0; i < rt->nb_rtsp_streams; i++) {
>  char namebuf[50];
> @@ -2377,12 +2389,22 @@ static int sdp_read_header(AVFormatContext *s)
>  av_dict_free();
>  goto fail;
>  }
> +
> +/* Prepare to add sources to the url to be opened.
> +   Otherwise the join to the source specific muliticast will
> be missing */
> +sources2 = sources;
> +sp2 = sp;
> +/* ignore sources from original URL, when sources are already
> set in rtsp_st */
> +if (rtsp_st->nb_include_source_addrs > 0)
> +sources2 = sp2 = "";
> +
>  ff_url_join(url, sizeof(url), "rtp", NULL,
>  namebuf, rtsp_st->sdp_port,
> -
> "?localport=%d=%d=%d_to_source=%d",
> +
> "?localport=%d=%d=%d_to_source=%d%s%s",
>  rtsp_st->sdp_port, rtsp_st->sdp_ttl,
>  rt->rtsp_flags & RTSP_FLAG_FILTER_SRC ? 1 : 0,
> -rt->rtsp_flags & RTSP_FLAG_RTCP_TO_SOURCE ? 1 :
> 0);
> +rt->rtsp_flags & RTSP_FLAG_RTCP_TO_SOURCE ? 1 : 0,
> +sources2, sp2);
>
>  append_source_addrs(url, sizeof(url), "sources",
>  rtsp_st->nb_include_source_addrs,
> --
> 2.20.1 (Apple Git-117)
>
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavformat/utils.c: Fixed URL parsing

2020-02-12 Thread Marton Balint 



On Wed, 12 Feb 2020, gautamr...@gmail.com wrote:


From: Gautam Ramakrishnan 

This commit fixes bug #8466 wherein URLs with query string
not preceeded by the '/' symbol in a URL was failing to get
parsed. The av_url_split() function now checks if the path
starts with a '/' and prepends it if it does not.
---
libavformat/utils.c | 7 +++
1 file changed, 7 insertions(+)

diff --git a/libavformat/utils.c b/libavformat/utils.c
index 81ea239a66..a14d4ef90d 100644
--- a/libavformat/utils.c
+++ b/libavformat/utils.c
@@ -4819,6 +4819,13 @@ void av_url_split(char *proto, int proto_size,
av_strlcpy(path, ls, path_size);
else
ls = [strlen(p)];  // XXX
+/* if path does not start with a /, prepend a / */
+if (path[0] != '/') {
+char temp[1024];
+av_strlcpy(temp, path, path_size);
+path[0] = '/';
+av_strlcpy(path + 1, temp, path_size - 1);
+}


I made a patch which fixes this in the HTTP protocol, as modifying the 
empty path to / is a HTTP requirement, other protocols might not need 
this.


http://mplayerhq.hu/pipermail/ffmpeg-devel/2020-February/256902.html

Regards,
Marton
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavformat/utils.c: Fixed URL parsing

2020-02-12 Thread Paul B Mahol 
On 2/12/20, gautamr...@gmail.com  wrote:
> From: Gautam Ramakrishnan 
>
> This commit fixes bug #8466 wherein URLs with query string
> not preceeded by the '/' symbol in a URL was failing to get
> parsed. The av_url_split() function now checks if the path
> starts with a '/' and prepends it if it does not.
> ---
>  libavformat/utils.c | 7 +++
>  1 file changed, 7 insertions(+)
>
> diff --git a/libavformat/utils.c b/libavformat/utils.c
> index 81ea239a66..a14d4ef90d 100644
> --- a/libavformat/utils.c
> +++ b/libavformat/utils.c
> @@ -4819,6 +4819,13 @@ void av_url_split(char *proto, int proto_size,
>  av_strlcpy(path, ls, path_size);
>  else
>  ls = [strlen(p)];  // XXX
> +/* if path does not start with a /, prepend a / */
> +if (path[0] != '/') {
> +char temp[1024];

What makes 1024 so special?

> +av_strlcpy(temp, path, path_size);
> +path[0] = '/';
> +av_strlcpy(path + 1, temp, path_size - 1);
> +}
>
>  /* the rest is hostname, use that to parse auth/port */
>  if (ls != p) {
> --
> 2.17.1
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] libavformat/utils.c: Fixed URL parsing

2020-02-12 Thread gautamramk 
From: Gautam Ramakrishnan 

This commit fixes bug #8466 wherein URLs with query string
not preceeded by the '/' symbol in a URL was failing to get
parsed. The av_url_split() function now checks if the path
starts with a '/' and prepends it if it does not.
---
 libavformat/utils.c | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/libavformat/utils.c b/libavformat/utils.c
index 81ea239a66..a14d4ef90d 100644
--- a/libavformat/utils.c
+++ b/libavformat/utils.c
@@ -4819,6 +4819,13 @@ void av_url_split(char *proto, int proto_size,
 av_strlcpy(path, ls, path_size);
 else
 ls = [strlen(p)];  // XXX
+/* if path does not start with a /, prepend a / */
+if (path[0] != '/') {
+char temp[1024];
+av_strlcpy(temp, path, path_size);
+path[0] = '/';
+av_strlcpy(path + 1, temp, path_size - 1);
+}
 
 /* the rest is hostname, use that to parse auth/port */
 if (ls != p) {
-- 
2.17.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/6] avformat/format: add av_demuxer_find_by_ext

2020-02-12 Thread Gyan Doshi 



On 01-02-2020 10:45 am, Gyan Doshi wrote:



On 31-01-2020 10:41 pm, Andreas Rheinhardt wrote:

Gyan Doshi:

Allows selecting demuxer by extension which are more widely recognized
by users.

Conditional cast added since this function will usually be called after
av_find_input_format, and so matches its return type.

That's not a good point. av_demuxer_find_by_ext() already always
returns const AVInputFormat *, so you casting the const away when
returning is pointless. Furthermore, any caller that wants to use this
new function can simply use a pointer to const AVInputFormat to work
with both av_find_input_format() and av_demuxer_find_by_ext(). And
after all, adding const makes the code more future-proof
(av_find_input_format() will return const AVInputFormat * after the
next major bump).


Ok, I don't think I should add const to the pointers at the receiving 
end (fftools) since they are global variables and may not be 
acceptable as const. So I'll cast away the const when receiving and 
remove the conditional cast.


Sounds fine?


Ping.

Gyan
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/apedec: Fix invalid shift with 24 bps

2020-02-12 Thread Michael Niedermayer 
On Wed, Feb 12, 2020 at 10:41:21AM +0100, Paul B Mahol wrote:
> LGTM

will apply

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 11/11] avcodec/avcodec: Nits

2020-02-12 Thread Andreas Rheinhardt 
On Tue, Dec 10, 2019 at 11:00 PM Andreas Rheinhardt <
andreas.rheinha...@gmail.com> wrote:

> Signed-off-by: Andreas Rheinhardt 
> ---
>  libavcodec/avcodec.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index 735a3c2d76..ab61f76337 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -4848,7 +4848,7 @@ int avcodec_decode_video2(AVCodecContext *avctx,
> AVFrame *picture,
>   * If no subtitle could be decompressed, got_sub_ptr is zero.
>   * Otherwise, the subtitle is stored in *sub.
>   * Note that AV_CODEC_CAP_DR1 is not available for subtitle codecs. This
> is for
> - * simplicity, because the performance difference is expect to be
> negligible
> + * simplicity, because the performance difference is expected to be
> negligible
>   * and reusing a get_buffer written for video codecs would probably
> perform badly
>   * due to a potentially very different allocation pattern.
>   *
> @@ -4864,7 +4864,7 @@ int avcodec_decode_video2(AVCodecContext *avctx,
> AVFrame *picture,
>   * before packets may be fed to the decoder.
>   *
>   * @param avctx the codec context
> - * @param[out] sub The Preallocated AVSubtitle in which the decoded
> subtitle will be stored,
> + * @param[out] sub The preallocated AVSubtitle in which the decoded
> subtitle will be stored,
>   * must be freed with avsubtitle_free if *got_sub_ptr is
> set.
>   * @param[in,out] got_sub_ptr Zero if no subtitle could be decompressed,
> otherwise, it is nonzero.
>   * @param[in] avpkt The input AVPacket containing the input buffer.
> @@ -4991,7 +4991,7 @@ int avcodec_send_frame(AVCodecContext *avctx, const
> AVFrame *frame);
>   * @param avctx codec context
>   * @param avpkt This will be set to a reference-counted packet allocated
> by the
>   *  encoder. Note that the function will always call
> - *  av_frame_unref(frame) before doing anything else.
> + *  av_packet_unref(avpkt) before doing anything else.
>   * @return 0 on success, otherwise negative error code:
>   *  AVERROR(EAGAIN):   output is not available in the current state -
> user
>   * must try to send input
> --
> 2.20.1
>

Ping.

- Andreas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/avpacket: Don't write into non-writable buffer

2020-02-12 Thread James Almer 
On 2/12/2020 12:44 PM, Andreas Rheinhardt wrote:
> On Wed, Feb 12, 2020 at 4:31 PM Andreas Rheinhardt <
> andreas.rheinha...@gmail.com> wrote:
> 
>> But given that it
>> also zeroes the padding it also needs to make sure that the buffer is
>> actually writable; this commit implements this.
>>
> 
> av_shrink_packet has a similar issue and it seems unfixable given that it
> is used with non-refcounted packets and doesn't return anything.
> 
> - Andreas

A solution could be introducing an av_packet_realloc/resize() function
that in practice implements both grow's and shrink's functionality, so
we can then deprecate the latter two (Good reason to do that as well,
seeing they don't use the av_packet_* namespace).
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/avpacket: Don't write into non-writable buffer

2020-02-12 Thread Andreas Rheinhardt 
On Wed, Feb 12, 2020 at 4:31 PM Andreas Rheinhardt <
andreas.rheinha...@gmail.com> wrote:

> But given that it
> also zeroes the padding it also needs to make sure that the buffer is
> actually writable; this commit implements this.
>

av_shrink_packet has a similar issue and it seems unfixable given that it
is used with non-refcounted packets and doesn't return anything.

- Andreas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 3/3] avcodec/avpacket: Don't write into non-writable buffer

2020-02-12 Thread Andreas Rheinhardt 
The data of an AVPacket may be a part of the data of an AVBufferRef;
Therefore av_grow_packet() doesn't reallocate if the available space in
the actual buffer is sufficient for the enlargement. But given that it
also zeroes the padding it also needs to make sure that the buffer is
actually writable; this commit implements this.

Signed-off-by: Andreas Rheinhardt 
---
 libavcodec/avpacket.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c
index 0d9ddeee07..a7b0b6bd5d 100644
--- a/libavcodec/avpacket.c
+++ b/libavcodec/avpacket.c
@@ -127,7 +127,8 @@ int av_grow_packet(AVPacket *pkt, int grow_by)
 return AVERROR(ENOMEM);
 }
 
-if (new_size + data_offset > pkt->buf->size) {
+if (new_size + data_offset > pkt->buf->size ||
+!av_buffer_is_writable(pkt->buf)) {
 int ret = av_buffer_realloc(>buf, new_size + data_offset);
 if (ret < 0) {
 pkt->data = old_data;
-- 
2.20.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/3] ffplay, avcodec, avformat: Don't initialize before av_packet_ref()

2020-02-12 Thread Andreas Rheinhardt 
It already initializes the packet.

Signed-off-by: Andreas Rheinhardt 
---
 fftools/ffplay.c  | 2 +-
 libavcodec/cuviddec.c | 2 +-
 libavcodec/qsvdec_h2645.c | 2 +-
 libavcodec/qsvdec_other.c | 2 +-
 libavformat/fifo.c| 1 -
 libavformat/img2enc.c | 8 
 libavformat/tee.c | 1 -
 7 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/fftools/ffplay.c b/fftools/ffplay.c
index fee0619f7c..746e5c0e69 100644
--- a/fftools/ffplay.c
+++ b/fftools/ffplay.c
@@ -2974,7 +2974,7 @@ static int read_thread(void *arg)
 }
 if (is->queue_attachments_req) {
 if (is->video_st && is->video_st->disposition & 
AV_DISPOSITION_ATTACHED_PIC) {
-AVPacket copy = { 0 };
+AVPacket copy;
 if ((ret = av_packet_ref(, >video_st->attached_pic)) 
< 0)
 goto fail;
 packet_queue_put(>videoq, );
diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c
index acee78cf2c..8b1659dc2e 100644
--- a/libavcodec/cuviddec.c
+++ b/libavcodec/cuviddec.c
@@ -387,7 +387,7 @@ static int cuvid_decode_packet(AVCodecContext *avctx, const 
AVPacket *avpkt)
 AVCUDADeviceContext *device_hwctx = device_ctx->hwctx;
 CUcontext dummy, cuda_ctx = device_hwctx->cuda_ctx;
 CUVIDSOURCEDATAPACKET cupkt;
-AVPacket filter_packet = { 0 };
+AVPacket filter_packet;
 AVPacket filtered_packet = { 0 };
 int ret = 0, eret = 0, is_flush = ctx->decoder_flushing;
 
diff --git a/libavcodec/qsvdec_h2645.c b/libavcodec/qsvdec_h2645.c
index 730feed20a..02c41883b6 100644
--- a/libavcodec/qsvdec_h2645.c
+++ b/libavcodec/qsvdec_h2645.c
@@ -125,7 +125,7 @@ static int qsv_decode_frame(AVCodecContext *avctx, void 
*data,
 
 /* buffer the input packet */
 if (avpkt->size) {
-AVPacket input_ref = { 0 };
+AVPacket input_ref;
 
 if (av_fifo_space(s->packet_fifo) < sizeof(input_ref)) {
 ret = av_fifo_realloc2(s->packet_fifo,
diff --git a/libavcodec/qsvdec_other.c b/libavcodec/qsvdec_other.c
index ff2834c20b..b4df76739c 100644
--- a/libavcodec/qsvdec_other.c
+++ b/libavcodec/qsvdec_other.c
@@ -123,7 +123,7 @@ static int qsv_decode_frame(AVCodecContext *avctx, void 
*data,
 
 /* buffer the input packet */
 if (avpkt->size) {
-AVPacket input_ref = { 0 };
+AVPacket input_ref;
 
 if (av_fifo_space(s->packet_fifo) < sizeof(input_ref)) {
 ret = av_fifo_realloc2(s->packet_fifo,
diff --git a/libavformat/fifo.c b/libavformat/fifo.c
index 7b37fff6da..d11dc6626c 100644
--- a/libavformat/fifo.c
+++ b/libavformat/fifo.c
@@ -536,7 +536,6 @@ static int fifo_write_packet(AVFormatContext *avf, AVPacket 
*pkt)
 int ret;
 
 if (pkt) {
-av_init_packet();
 ret = av_packet_ref(,pkt);
 if (ret < 0)
 return ret;
diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c
index a2786ec6f8..b303d38239 100644
--- a/libavformat/img2enc.c
+++ b/libavformat/img2enc.c
@@ -78,7 +78,7 @@ static int write_muxed_file(AVFormatContext *s, AVIOContext 
*pb, AVPacket *pkt)
 VideoMuxData *img = s->priv_data;
 AVCodecParameters *par = s->streams[pkt->stream_index]->codecpar;
 AVStream *st;
-AVPacket pkt2 = {0};
+AVPacket pkt2;
 AVFormatContext *fmt = NULL;
 int ret;
 
@@ -88,8 +88,8 @@ static int write_muxed_file(AVFormatContext *s, AVIOContext 
*pb, AVPacket *pkt)
 return ret;
 st = avformat_new_stream(fmt, NULL);
 if (!st) {
-avformat_free_context(fmt);
-return AVERROR(ENOMEM);
+ret = AVERROR(ENOMEM);
+goto out;
 }
 st->id = pkt->stream_index;
 
@@ -105,8 +105,8 @@ static int write_muxed_file(AVFormatContext *s, AVIOContext 
*pb, AVPacket *pkt)
 (ret = av_interleaved_write_frame(fmt, )) < 0 ||
 (ret = av_write_trailer(fmt))) {}
 
-out:
 av_packet_unref();
+out:
 avformat_free_context(fmt);
 return ret;
 }
diff --git a/libavformat/tee.c b/libavformat/tee.c
index 56669d9d8e..f2b11fcb35 100644
--- a/libavformat/tee.c
+++ b/libavformat/tee.c
@@ -564,7 +564,6 @@ static int tee_write_packet(AVFormatContext *avf, AVPacket 
*pkt)
 if (s2 < 0)
 continue;
 
-memset(, 0, sizeof(AVPacket));
 if ((ret = av_packet_ref(, pkt)) < 0)
 if (!ret_all) {
 ret_all = ret;
-- 
2.20.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: Always treat dst in av_packet_ref as uninitialized

2020-02-12 Thread Andreas Rheinhardt 
av_packet_ref() mostly treated the destination packet dst as uninitialized,
i.e. the destination fields were simply overwritten. But if the source
packet was not reference-counted, dst->buf was treated as if it pointed
to an already allocated buffer (if != NULL) to be reallocated to the
desired size.

The documentation did not explicitly state whether the dst will be treated
as uninitialized, but it stated that if the source packet is not refcounted,
a new buffer in dst will be allocated. This and the fact that the side-data
as well as the codepath taken in case src is refcounted always treated the
packet as uninitialized means that dst should always be treated as
uninitialized for the sake of consistency. And this behaviour has been
explicitly documented.

Signed-off-by: Andreas Rheinhardt 
---
 libavcodec/avcodec.h  | 2 +-
 libavcodec/avpacket.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index dc5807324f..982a545dc6 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
@@ -4600,7 +4600,7 @@ void av_packet_free_side_data(AVPacket *pkt);
  *
  * @see av_packet_unref
  *
- * @param dst Destination packet
+ * @param dst Destination packet. Will be treated as initially uninitialized.
  * @param src Source packet
  *
  * @return 0 on success, a negative AVERROR on error.
diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c
index 74845efcd2..0d9ddeee07 100644
--- a/libavcodec/avpacket.c
+++ b/libavcodec/avpacket.c
@@ -614,6 +614,7 @@ int av_packet_ref(AVPacket *dst, const AVPacket *src)
 return ret;
 
 if (!src->buf) {
+dst->buf = NULL;
 ret = packet_alloc(>buf, src->size);
 if (ret < 0)
 goto fail;
-- 
2.20.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] HEVC: Export motion vectors to frame side data.

2020-02-12 Thread Paul B Mahol 
On 2/12/20, Asaf Kave  wrote:
> On Wed, Feb 12, 2020 at 11:35 AM Paul B Mahol  wrote:
>
>> On 2/12/20, Asaf Kave  wrote:
>> > On Sun, Feb 9, 2020 at 10:59 AM Asaf Kave  wrote:
>> >
>> >>
>> >>
>> >> On Thu, Feb 6, 2020 at 4:10 PM Lynne  wrote:
>> >>
>> >>> Feb 6, 2020, 11:17 by kavea...@gmail.com:
>> >>>
>> >>> > On Sun, Feb 2, 2020 at 11:15 AM Asaf Kave 
>> wrote:
>> >>> >
>> >>> >>
>> >>> >>
>> >>> >> On Tue, Jan 28, 2020 at 11:44 PM Asaf Kave 
>> wrote:
>> >>> >>
>> >>> >>>
>> >>> >>>
>> >>> >>> On Sun, Jan 26, 2020, 12:31 Asaf Kave  wrote:
>> >>> >>>
>> >>> 
>> >>> 
>> >>>  On Wed, Jan 22, 2020 at 1:09 PM Asaf Kave 
>> >>> wrote:
>> >>> 
>> >>> >
>> >>> >
>> >>> > On Tue, Jan 21, 2020 at 8:17 PM Lynne  wrote:
>> >>> >
>> >>> >> Jan 20, 2020, 08:42 by kavea...@gmail.com:
>> >>> >>
>> >>> >> > Ping
>> >>> >> >
>> >>> >>
>> >>> >>
>> https://ffmpeg.org/pipermail/ffmpeg-devel/2019-August/248836.html
>> >>> >>
>> >>> >>
>> >>> >> I've okayed it, its just not been pushed yet.
>> >>> >> You'll need to add the vectors to the block struct. int16_t [2]
>> >>> will
>> >>> >> do.
>> >>> >>
>> >>> >
>> >>> > Thanks Lynne,
>> >>> > I didn't find the 'libavutil: AVEncodeInfo data structures'
>> >>> > commit\patch, even i try searching the code on the latest
>> 'master'
>> >>> branch.
>> >>> > Where can i get the new API ?
>> >>> >
>> >>> 
>> >>>  Hi,
>> >>>  Can someone accelerate this?
>> >>>  Thanks
>> >>> 
>> >>> 
>> >>> >>>
>> >>> >>> Ping
>> >>> >>>
>> >>> >>
>> >>> >> Pinging it again.
>> >>> >>
>> >>> >
>> >>> > Hello,
>> >>> > Can someone push this to master or if not than give me a feedback,
>> >>> > Thanks
>> >>> >
>> >>>
>> >>> You need to download the patch and apply it yourself.
>> >>>
>> >>
>> >> Thanks, but i getting this error :
>> >> > git push
>> >>  fatal: unable to access 'https://git.ffmpeg.org/ffmpeg.git/': The
>> >> requested URL returned error: 403
>> >>
>> >> I think i am not approval to push.
>> >>
>> > can someone push it?
>>
>> Your patch can not be pushed as is.
>> Instead it needs to be combined with another patch.
>>
> OK thank you, do i need to do something or only wait that somebody will
> combine it?

Very unlikely somebody will combine your patch with another for free.
So it all is up to you.

>
>>
>> >
>> >>
>> >>
>> >>> ___
>> >>> ffmpeg-devel mailing list
>> >>> ffmpeg-devel@ffmpeg.org
>> >>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> >>>
>> >>> To unsubscribe, visit link above, or email
>> >>> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
>> >>
>> >>
>> > ___
>> > ffmpeg-devel mailing list
>> > ffmpeg-devel@ffmpeg.org
>> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> >
>> > To unsubscribe, visit link above, or email
>> > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
>> ___
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] HEVC: Export motion vectors to frame side data.

2020-02-12 Thread Asaf Kave 
On Wed, Feb 12, 2020 at 11:35 AM Paul B Mahol  wrote:

> On 2/12/20, Asaf Kave  wrote:
> > On Sun, Feb 9, 2020 at 10:59 AM Asaf Kave  wrote:
> >
> >>
> >>
> >> On Thu, Feb 6, 2020 at 4:10 PM Lynne  wrote:
> >>
> >>> Feb 6, 2020, 11:17 by kavea...@gmail.com:
> >>>
> >>> > On Sun, Feb 2, 2020 at 11:15 AM Asaf Kave 
> wrote:
> >>> >
> >>> >>
> >>> >>
> >>> >> On Tue, Jan 28, 2020 at 11:44 PM Asaf Kave 
> wrote:
> >>> >>
> >>> >>>
> >>> >>>
> >>> >>> On Sun, Jan 26, 2020, 12:31 Asaf Kave  wrote:
> >>> >>>
> >>> 
> >>> 
> >>>  On Wed, Jan 22, 2020 at 1:09 PM Asaf Kave 
> >>> wrote:
> >>> 
> >>> >
> >>> >
> >>> > On Tue, Jan 21, 2020 at 8:17 PM Lynne  wrote:
> >>> >
> >>> >> Jan 20, 2020, 08:42 by kavea...@gmail.com:
> >>> >>
> >>> >> > Ping
> >>> >> >
> >>> >>
> >>> >>
> https://ffmpeg.org/pipermail/ffmpeg-devel/2019-August/248836.html
> >>> >>
> >>> >>
> >>> >> I've okayed it, its just not been pushed yet.
> >>> >> You'll need to add the vectors to the block struct. int16_t [2]
> >>> will
> >>> >> do.
> >>> >>
> >>> >
> >>> > Thanks Lynne,
> >>> > I didn't find the 'libavutil: AVEncodeInfo data structures'
> >>> > commit\patch, even i try searching the code on the latest
> 'master'
> >>> branch.
> >>> > Where can i get the new API ?
> >>> >
> >>> 
> >>>  Hi,
> >>>  Can someone accelerate this?
> >>>  Thanks
> >>> 
> >>> 
> >>> >>>
> >>> >>> Ping
> >>> >>>
> >>> >>
> >>> >> Pinging it again.
> >>> >>
> >>> >
> >>> > Hello,
> >>> > Can someone push this to master or if not than give me a feedback,
> >>> > Thanks
> >>> >
> >>>
> >>> You need to download the patch and apply it yourself.
> >>>
> >>
> >> Thanks, but i getting this error :
> >> > git push
> >>  fatal: unable to access 'https://git.ffmpeg.org/ffmpeg.git/': The
> >> requested URL returned error: 403
> >>
> >> I think i am not approval to push.
> >>
> > can someone push it?
>
> Your patch can not be pushed as is.
> Instead it needs to be combined with another patch.
>
OK thank you, do i need to do something or only wait that somebody will
combine it?

>
> >
> >>
> >>
> >>> ___
> >>> ffmpeg-devel mailing list
> >>> ffmpeg-devel@ffmpeg.org
> >>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >>>
> >>> To unsubscribe, visit link above, or email
> >>> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
> >>
> >>
> > ___
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Getting Started On ffmpeg development

2020-02-12 Thread James Almer 
On 2/12/2020 9:02 AM, Goutham Kancherla wrote:
> Greetings,
> I have just begun to explore the code-base of ffmpeg repository found on
> 
> https://github.com/FFmpeg/FFmpeg
> 
> I hope that I have accessed the correct and official repository.
> I have searched for the code documentation i.e, the architecture and flow
> of the development.But, my efforts have been futile.
> Can someone point me to the documentation and a basic flow of the code?
> 
> Hope to hear from someone soon.
> Cheers

Hello! You can start by looking at https://ffmpeg.org/developer.html
And the Github repository is a mirror. The official one is
https://git.videolan.org/?p=ffmpeg.git or
https://source.ffmpeg.org/?p=ffmpeg.git
There's also the #ffmpeg-devel channel on FreeNode if you have questions
about development of ffmpeg.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] Getting Started On ffmpeg development

2020-02-12 Thread Goutham Kancherla 
Greetings,
I have just begun to explore the code-base of ffmpeg repository found on

https://github.com/FFmpeg/FFmpeg

I hope that I have accessed the correct and official repository.
I have searched for the code documentation i.e, the architecture and flow
of the development.But, my efforts have been futile.
Can someone point me to the documentation and a basic flow of the code?

Hope to hear from someone soon.
Cheers
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/apedec: Fix invalid shift with 24 bps

2020-02-12 Thread Paul B Mahol 
LGTM

On 2/11/20, Michael Niedermayer  wrote:
> Fixes: left shift of negative value -463
> Fixes:
> 20542/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5688714435231744
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer 
> ---
>  libavcodec/apedec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c
> index 0e749db63b..d643d6790e 100644
> --- a/libavcodec/apedec.c
> +++ b/libavcodec/apedec.c
> @@ -1555,7 +1555,7 @@ static int ape_decode_frame(AVCodecContext *avctx,
> void *data,
>  for (ch = 0; ch < s->channels; ch++) {
>  sample24 = (int32_t *)frame->data[ch];
>  for (i = 0; i < blockstodecode; i++)
> -*sample24++ = s->decoded[ch][i] << 8;
> +*sample24++ = s->decoded[ch][i] * 256;
>  }
>  break;
>  }
> --
> 2.17.1
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] HEVC: Export motion vectors to frame side data.

2020-02-12 Thread Paul B Mahol 
On 2/12/20, Asaf Kave  wrote:
> On Sun, Feb 9, 2020 at 10:59 AM Asaf Kave  wrote:
>
>>
>>
>> On Thu, Feb 6, 2020 at 4:10 PM Lynne  wrote:
>>
>>> Feb 6, 2020, 11:17 by kavea...@gmail.com:
>>>
>>> > On Sun, Feb 2, 2020 at 11:15 AM Asaf Kave  wrote:
>>> >
>>> >>
>>> >>
>>> >> On Tue, Jan 28, 2020 at 11:44 PM Asaf Kave  wrote:
>>> >>
>>> >>>
>>> >>>
>>> >>> On Sun, Jan 26, 2020, 12:31 Asaf Kave  wrote:
>>> >>>
>>> 
>>> 
>>>  On Wed, Jan 22, 2020 at 1:09 PM Asaf Kave 
>>> wrote:
>>> 
>>> >
>>> >
>>> > On Tue, Jan 21, 2020 at 8:17 PM Lynne  wrote:
>>> >
>>> >> Jan 20, 2020, 08:42 by kavea...@gmail.com:
>>> >>
>>> >> > Ping
>>> >> >
>>> >>
>>> >> https://ffmpeg.org/pipermail/ffmpeg-devel/2019-August/248836.html
>>> >>
>>> >>
>>> >> I've okayed it, its just not been pushed yet.
>>> >> You'll need to add the vectors to the block struct. int16_t [2]
>>> will
>>> >> do.
>>> >>
>>> >
>>> > Thanks Lynne,
>>> > I didn't find the 'libavutil: AVEncodeInfo data structures'
>>> > commit\patch, even i try searching the code on the latest 'master'
>>> branch.
>>> > Where can i get the new API ?
>>> >
>>> 
>>>  Hi,
>>>  Can someone accelerate this?
>>>  Thanks
>>> 
>>> 
>>> >>>
>>> >>> Ping
>>> >>>
>>> >>
>>> >> Pinging it again.
>>> >>
>>> >
>>> > Hello,
>>> > Can someone push this to master or if not than give me a feedback,
>>> > Thanks
>>> >
>>>
>>> You need to download the patch and apply it yourself.
>>>
>>
>> Thanks, but i getting this error :
>> > git push
>>  fatal: unable to access 'https://git.ffmpeg.org/ffmpeg.git/': The
>> requested URL returned error: 403
>>
>> I think i am not approval to push.
>>
> can someone push it?

Your patch can not be pushed as is.
Instead it needs to be combined with another patch.

>
>>
>>
>>> ___
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel@ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
>>
>>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avutil/log: Add av_log_once() for printing a message just once with a high log level

2020-02-12 Thread Michael Niedermayer 
On Sun, Feb 02, 2020 at 11:49:56AM +0100, Michael Niedermayer wrote:
> Compared to ad-hoc if(printed) ... code this allows the user to disable
> it by adjusting the log level
> 

> TODO: APIChanges & version bump

will add and will apply


[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The day soldiers stop bringing you their problems is the day you have stopped 
leading them. They have either lost confidence that you can help or concluded 
you do not care. Either case is a failure of leadership. - Colin Powell


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".