[FFmpeg-devel] Patch vf_blackdetect
This is now the working version from my last patch. Description: This patch unify vf_blackdetect with af_silencedetect. Now the logging prints black_start and black_end in separate lines. This is the same behavior like af_silencedetect and it is also more useful for monitoring streams. Is it ok, as attachment? 0001-unify-blackdetect-with-af_silencedetect.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] Last Patch: vf_blackdetect
Please forget the last patch! Something is not working right. Sorry! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] Patch vf_blackdetect
This patch unify vf_blackdetect with af_silencedetect. Now the logging prints black_start and black_end in separate lines. This is the same behavior like af_silencedetect and it is also more useful for monitoring streams. 0001-unify-blackdetect-with-af_silencedetect.-Is-more-use.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] dh option in nnedi3
Hello All, sorry for that question - I know is open source and we can add option by ours self, but my knowledge is to limited for that. Is it possible to integrate the dh (double high) option from vapoursynth nnedi3 filter to the ffmpeg nnedi filter? I have start copy parts from the sources, but I hang from line 709 on in the ffmpeg version. Regards Jonathan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Patch for device list error in decklink_common.cpp
Thanks Ramiro for the correction!
Here is the new patch. (Is it better to post directly the patch, or is ok
as a attachment?)
Regards
Jonathan
2014-12-02 22:19 GMT+01:00 Ramiro Polla ramiro.po...@gmail.com:
On 02.12.2014 20:30, Jon bae wrote:
Here is the other patch for decklink_common.cpp. It fix the error:
COM initialization failed
[decklink @ 02e5b520] Could not create DeckLink iterator
dummy: Immediate exit request
From 203eba2fad14dd6d84552d6c22899792e80b53bb Mon Sep 17 00:00:00 2001
From: Jonathan Baecker jonba...@gmail.com
Date: Tue, 2 Dec 2014 20:12:38 +0100
Subject: [PATCH 2/2] device list error in decklink_common
Signed-off-by: Jonathan Baecker jonba...@gmail.com
---
libavdevice/decklink_common.cpp | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/libavdevice/decklink_common.cpp
b/libavdevice/decklink_common.cpp
index 8eff910..8f7e32a 100644
--- a/libavdevice/decklink_common.cpp
+++ b/libavdevice/decklink_common.cpp
@@ -42,16 +42,20 @@ IDeckLinkIterator *CreateDeckLinkIteratorInstance
(void)
{
IDeckLinkIterator *iter;
-if (CoInitialize(NULL) != S_OK) {
-av_log(NULL, AV_LOG_ERROR, COM initialization failed.\n);
-return NULL;
-}
-
-if (CoCreateInstance(CLSID_CDeckLinkIterator, NULL, CLSCTX_ALL,
- IID_IDeckLinkIterator, (void**) iter) != S_OK)
{
-av_log(NULL, AV_LOG_ERROR, DeckLink drivers not installed.\n);
-return NULL;
-}
+HRESULT result;
+/* Initialize COM on this thread */
+result = CoInitialize(NULL);
+if (FAILED(result)) {
+av_log(NULL, AV_LOG_ERROR, COM initialization failed.\n);
+return NULL;
+}
+
+/* Create an IDeckLinkIterator object to enumerate all DeckLink
cards in the system */
+result = CoCreateInstance(CLSID_CDeckLinkIterator, NULL,
CLSCTX_ALL, IID_IDeckLinkIterator, (void**)iter);
+if (FAILED(result)) {
+av_log(NULL, AV_LOG_ERROR, DeckLink drivers not installed.\n);
+return NULL;
+}
return iter;
}
--
2.2.0
This code is Copyright (c) Blackmagic Design. Try just changing the check
for CoInitialize(NULL) from != S_OK to 0.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
0001-fix-COM-initialization-failed.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] fix for decklink_common.cpp
Hello everybody, on the Zeranoe forum we find out that there is two bugs in the decklink_common.cpp file. I build I patch and want to send them now to you. I hope is all right, I never did before a git format-patch... Regards! Jonathan fix-device_list-and-COM-initialization-failed_in decklink_common.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] fix for decklink_common.cpp
Hello Carl, that means that the patch is at the moment not useful?! This code comes from the decklink sdk and there was also the FAILED() defined, I think. I have the code from here: http://ffmpeg.zeranoe.com/forum/viewtopic.php?f=10t=1823start=10#p7580 and there they say it works. When is ok for you, I copy your answer to the zeranoe forum, then they can help me to fix it. 2014-12-02 16:45 GMT+01:00 Carl Eugen Hoyos ceho...@ag.or.at: Jon bae jonbae77 at gmail.com writes: I hope is all right, I never did before a git format-patch... You used git format-patch perfectly, thank you. Your patch introduces tabs, they cannot be committed to FFmpeg. You can find tabs with tools/patcheck, a script that is part of the source. Please do not replace av_log() with fprintf(). Please do not move opening braces, just leave them where they are now. Please keep the indentation at four spaces. Assuming that the free fix is unrelated to the remaining patch, please make it separate. (I don't know where FAILED() is defined and therefore cannot comment on the actual patch and if it can be simplified.) Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] Patch for heap corruption run time error in decklink_common.cpp
Ok here a second run, I try to follow the instruction from Carl Eugen. This is the first patch for decklink_common.cpp. It fix this error: Unhandled exception at 0x76FA4102 (ntdll.dll) in ffmpeg.exe: 0xC374: A heap has been corrupted (parameters: 0x7701B4B0). Regards Jonathan From e9bc8e910f515af4030054df3e6feb308f3208aa Mon Sep 17 00:00:00 2001 From: Jonathan Baecker jonba...@gmail.com Date: Tue, 2 Dec 2014 20:10:41 +0100 Subject: [PATCH 1/2] heap corruption run time error in decklink_common Signed-off-by: Jonathan Baecker jonba...@gmail.com --- libavdevice/decklink_common.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavdevice/decklink_common.cpp b/libavdevice/decklink_common.cpp index 9a9e44b..8eff910 100644 --- a/libavdevice/decklink_common.cpp +++ b/libavdevice/decklink_common.cpp @@ -69,9 +69,12 @@ static char *dup_wchar_to_utf8(wchar_t *w) } #define DECKLINK_STROLECHAR * #define DECKLINK_STRDUP dup_wchar_to_utf8 +#define DECKLINK_FREE(s) SysFreeString(s) #else #define DECKLINK_STRconst char * #define DECKLINK_STRDUP av_strdup +/* free() is needed for a string returned by the DeckLink SDL. */ +#define DECKLINK_FREE(s) free((void *) s) #endif HRESULT ff_decklink_get_display_name(IDeckLink *This, const char **displayName) @@ -81,8 +84,7 @@ HRESULT ff_decklink_get_display_name(IDeckLink *This, const char **displayName) if (hr != S_OK) return hr; *displayName = DECKLINK_STRDUP(tmpDisplayName); -/* free() is needed for a string returned by the DeckLink SDL. */ -free((void *) tmpDisplayName); +DECKLINK_FREE(tmpDisplayName); return hr; } -- 2.2.0 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
