Re: [FFmpeg-devel] [PATCH v2 0/8] ddagrab source filter, lavfi.c wrapped_avframe and dependent changes

2022-07-20 Thread Mark Himsley
On Tue, 19 Jul 2022 at 13:20, Timo Rothenpieler  wrote:

> I added an explicit configure check for that type.
> Definitely odd, IDXGIOutput5 and it are both Windows 10 APIs, so I'd
> have expected them to always exist in tandem.

Thank you - that fixed the build for me.

> You might want to update or repair your weird Windows SDK.

I thought x86_64-w64-mingw32 was quite standard.

Anyway - thanks :-)

-- 
Mark Himsley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


Re: [FFmpeg-devel] [PATCH v2 0/8] ddagrab source filter, lavfi.c wrapped_avframe and dependent changes

2022-07-19 Thread Mark Himsley
t a function or function pointer
  215 | prev_dpi_ctx =
set_thread_dpi(DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2);
  |^~
libavfilter/vsrc_ddagrab.c:158:22: note: declared here
  158 | set_thread_dpi_t set_thread_dpi;
  |  ^~
libavfilter/vsrc_ddagrab.c:229:13: error: called object
'set_thread_dpi' is not a function or function pointer
  229 | set_thread_dpi(prev_dpi_ctx);
  | ^~
libavfilter/vsrc_ddagrab.c:158:22: note: declared here
  158 | set_thread_dpi_t set_thread_dpi;
  |  ^~
libavfilter/vsrc_ddagrab.c:233:24: warning: assignment to 'int' from
'void *' makes integer from pointer without a cast [-Wint-conversion]
  233 | set_thread_dpi = NULL;
  |^
libavfilter/vsrc_ddagrab.c:239:24: warning: assignment to 'int' from
'void *' makes integer from pointer without a cast [-Wint-conversion]
  239 | set_thread_dpi = NULL;
  |^
make: *** [ffbuild/common.mak:81: libavfilter/vsrc_ddagrab.o] Error 1



I had hoped that if I included `--disable-indev=gdigrab` in my
./configure then I could get around this problem, but it seems not -
the build continues to fail at the same place.

-- 
Mark Himsley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


Re: [FFmpeg-devel] [PATCH v2 0/8] ddagrab source filter, lavfi.c wrapped_avframe and dependent changes

2022-07-19 Thread Mark Himsley
set_thread_dpi = NULL;
  |^
make: *** [ffbuild/common.mak:81: libavfilter/vsrc_ddagrab.o] Error 1

-- 
Mark Himsley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


Re: [FFmpeg-devel] 64b3aac8d0 "h264: Use common SEI types" broke cross-compile for OSX

2021-01-22 Thread Mark Himsley
On Fri, 22 Jan 2021 at 11:11, Andreas Rheinhardt
 wrote:
>
> Mark Himsley:
> > I cross-compile for OSX on Linux. Last night's commit 64b3aac8d0
> > "h264: Use common SEI types" seems to have broken the build.
> >
> > ./configure --extra-version=static_osx_x86_64_202101221019
> > --extra-cflags=  --extra-libs= -lpthread -lm
> > --pkg-config-flags=--static --cross-prefix=x86_64-apple-darwin15-
> >--arch=x86_64 --target-os=darwin --prefix=/opt/ffbuild
> > --enable-gpl --enable-version3 --enable-nonfree
> > --disable-ffplay --disable-dxva2
> > --cc=/opt/osxcross/target/bin/x86_64-apple-darwin15-cc
> > --enable-libxml2 --enable-openssl --enable-libsrt --enable-libmp3lame
> > --enable-libspeex --enable-libtheora --enable-libvorbis
> > --enable-libopus --enable-libxvid --enable-libvpx --enable-libfdk-aac
> > --enable-libx264 --enable-libx265 --enable-libopenjpeg --enable-libaom
> >
> > make V=1 ${ffbuild_make}
> > ...
> > /opt/osxcross/target/bin/x86_64-apple-darwin15-cc -I. -I./
> > -I/opt/ffbuild/include -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64
> > -D_LARGEFILE_SOURCE -I./compat/dispatch_semaphore -DPIC -DZLIB_CONST
> > -DHAVE_AV_CONFIG_H -DBUILDING_avcodec -I/opt/ffbuild/include
> > -std=c11 -Werror=partial-availability -fomit-frame-pointer -fPIC
> > -pthread -I/opt/ffbuild/include -I/opt/ffbuild/include
> > -I/opt/ffbuild/include -I/opt/ffbuild/include/openjpeg-2.4
> > -I/opt/ffbuild/include/opus -I/opt/ffbuild/include/opus
> > -I/opt/ffbuild/include -I/opt/ffbuild/include
> > -I/opt/ffbuild/include/srt -I/opt/ffbuild/include
> > -I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include
> > -I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include
> > -I/opt/ffbuild/include -I/opt/ffbuild/include
> > -I/opt/ffbuild/include/libxml2 -I/opt/ffbuild/include -g
> > -Wdeclaration-after-statement -Wall -Wdisabled-optimization
> > -Wpointer-arith -Wredundant-decls -Wwrite-strings -Wtype-limits
> > -Wundef -Wmissing-prototypes -Wno-pointer-to-int-cast
> > -Wstrict-prototypes -Wempty-body -Wno-parentheses -Wno-switch
> > -Wno-format-zero-length -Wno-pointer-sign -Wno-unused-const-variable
> > -Wno-char-subscripts -O3 -fno-math-errno -fno-signed-zeros
> > -mstack-alignment=16 -Qunused-arguments
> > -Werror=implicit-function-declaration -Werror=missing-prototypes
> > -Werror=return-type   -MMD -MF libavcodec/vmdvideo.d -MT
> > libavcodec/vmdvideo.o -c -o libavcodec/vmdvideo.o
> > libavcodec/vmdvideo.c
> > libavcodec/videotoolboxenc.c:1754:37: error: use of undeclared
> > identifier 'SEI_TYPE_USER_DATA_REGISTERED'; did you mean
> > 'SEI_TYPE_USER_DATA_UNREGISTERED'?
> > SEI_TYPE_USER_DATA_REGISTERED,
> > ^
> > SEI_TYPE_USER_DATA_UNREGISTERED
> > libavcodec/sei.h:35:5: note: 'SEI_TYPE_USER_DATA_UNREGISTERED' declared here
> > SEI_TYPE_USER_DATA_UNREGISTERED  = 5,
> > ^
> > libavcodec/videotoolboxenc.c:1810:37: error: use of undeclared
> > identifier 'SEI_TYPE_USER_DATA_REGISTERED'; did you mean
> > 'SEI_TYPE_USER_DATA_UNREGISTERED'?
> > SEI_TYPE_USER_DATA_REGISTERED,
> > ^
> > SEI_TYPE_USER_DATA_UNREGISTERED
> > libavcodec/sei.h:35:5: note: 'SEI_TYPE_USER_DATA_UNREGISTERED' declared here
> > SEI_TYPE_USER_DATA_UNREGISTERED  = 5,
> > ^
> > libavcodec/videotoolboxenc.c:1906:45: error: use of undeclared
> > identifier 'SEI_TYPE_USER_DATA_REGISTERED'; did you mean
> > 'SEI_TYPE_USER_DATA_UNREGISTERED'?
> > SEI_TYPE_USER_DATA_REGISTERED);
> > ^
> > SEI_TYPE_USER_DATA_UNREGISTERED
> > libavcodec/sei.h:35:5: note: 'SEI_TYPE_USER_DATA_UNREGISTERED' declared here
> > SEI_TYPE_USER_DATA_UNREGISTERED  = 5,
> > ^
> > 3 errors generated.
> > ffbuild/common.mak:67: recipe for target 'libavcodec/videotoolboxenc.o' 
> > failed
> > make: *** [libavcodec/videotoolboxenc.o] Error 1
> >
> >
> Please test this patch here:
> https://ffmpeg.org/pipermail/ffmpeg-devel/2021-January/274958.html

Yes - with that patch my OSX build compiles in now. I have not tested
FFmpeg doing a transcode, but it executes.

I'm going to test a Linux x86-64 compile and a Windows-x86-64 cross-compile too.

Thank you Andreas.

-- 
Mark Himsley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] 64b3aac8d0 "h264: Use common SEI types" broke cross-compile for OSX

2021-01-22 Thread Mark Himsley
I cross-compile for OSX on Linux. Last night's commit 64b3aac8d0
"h264: Use common SEI types" seems to have broken the build.

./configure --extra-version=static_osx_x86_64_202101221019
--extra-cflags=  --extra-libs= -lpthread -lm
--pkg-config-flags=--static --cross-prefix=x86_64-apple-darwin15-
   --arch=x86_64 --target-os=darwin --prefix=/opt/ffbuild
--enable-gpl --enable-version3 --enable-nonfree
--disable-ffplay --disable-dxva2
--cc=/opt/osxcross/target/bin/x86_64-apple-darwin15-cc
--enable-libxml2 --enable-openssl --enable-libsrt --enable-libmp3lame
--enable-libspeex --enable-libtheora --enable-libvorbis
--enable-libopus --enable-libxvid --enable-libvpx --enable-libfdk-aac
--enable-libx264 --enable-libx265 --enable-libopenjpeg --enable-libaom

make V=1 ${ffbuild_make}
...
/opt/osxcross/target/bin/x86_64-apple-darwin15-cc -I. -I./
-I/opt/ffbuild/include -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -I./compat/dispatch_semaphore -DPIC -DZLIB_CONST
-DHAVE_AV_CONFIG_H -DBUILDING_avcodec -I/opt/ffbuild/include
-std=c11 -Werror=partial-availability -fomit-frame-pointer -fPIC
-pthread -I/opt/ffbuild/include -I/opt/ffbuild/include
-I/opt/ffbuild/include -I/opt/ffbuild/include/openjpeg-2.4
-I/opt/ffbuild/include/opus -I/opt/ffbuild/include/opus
-I/opt/ffbuild/include -I/opt/ffbuild/include
-I/opt/ffbuild/include/srt -I/opt/ffbuild/include
-I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include
-I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include
-I/opt/ffbuild/include -I/opt/ffbuild/include
-I/opt/ffbuild/include/libxml2 -I/opt/ffbuild/include -g
-Wdeclaration-after-statement -Wall -Wdisabled-optimization
-Wpointer-arith -Wredundant-decls -Wwrite-strings -Wtype-limits
-Wundef -Wmissing-prototypes -Wno-pointer-to-int-cast
-Wstrict-prototypes -Wempty-body -Wno-parentheses -Wno-switch
-Wno-format-zero-length -Wno-pointer-sign -Wno-unused-const-variable
-Wno-char-subscripts -O3 -fno-math-errno -fno-signed-zeros
-mstack-alignment=16 -Qunused-arguments
-Werror=implicit-function-declaration -Werror=missing-prototypes
-Werror=return-type   -MMD -MF libavcodec/vmdvideo.d -MT
libavcodec/vmdvideo.o -c -o libavcodec/vmdvideo.o
libavcodec/vmdvideo.c
libavcodec/videotoolboxenc.c:1754:37: error: use of undeclared
identifier 'SEI_TYPE_USER_DATA_REGISTERED'; did you mean
'SEI_TYPE_USER_DATA_UNREGISTERED'?
SEI_TYPE_USER_DATA_REGISTERED,
^
SEI_TYPE_USER_DATA_UNREGISTERED
libavcodec/sei.h:35:5: note: 'SEI_TYPE_USER_DATA_UNREGISTERED' declared here
SEI_TYPE_USER_DATA_UNREGISTERED  = 5,
^
libavcodec/videotoolboxenc.c:1810:37: error: use of undeclared
identifier 'SEI_TYPE_USER_DATA_REGISTERED'; did you mean
'SEI_TYPE_USER_DATA_UNREGISTERED'?
SEI_TYPE_USER_DATA_REGISTERED,
^
SEI_TYPE_USER_DATA_UNREGISTERED
libavcodec/sei.h:35:5: note: 'SEI_TYPE_USER_DATA_UNREGISTERED' declared here
SEI_TYPE_USER_DATA_UNREGISTERED  = 5,
^
libavcodec/videotoolboxenc.c:1906:45: error: use of undeclared
identifier 'SEI_TYPE_USER_DATA_REGISTERED'; did you mean
'SEI_TYPE_USER_DATA_UNREGISTERED'?
SEI_TYPE_USER_DATA_REGISTERED);
^
SEI_TYPE_USER_DATA_UNREGISTERED
libavcodec/sei.h:35:5: note: 'SEI_TYPE_USER_DATA_UNREGISTERED' declared here
SEI_TYPE_USER_DATA_UNREGISTERED  = 5,
^
3 errors generated.
ffbuild/common.mak:67: recipe for target 'libavcodec/videotoolboxenc.o' failed
make: *** [libavcodec/videotoolboxenc.o] Error 1


-- 
Mark Himsley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50

2020-08-18 Thread Mark Himsley
Sorry to drag up this old thread:

On Mon, 19 Aug 2019 at 17:55, Thomas Mundt  wrote:
...
> I can give you the parameters that I use for IMX50. Not sure if these are
> the best. Got the intra matrix values from an original imx file.
>
> NTSC: -c:v mpeg2video -pix_fmt yuv422p -aspect 16:9 -top 1 -flags
> +ildct+ilme+low_delay -color_range tv -color_trc smpte170m -color_primaries
> smpte170m -colorspace smpte170m -chroma_sample_location topleft
> -signal_standard bt601 -dc 10 -intra_vlc 1 -non_linear_quant 1 -ps 1 -g 1
> -qscale:v 1 -qmin 1 -qmax 12 -b:v 4841 -minrate 4841 -maxrate
> 4841 -bufsize 1668329 -rc_init_occupancy 1668329 -rc_min_vbv_use 1
> -rc_max_vbv_use 1 -profile:v 0 -level:v 5 -intra_matrix
> 8,16,16,17,19,22,23,31,16,16,17,19,20,23,29,29,19,17,19,22,19,25,28,35,17,19,19,20,25,28,25,33,17,19,22,25,26,25,31,31,17,19,17,20,26,28,35,36,19,19,19,20,22,29,32,35,16,17,19,22,25,31,28,45
>
> PAL: -c:v mpeg2video -pix_fmt yuv422p -aspect 16:9 -top 1 -flags
> +ildct+ilme+low_delay -color_range tv -color_trc smpte170m -color_primaries
> bt470bg -colorspace bt470bg -chroma_sample_location topleft
> -signal_standard bt601 -dc 10 -intra_vlc 1 -non_linear_quant 1 -ps 1 -g 1
> -qscale:v 1 -qmin 1 -qmax 12 -b:v 5000 -minrate 5000 -maxrate
> 5000 -bufsize 200 -rc_init_occupancy 200 -rc_min_vbv_use 1
> -rc_max_vbv_use 1 -profile:v 0 -level:v 5 -intra_matrix
> 8,16,16,17,19,22,23,31,16,16,17,19,20,23,29,29,19,17,19,22,19,25,28,35,17,19,19,20,25,28,25,33,17,19,22,25,26,25,31,31,17,19,17,20,26,28,35,36,19,19,19,20,22,29,32,35,16,17,19,22,25,31,28,45
>
> Regards,
> Thomas

As it stands, FFmpeg from `master` cannot create 3/1001 FPS IMX50,
and it has to be patched to allow 4841 to be the valid bitrate,
not 48410 which is in the source code.
Is there any movement on this issue?
Why is 4840 in the source code as a variant on 5000 when it
just does not work?
Is it not better to put 4841 into the source code?

-- 
Mark Himsley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: cancel pending IO on win32 manually

2020-02-03 Thread Mark Himsley
On Mon, 3 Feb 2020 at 17:19, Marton Balint  wrote:
>
>
>
> On Mon, 3 Feb 2020, Mark Himsley wrote:
>
> > On Sun, 26 Jan 2020 at 21:22, Marton Balint  wrote:
> >>
> >> recvfrom() is not a cancellation point in pthreads-win32, see
> >> https://sourceware.org/pthreads-win32/manual/pthread_cancel.html
> >>
> >> In order to be able to cancel the reader thread on Win32 properly we first
> >> shutdown the socket then call CancelIoEx to abort pending IO. Subsequent
> >> recvfrom() calls will fail with WSAESHUTDOWN causing the thread to exit.
> >>
> >> Fixes ticket #5717.
> >>
> >> Signed-off-by: Marton Balint 
> >> ---
> >>  libavformat/udp.c | 11 ++-
> >>  1 file changed, 10 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/libavformat/udp.c b/libavformat/udp.c
> >> index 85c9e3a900..23c3773c64 100644
> >> --- a/libavformat/udp.c
> >> +++ b/libavformat/udp.c
> >> @@ -1069,8 +1069,17 @@ static int udp_close(URLContext *h)
> >>  if (s->thread_started) {
> >>  int ret;
> >>  // Cancel only read, as write has been signaled as success to the 
> >> user
> >> -if (h->flags & AVIO_FLAG_READ)
> >> +if (h->flags & AVIO_FLAG_READ) {
> >> +#ifdef _WIN32
> >> +/* recvfrom() is not a cancellation point for win32, so we 
> >> shutdown
> >> + * the socket and abort pending IO, subsequent recvfrom() 
> >> calls
> >> + * will fail with WSAESHUTDOWN causing the thread to exit. */
> >> +shutdown(s->udp_fd, SD_RECEIVE);
> >> +CancelIoEx((HANDLE)(SOCKET)s->udp_fd, NULL);
> >> +#else
> >>  pthread_cancel(s->circular_buffer_thread);
> >> +#endif
> >> +}
> >>  ret = pthread_join(s->circular_buffer_thread, NULL);
> >>  if (ret != 0)
> >>  av_log(h, AV_LOG_ERROR, "pthread_join(): %s\n", 
> >> strerror(ret));
> >> --
> >> 2.16.4
> >
> > This was applied as 53aa76686e7ff4f1f6625502503d7923cec8c10e, but that
> > commit fails to compile in my mingw cross-compile build.
> >
> >
> > x86_64-w64-mingw32-gcc -I. -I./ --static -DPTW32_STATIC_LIB
> > -D_WIN32_WINNT=0x0501 -I/opt/ffbuild/include -D_ISOC99_SOURCE
>
> It looks like you are still building for Windows XP, but that is no longer
> supported. _WIN32_WINNT should be at least 0x0600.

Thanks Marton.
I'll remember, Windows Vista and above only.
Thanks - I'll update my build script.


> Regards,
> Marton
>
>
> > -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -U__STRICT_ANSI__
> > -D__USE_MINGW_ANSI_STDIO=1 -D__printf__=__gnu_printf__
> > -D_WIN32_WINNT=0x0600 -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600
> > -DPIC -DOPJ_STATIC -DZLIB_CONST -DHAVE_AV_CONFIG_H -DBUILDING_avformat
> > --static -DPTW32_STATIC_LIB -D_WIN32_WINNT=0x0501
> > -I/opt/ffbuild/include  --static -DPTW32_STATIC_LIB
> > -D_WIN32_WINNT=0x0501 -std=c11 -fomit-frame-pointer -pthread
> > -I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include
> > -I/opt/ffbuild/include/openjpeg-2.3 -I/opt/ffbuild/include/opus
> > -I/opt/ffbuild/include/opus -I/opt/ffbuild/include
> > -I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include
> > -I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include
> > -I/opt/ffbuild/include -I/opt/ffbuild/include -DLIBXML_STATIC
> > -I/opt/ffbuild/include/libxml2 -I/opt/ffbuild/include -g
> > -Wdeclaration-after-statement -Wall -Wdisabled-optimization
> > -Wpointer-arith -Wredundant-decls -Wwrite-strings -Wtype-limits
> > -Wundef -Wmissing-prototypes -Wno-pointer-to-int-cast
> > -Wstrict-prototypes -Wempty-body -Wno-parentheses -Wno-switch
> > -Wno-format-zero-length -Wno-pointer-sign -Wno-char-subscripts -O3
> > -fno-math-errno -fno-signed-zeros -fno-tree-vectorize
> > -Werror=format-security -Werror=implicit-function-declaration
> > -Werror=missing-prototypes -Werror=return-type -Werror=vla -Wformat
> > -fdiagnostics-color=auto -Wno-maybe-uninitialized  -MMD -MF
> > libavformat/udp.d -MT libavformat/udp.o -c -o libavformat/udp.o
> > libavformat/udp.c
> > In file included from libavformat/udp.c:65:0:
> > /opt/ffbuild/include/pthread.h:108:0: warning: "PTW32_LEVEL" redefined
> > #define PTW32_LEVEL PTW32_LEVEL_MAX
> > ^
> > /opt/ffbuild/include/pthread.h:95:0: note: this is the location of the
> > previous definition

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: cancel pending IO on win32 manually

2020-02-03 Thread Mark Himsley
On Sun, 26 Jan 2020 at 21:22, Marton Balint  wrote:
>
> recvfrom() is not a cancellation point in pthreads-win32, see
> https://sourceware.org/pthreads-win32/manual/pthread_cancel.html
>
> In order to be able to cancel the reader thread on Win32 properly we first
> shutdown the socket then call CancelIoEx to abort pending IO. Subsequent
> recvfrom() calls will fail with WSAESHUTDOWN causing the thread to exit.
>
> Fixes ticket #5717.
>
> Signed-off-by: Marton Balint 
> ---
>  libavformat/udp.c | 11 ++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/udp.c b/libavformat/udp.c
> index 85c9e3a900..23c3773c64 100644
> --- a/libavformat/udp.c
> +++ b/libavformat/udp.c
> @@ -1069,8 +1069,17 @@ static int udp_close(URLContext *h)
>  if (s->thread_started) {
>  int ret;
>  // Cancel only read, as write has been signaled as success to the 
> user
> -if (h->flags & AVIO_FLAG_READ)
> +if (h->flags & AVIO_FLAG_READ) {
> +#ifdef _WIN32
> +/* recvfrom() is not a cancellation point for win32, so we 
> shutdown
> + * the socket and abort pending IO, subsequent recvfrom() calls
> + * will fail with WSAESHUTDOWN causing the thread to exit. */
> +shutdown(s->udp_fd, SD_RECEIVE);
> +CancelIoEx((HANDLE)(SOCKET)s->udp_fd, NULL);
> +#else
>  pthread_cancel(s->circular_buffer_thread);
> +#endif
> +}
>  ret = pthread_join(s->circular_buffer_thread, NULL);
>  if (ret != 0)
>  av_log(h, AV_LOG_ERROR, "pthread_join(): %s\n", strerror(ret));
> --
> 2.16.4

This was applied as 53aa76686e7ff4f1f6625502503d7923cec8c10e, but that
commit fails to compile in my mingw cross-compile build.


x86_64-w64-mingw32-gcc -I. -I./ --static -DPTW32_STATIC_LIB
-D_WIN32_WINNT=0x0501 -I/opt/ffbuild/include -D_ISOC99_SOURCE
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -U__STRICT_ANSI__
-D__USE_MINGW_ANSI_STDIO=1 -D__printf__=__gnu_printf__
-D_WIN32_WINNT=0x0600 -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600
-DPIC -DOPJ_STATIC -DZLIB_CONST -DHAVE_AV_CONFIG_H -DBUILDING_avformat
--static -DPTW32_STATIC_LIB -D_WIN32_WINNT=0x0501
-I/opt/ffbuild/include  --static -DPTW32_STATIC_LIB
-D_WIN32_WINNT=0x0501 -std=c11 -fomit-frame-pointer -pthread
-I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include
-I/opt/ffbuild/include/openjpeg-2.3 -I/opt/ffbuild/include/opus
-I/opt/ffbuild/include/opus -I/opt/ffbuild/include
-I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include
-I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include
-I/opt/ffbuild/include -I/opt/ffbuild/include -DLIBXML_STATIC
-I/opt/ffbuild/include/libxml2 -I/opt/ffbuild/include -g
-Wdeclaration-after-statement -Wall -Wdisabled-optimization
-Wpointer-arith -Wredundant-decls -Wwrite-strings -Wtype-limits
-Wundef -Wmissing-prototypes -Wno-pointer-to-int-cast
-Wstrict-prototypes -Wempty-body -Wno-parentheses -Wno-switch
-Wno-format-zero-length -Wno-pointer-sign -Wno-char-subscripts -O3
-fno-math-errno -fno-signed-zeros -fno-tree-vectorize
-Werror=format-security -Werror=implicit-function-declaration
-Werror=missing-prototypes -Werror=return-type -Werror=vla -Wformat
-fdiagnostics-color=auto -Wno-maybe-uninitialized  -MMD -MF
libavformat/udp.d -MT libavformat/udp.o -c -o libavformat/udp.o
libavformat/udp.c
In file included from libavformat/udp.c:65:0:
/opt/ffbuild/include/pthread.h:108:0: warning: "PTW32_LEVEL" redefined
 #define PTW32_LEVEL PTW32_LEVEL_MAX
 ^
/opt/ffbuild/include/pthread.h:95:0: note: this is the location of the
previous definition
 #define PTW32_LEVEL 1
 ^
In file included from /opt/ffbuild/include/pthread.h:299:0,
 from libavformat/udp.c:65:
/opt/ffbuild/include/sched.h:64:0: warning: "PTW32_SCHED_LEVEL" redefined
 #define PTW32_SCHED_LEVEL PTW32_SCHED_LEVEL_MAX
 ^
/opt/ffbuild/include/sched.h:51:0: note: this is the location of the
previous definition
 #define PTW32_SCHED_LEVEL 1
 ^
libavformat/udp.c: In function 'udp_close':
libavformat/udp.c:1078:13: error: implicit declaration of function
'CancelIoEx' [-Werror=implicit-function-declaration]
 CancelIoEx((HANDLE)(SOCKET)s->udp_fd, NULL);
 ^
cc1: some warnings being treated as errors
ffbuild/common.mak:59: recipe for target 'libavformat/udp.o' failed
make: *** [libavformat/udp.o] Error 1




> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".



-- 
Mark Himsley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] configure: ERROR: x265 not found using pkg-config

2017-11-13 Thread Mark Himsley
On 12 November 2017 at 20:38, Mateusz <mateu...@poczta.onet.pl> wrote:
> W dniu 12.11.2017 o 20:35, Helmut K. C. Tessarek pisze:
>> I get the following error during configure:
>>
>> ERROR: x265 not found using pkg-config
>>
>> My last compile run (3 days ago) worked perfectly. Somebody must have
>> changed the configure script.
>
> This time it is x265 bug. Please apply patch 
> https://patches.videolan.org/patch/18630/
> to x265 and recheck.

Applying the patch from https://patches.videolan.org/patch/18630/raw/
to x.265 and rebuilding/installing it does allow FFmpeg's configure to
correctly detect that libx265 is available.

-- 
Mark Himsley
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH 1/4] Correctly set Display Aspect Ratio in nvenc.

2015-01-07 Thread Mark Himsley
On 07/01/2015 18:46, Philip Langdale wrote:
 On Wed, 7 Jan 2015 12:13:25 +0100
 Nicolas George geo...@nsup.org wrote:
 
 Can you explain the 1024?

 Anyway, I would suggest to use lavu's rational functions:

 AVRational dar = av_mul_q(avctx-sample_aspect_ratio,
   av_make_q(avctx-width, avctx-height));
 av_reduce(dar.num, dar.den, dar.num, dar.den, MAX);
 nvenc_ctx-nvenc_cfg.darWidth  = 1024 * dar.num;
 nvenc_ctx-nvenc_cfg.darHeight = 1045 * dar.den;

 (including the *1.02 in the 1024 constant to avoid floating point
 operations, but I am very suspicious about that 1.02)

 Regards,

 
 Honestly, I don't understand what the encoder is doing at this point.
 The 1.02 seems to be the 'correct' scale factor for a PAL DVD,

http://web.archive.org/web/20100826080627/www.bbc.co.uk/commissioning/tvbranding/picturesize.shtml

says 1.094


 but is
 incorrect for anything else. I used 1024 to avoid the floating point
 problem, but you are right that pre-multiplication is a better way to
 handle that. Right now I'm playing around with an NTSC DVD and I can't
 find the right magic to stop it mangling the aspect ratio.

Where 'PAL' (I use the term loosely to imply 25 702x576 interlaced
pictures in a 720x576 frame) is:

768x576 active square pixels in a 788x576 square pixel frame for 4:3
 or
1024x576 active square pixels in a 1050x576 square pixel frame for 16:9

for the full frame 'NTSC' (loosely 3/1001 710.85x486 interlaced
pictures in a 720x486 frame) is approximately:

648x486 active square pixels in a 656.34x486 square pixel frame for 4:3
 or
864x486 active square pixels in a 875.12x486 square pixel frame for 16:9

Although, I'm not sure that information is going to help you :-(

 At this point, I'm not convinced that darWidth and darHeight are even
 representing the display presentation size at all. Hopefully Agatha can
 understand what's going on here.
 
 --phil
 ___
 ffmpeg-devel mailing list
 ffmpeg-devel@ffmpeg.org
 http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel