Re: [FFmpeg-devel] [PATCH 137/217] avcodec/cpia: Mark decoder as init-threadsafe
> libavcodec/cpia.c | 1 + > 1 file changed, 1 insertion(+) lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: log skipped initial non-keyframes
> Repeated messages only get supressed if there is no interspaced > message if 2 things generate a message per frame, neither will be > supressed So should I leave it at DEBUG level or implement a custom log_once? The "cur_dts invalid" debug message is currently being printed at least as often. pgpL6PwoEG_8q.pgp Description: OpenPGP digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: log skipped initial non-keyframes
>> -!ost->copy_initial_nonkeyframes)
>> +!ost->copy_initial_nonkeyframes) {
>> +av_log(NULL, AV_LOG_DEBUG, "skipping initial
>> non-keyframe\n"); return;
>
> Incorrect indentation.
It's actually the same indentation as in other places in the same file,
what would be the correct way then?
> I suggest this message should be at INFO level, but appear only once.
I'm fine with INFO level. Repeated messages get supressed anyways, does
that suffice?
> I believe ffprobe also suffers from such files and never displays
> anyhing with -show_frames. In fact, does ffprobe perhaps always begin
> from, or at least wait for, the first keyframe?
Cannot really comment on that. For me it happens when stream copying
from v4l2, since the keyframe flag is not being set there, Probing
works just fine.
pgpeXjj2FFihR.pgp
Description: OpenPGP digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH 1/2] avformat/nut: add cpia codec
> please send a patch to docs/nut4cc.txt first. > (https://git.ffmpeg.org/nut.git or svn://svn.mplayerhq.hu/nut) sent the patch (mail is awaiting moderation) pgpHCCCp43tLk.pgp Description: OpenPGP digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] CPIA
>> I have the file ready, how can I provide it? > > how big is it ? 1.2M, I did 10 frames to get some non-keyframes too. > can it be used for a fate test ? sure > but generally upload it somewhere and provide a link the nut file is now available from ipfs: https://ipfs.io/ipfs/QmUcW1DRJoktT2ZGF4jKfyBRRaUsab8k2Lz5Hct7Nkv6WW pgpOiozbHuZB2.pgp Description: OpenPGP digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] CPIA
Michael Niedermayer wrote on 27.05.2019 at 00:22: > [...] maybe just add teh codec id to nut and try to store it in that > with stream copy if it works it should be possible to playback that > nit file I have the file ready, how can I provide it? pgp12neptaV1q.pgp Description: OpenPGP digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: log skipped initial non-keyframes
If `AV_PKT_FLAG_KEY` stays unset on `pkt->flags`, the output stream
stays empty with little information about what is going on.
This change makes it easier to debug the situation for the user who
could then choose to use the `-copyinkf` option.
---
fftools/ffmpeg.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 01f04103cf..446439e285 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -2006,8 +2006,10 @@ static void do_streamcopy(InputStream *ist, OutputStream
*ost, const AVPacket *p
}
if ((!ost->frame_number && !(pkt->flags & AV_PKT_FLAG_KEY)) &&
-!ost->copy_initial_nonkeyframes)
+!ost->copy_initial_nonkeyframes) {
+av_log(NULL, AV_LOG_DEBUG, "skipping initial non-keyframe\n");
return;
+}
if (!ost->frame_number && !ost->copy_prior_start) {
int64_t comp_start = start_time;
--
2.21.0
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH 1/2] avformat/nut: add cpia codec
---
libavformat/nut.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/nut.c b/libavformat/nut.c
index 4fbbcb1d26..937f452878 100644
--- a/libavformat/nut.c
+++ b/libavformat/nut.c
@@ -43,6 +43,7 @@ const AVCodecTag ff_nut_video_tags[] = {
{ AV_CODEC_ID_XFACE,MKTAG('X', 'F', 'A', 'C') },
{ AV_CODEC_ID_VP9, MKTAG('V', 'P', '9', '0') },
{ AV_CODEC_ID_HEVC, MKTAG('H', 'E', 'V', 'C') },
+{ AV_CODEC_ID_CPIA, MKTAG('C', 'P', 'i', 'A') },
{ AV_CODEC_ID_RAWVIDEO, MKTAG('R', 'G', 'B', 15 ) },
{ AV_CODEC_ID_RAWVIDEO, MKTAG('B', 'G', 'R', 15 ) },
{ AV_CODEC_ID_RAWVIDEO, MKTAG('R', 'G', 'B', 16 ) },
--
2.21.0
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] CPIA
Michael Niedermayer wrote on 27.05.2019 at 00:22: > ideally some seperation between frames would be kept > for example each frame in its own file might be the easiest > or maybe just add teh codec id to nut and try to store it in that > with stream copy Added the codec id but getting invalid `cur_dts` when trying to stream copy from v4l2 to nut. Will try to look into this sometime. pgptn3S5agVu8.pgp Description: OpenPGP digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] CPIA
> Can someone who has the right hardware for CPIA, dump some frames into > a file so people and myself can test this without special hw. Would dd'ing /dev/video0 be enough and how can I provide the file? Ftp `upload.ffmpeg.org` seems down. pgpkF1LLjC_Z2.pgp Description: OpenPGP digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] lavd/v4l2: Return FFERROR_REDO when receiving a frame of unexpected size
Alexander Strasser wrote on 21.03.2019 at 23:34:
> 3. Return zero-sized packets => This works and is consistent with how
>we handle frames flagged to be corrupted (V4L2_BUF_FLAG_ERROR).
>See commit 28f20d2ff487aa589643d8f70eaf614b78839685 .
I posted a patch for this on Sat, 25 Aug 2018. It seems to have been
forgotten, attached again.
From 0af8515acca4d598570d03450656adc0ed7ac2d7 Mon Sep 17 00:00:00 2001
From: Stephan Hilb
Date: Sun, 10 Jun 2018 21:07:52 +0200
Subject: [PATCH] lavd/v4l2: skip buffers not matching frame_size
By adopting the same behaviour as if there was corrupted data in the
buffer (see the check for V4L2_BUF_FLAG_ERROR) the resulting rawvideo
now at least contains valid data (the previous frame being duplicated).
Fixes video capturing for some stk1160 devices.
---
libavdevice/v4l2.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c
index 10a0ff0dd6..ab903bbcee 100644
--- a/libavdevice/v4l2.c
+++ b/libavdevice/v4l2.c
@@ -534,11 +534,10 @@ static int mmap_read_frame(AVFormatContext *ctx, AVPacket *pkt)
s->frame_size = buf.bytesused;
if (s->frame_size > 0 && buf.bytesused != s->frame_size) {
-av_log(ctx, AV_LOG_ERROR,
+av_log(ctx, AV_LOG_WARNING,
"Dequeued v4l2 buffer contains %d bytes, but %d were expected. Flags: 0x%08X.\n",
buf.bytesused, s->frame_size, buf.flags);
-enqueue_buffer(s, );
-return AVERROR_INVALIDDATA;
+buf.bytesused = 0;
}
}
--
2.18.0
pgpNOj7I3nYx7.pgp
Description: OpenPGP digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] lavd/v4l2: skip buffers not matching frame_size
> libavdevice/v4l2.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Any comments on this? pgp6DLors_XHR.pgp Description: OpenPGP digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH] lavd/v4l2: skip buffers not matching frame_size
By adopting the same behaviour as if there was corrupted data in the
buffer (see the check for V4L2_BUF_FLAG_ERROR) the resulting rawvideo
now at least contains valid data (the previous frame being duplicated).
Fixes video capturing for some stk1160 devices.
---
libavdevice/v4l2.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c
index 10a0ff0dd6..ab903bbcee 100644
--- a/libavdevice/v4l2.c
+++ b/libavdevice/v4l2.c
@@ -534,11 +534,10 @@ static int mmap_read_frame(AVFormatContext *ctx, AVPacket
*pkt)
s->frame_size = buf.bytesused;
if (s->frame_size > 0 && buf.bytesused != s->frame_size) {
-av_log(ctx, AV_LOG_ERROR,
+av_log(ctx, AV_LOG_WARNING,
"Dequeued v4l2 buffer contains %d bytes, but %d were
expected. Flags: 0x%08X.\n",
buf.bytesused, s->frame_size, buf.flags);
-enqueue_buffer(s, );
-return AVERROR_INVALIDDATA;
+buf.bytesused = 0;
}
}
--
2.18.0
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
