Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/hlsenc: replace with av_dirname to get the directory

2019-10-08 Thread Limin Wang
On Tue, Oct 08, 2019 at 02:47:57PM +0200, Michael Niedermayer wrote:
> On Tue, Oct 08, 2019 at 06:24:22AM +, Limin Wang wrote:
> > ffmpeg | branch: master | Limin Wang  | Tue Sep 24 
> > 19:24:00 2019 +0800| [28bb73cee77e209a6445d081e7ea577ede29c50f] | 
> > committer: Steven Liu
> > 
> > avformat/hlsenc: replace with av_dirname to get the directory
> > 
> > Signed-off-by: Limin Wang 
> > 
> > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=28bb73cee77e209a6445d081e7ea577ede29c50f
> > ---
> > 
> >  libavformat/hlsenc.c | 22 ++
> >  1 file changed, 6 insertions(+), 16 deletions(-)
> 
> This breaks
> ./ffmpeg -i mm-small.mpg -f hls -hls_list_size 5 -hls_flags +delete_segments  
> -acodec mp2 -vcodec mpeg2video  -ab 128k -hls_base_url delseg  
> /tmp/file-hlsdelseg.m3u8
> ...
> [hls muxer @ 0x2be16c0] failed to delete old segment /tmpfile-hlsdelseg0.ts: 
> No such file or directory
> 
> using /tmp//file-hlsdelseg.m3u8 makes it work but that doesnt feel correct

Michael, I have submit a patch to fix the issue, please check it. The
old dirname have included with extra "/" in the string end, sorry I haven't
notice that. I have tested with your command.

> 
> thx
> 
> [...]
> -- 
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> "I am not trying to be anyone's saviour, I'm trying to think about the
>  future and not be sad" - Elon Musk
> 



> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/hlsenc: replace with av_dirname to get the directory

2019-10-08 Thread Limin Wang
On Tue, Oct 08, 2019 at 02:47:57PM +0200, Michael Niedermayer wrote:
> On Tue, Oct 08, 2019 at 06:24:22AM +, Limin Wang wrote:
> > ffmpeg | branch: master | Limin Wang  | Tue Sep 24 
> > 19:24:00 2019 +0800| [28bb73cee77e209a6445d081e7ea577ede29c50f] | 
> > committer: Steven Liu
> > 
> > avformat/hlsenc: replace with av_dirname to get the directory
> > 
> > Signed-off-by: Limin Wang 
> > 
> > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=28bb73cee77e209a6445d081e7ea577ede29c50f
> > ---
> > 
> >  libavformat/hlsenc.c | 22 ++
> >  1 file changed, 6 insertions(+), 16 deletions(-)
> 
> This breaks
> ./ffmpeg -i mm-small.mpg -f hls -hls_list_size 5 -hls_flags +delete_segments  
> -acodec mp2 -vcodec mpeg2video  -ab 128k -hls_base_url delseg  
> /tmp/file-hlsdelseg.m3u8
> ...
> [hls muxer @ 0x2be16c0] failed to delete old segment /tmpfile-hlsdelseg0.ts: 
> No such file or directory

OK, I'll check it and fix it.

> 
> using /tmp//file-hlsdelseg.m3u8 makes it work but that doesnt feel correct
> 
> thx
> 
> [...]
> -- 
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> "I am not trying to be anyone's saviour, I'm trying to think about the
>  future and not be sad" - Elon Musk
> 



> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/hlsenc: replace with av_dirname to get the directory

2019-10-08 Thread Michael Niedermayer
On Tue, Oct 08, 2019 at 06:24:22AM +, Limin Wang wrote:
> ffmpeg | branch: master | Limin Wang  | Tue Sep 24 
> 19:24:00 2019 +0800| [28bb73cee77e209a6445d081e7ea577ede29c50f] | committer: 
> Steven Liu
> 
> avformat/hlsenc: replace with av_dirname to get the directory
> 
> Signed-off-by: Limin Wang 
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=28bb73cee77e209a6445d081e7ea577ede29c50f
> ---
> 
>  libavformat/hlsenc.c | 22 ++
>  1 file changed, 6 insertions(+), 16 deletions(-)

This breaks
./ffmpeg -i mm-small.mpg -f hls -hls_list_size 5 -hls_flags +delete_segments  
-acodec mp2 -vcodec mpeg2video  -ab 128k -hls_base_url delseg  
/tmp/file-hlsdelseg.m3u8
...
[hls muxer @ 0x2be16c0] failed to delete old segment /tmpfile-hlsdelseg0.ts: No 
such file or directory

using /tmp//file-hlsdelseg.m3u8 makes it work but that doesnt feel correct

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

"I am not trying to be anyone's saviour, I'm trying to think about the
 future and not be sad" - Elon Musk



signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".