Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

[Thomas Volkert]

On 24.04.2019 12:20, Timo Rothenpieler wrote:
> On 24/04/2019 01:38, Carl Eugen Hoyos wrote:
>> 2017-12-29 13:16 GMT+01:00, Cyber Sinh :
>>> Sorry for the diff instead of regular git patch. Here is the patch.
>>
>> Only saw this today after wondering
>> why nobody tried using wsl before...
>
> I'm using WSL since a while, but never bothered trying to setup MSVC
> with it.

I'm also using WSL, but I don't use MSVC to compile FFmpeg, instead I
use mingw-w64. But this isn't a show stopper to have support for NVidia
CUDA, IntelQSV, AMD, libSRT, libmp3lame, openH264 or other features
under Windows.

Best regards,
Thomas.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

[Timo Rothenpieler]

On 24/04/2019 01:38, Carl Eugen Hoyos wrote:

2017-12-29 13:16 GMT+01:00, Cyber Sinh :

Sorry for the diff instead of regular git patch. Here is the patch.


Only saw this today after wondering
why nobody tried using wsl before...


I'm using WSL since a while, but never bothered trying to setup MSVC 
with it.




smime.p7s
Description: S/MIME Cryptographic Signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

[Carl Eugen Hoyos]

2017-12-29 13:16 GMT+01:00, Cyber Sinh :
> Sorry for the diff instead of regular git patch. Here is the patch.

Only saw this today after wondering
why nobody tried using wsl before...

How can I test this part of the patch?
In which situation is it supposed to make a difference?

diff --git a/compat/windows/mslink b/compat/windows/mslink
index 07b2b3e378..9b6b83c4ed 100755
--- a/compat/windows/mslink
+++ b/compat/windows/mslink
@@ -1,9 +1,9 @@
 #!/bin/sh

-LINK_EXE_PATH=$(dirname "$(command -v cl)")/link
+LINK_EXE_PATH=$(dirname "$(command -v cl.exe)")/link.exe
 if [ -x "$LINK_EXE_PATH" ]; then
 "$LINK_EXE_PATH" $@
 else


I will apply the makedef part that I just tested successfully.

Carl Eugen


>
>
> -Message d'origine-
> De : ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] De la part de
> wm4
> Envoyé : vendredi 29 décembre 2017 12:54
> À : ffmpeg-devel@ffmpeg.org
> Objet : Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg
> with Linux bash on Windows (WSL)
>
> On Fri, 29 Dec 2017 10:44:21 +0100
> Hendrik Leppkes  wrote:
>
>> On Fri, Dec 29, 2017 at 3:43 AM, Cyber Sinh  wrote:
>> > The attached patch changes the configure script for FFmpeg (and
>> > associated shell scripts) to call MSVC tools including their
>> > extensions (cl.exe instead of cl for example). This is necessary,
>> > because WSL can automatically launch Windows processes from the
>> > Linux side but only if the process is in the path and includes the
>> > full name. Linux doesn't automatically append .exe and such to invoke a
>> > file.
>> >
>> >
>>
>> The attached file is corrupted. Please ensure its in git format-patch
>> format. As it is, I can't even read it at all.
>
> It's in UTF-16, and just a diff. Yeah, nobody can comfortably read it.
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

[Josh de Kock]

On Fri, 29 Dec 2017 12:41:07 +0100
"Cyber Sinh"  wrote:

> Hi Aaron,
> 
> - I were not aware of the Gilles Khouzam patch when I make the patch (I read 
> its useful blog post). But feel free to give credits to anyone you want. 
> Adding ".exe" to the end of Windows executables is not rocket science, as you 
> said.
> [...]

I've been working on a patch to do this and fixup testing FATE with mingw cross 
compilation within WSL. I was planning on submitting it within the next few 
days. 

-- 
Josh de Kock 
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

[Cyber Sinh]

Sorry for the diff instead of regular git patch. Here is the patch.


-Message d'origine-
De : ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] De la part de wm4
Envoyé : vendredi 29 décembre 2017 12:54
À : ffmpeg-devel@ffmpeg.org
Objet : Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with 
Linux bash on Windows (WSL)

On Fri, 29 Dec 2017 10:44:21 +0100
Hendrik Leppkes <h.lepp...@gmail.com> wrote:

> On Fri, Dec 29, 2017 at 3:43 AM, Cyber Sinh <cyber.s...@free.fr> wrote:
> > The attached patch changes the configure script for FFmpeg (and 
> > associated shell scripts) to call MSVC tools including their 
> > extensions (cl.exe instead of cl for example). This is necessary, 
> > because WSL can automatically launch Windows processes from the 
> > Linux side but only if the process is in the path and includes the 
> > full name. Linux doesn't automatically append .exe and such to invoke a 
> > file.
> >
> >  
> 
> The attached file is corrupted. Please ensure its in git format-patch 
> format. As it is, I can't even read it at all.

It's in UTF-16, and just a diff. Yeah, nobody can comfortably read it.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


0001-Allow-MSVC-building-under-WSL-Linux-bash-on-Windows-.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

[wm4]

On Fri, 29 Dec 2017 10:44:21 +0100
Hendrik Leppkes  wrote:

> On Fri, Dec 29, 2017 at 3:43 AM, Cyber Sinh  wrote:
> > The attached patch changes the configure script for FFmpeg (and associated
> > shell scripts) to call MSVC tools including their extensions (cl.exe instead
> > of cl for example). This is necessary, because WSL can automatically launch
> > Windows processes from the Linux side but only if the process is in the path
> > and includes the full name. Linux doesn't automatically append .exe and such
> > to invoke a file.
> >
> >  
> 
> The attached file is corrupted. Please ensure its in git format-patch
> format. As it is, I can't even read it at all.

It's in UTF-16, and just a diff. Yeah, nobody can comfortably read it.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

[Cyber Sinh]

Hi Aaron,

- I were not aware of the Gilles Khouzam patch when I make the patch (I read 
its useful blog post). But feel free to give credits to anyone you want. Adding 
".exe" to the end of Windows executables is not rocket science, as you said.
- My patch is sufficient to build FFmpeg on bash on Windows. At least on my 
machine with the current master. The Gilles patch was used for compiling the 
FFmpegInterop project and was post for one year.
- Performance is not the sole benefit of using bash on Windows. We don't have 
to install/use msys2 which is a pain for Windows user. 

Sylvain Rougeaux

-Message d'origine-
De : ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] De la part de Aaron 
Levinson
Envoyé : vendredi 29 décembre 2017 04:12
À : FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Objet : Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with 
Linux bash on Windows (WSL)

On 12/28/2017 6:43 PM, Cyber Sinh wrote:
> The attached patch changes the configure script for FFmpeg (and 
> associated shell scripts) to call MSVC tools including their 
> extensions (cl.exe instead of cl for example). This is necessary, 
> because WSL can automatically launch Windows processes from the Linux 
> side but only if the process is in the path and includes the full 
> name. Linux doesn't automatically append .exe and such to invoke a file.

I haven't confirmed yet that this works in the msys2 environment on Windows, 
although according to 
https://blogs.msdn.microsoft.com/gillesk/2016/12/02/building-ffmpeg-using-wsl/
, it supposedly shouldn't cause any issues with building under msys2 or WSL.

It appears all of the contents of this patch have been taken from another 
patch, available at 
https://github.com/Microsoft/FFmpegInterop/blob/gillesk/wsl/0001-Updating-scripts-to-run-under-WSL.patch
, although its reasonable that the author of this patch would have come up with 
it on their own since it is so simple.  It would be reasonable to give credit 
to Gilles Khouzam in the patch description, if the author of this patch (Cyber 
Sinh) and Gilles Khouzam are not the same individual.

Also, Gilles's patch does more to get FFmpeg to build properly under WSL, so 
just adding the file extension may not be sufficient to get FFmpeg to build 
under WSL.

On a separate note, building under WSL, as opposed to msys2, seems promising if 
only from a build performance perspective.  According to the blog post, it 
builds at least twice as fast under WSL than it does with msys2.

Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

[Hendrik Leppkes]

On Fri, Dec 29, 2017 at 3:43 AM, Cyber Sinh  wrote:
> The attached patch changes the configure script for FFmpeg (and associated
> shell scripts) to call MSVC tools including their extensions (cl.exe instead
> of cl for example). This is necessary, because WSL can automatically launch
> Windows processes from the Linux side but only if the process is in the path
> and includes the full name. Linux doesn't automatically append .exe and such
> to invoke a file.
>
>

The attached file is corrupted. Please ensure its in git format-patch
format. As it is, I can't even read it at all.

- Hendrik
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

[Aaron Levinson]

On 12/28/2017 6:43 PM, Cyber Sinh wrote:

The attached patch changes the configure script for FFmpeg (and associated
shell scripts) to call MSVC tools including their extensions (cl.exe instead
of cl for example). This is necessary, because WSL can automatically launch
Windows processes from the Linux side but only if the process is in the path
and includes the full name. Linux doesn't automatically append .exe and such
to invoke a file.


I haven't confirmed yet that this works in the msys2 environment on 
Windows, although according to 
https://blogs.msdn.microsoft.com/gillesk/2016/12/02/building-ffmpeg-using-wsl/ 
, it supposedly shouldn't cause any issues with building under msys2 or WSL.


It appears all of the contents of this patch have been taken from 
another patch, available at 
https://github.com/Microsoft/FFmpegInterop/blob/gillesk/wsl/0001-Updating-scripts-to-run-under-WSL.patch 
, although its reasonable that the author of this patch would have come 
up with it on their own since it is so simple.  It would be reasonable 
to give credit to Gilles Khouzam in the patch description, if the author 
of this patch (Cyber Sinh) and Gilles Khouzam are not the same individual.


Also, Gilles's patch does more to get FFmpeg to build properly under 
WSL, so just adding the file extension may not be sufficient to get 
FFmpeg to build under WSL.


On a separate note, building under WSL, as opposed to msys2, seems 
promising if only from a build performance perspective.  According to 
the blog post, it builds at least twice as fast under WSL than it does 
with msys2.


Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

[Cyber Sinh]

The attached patch changes the configure script for FFmpeg (and associated
shell scripts) to call MSVC tools including their extensions (cl.exe instead
of cl for example). This is necessary, because WSL can automatically launch
Windows processes from the Linux side but only if the process is in the path
and includes the full name. Linux doesn't automatically append .exe and such
to invoke a file.



build_with_wsl.diff
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel