Re: [FFmpeg-devel] [PATCH] GnuTLS: eat PREMATURE_TERMINATION error

2017-09-20 Thread Michael Niedermayer 
On Tue, Sep 19, 2017 at 09:14:58PM +0200, wm4 wrote:
> On Fri, 15 Sep 2017 17:04:38 +0900
> Tatsuyuki Ishi  wrote:
> 
> > Subject: [PATCH] GnuTLS: eat PREMATURE_TERMINATION error
> > 
> > GnuTLS is too strict on the SSL shutdown alert, and it's neither
> > mandatory in the spec or critical. As it's ignored in OpenSSL, we
> > should also suppress it in GnuTLS as well.
> > 
> > Ticket: #6667
> > 
> > ---
> >  libavformat/tls_gnutls.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/libavformat/tls_gnutls.c b/libavformat/tls_gnutls.c
> > index ecc80bf..38f8ea4 100644
> > --- a/libavformat/tls_gnutls.c
> > +++ b/libavformat/tls_gnutls.c
> > @@ -72,6 +72,7 @@ static int print_tls_error(URLContext *h, int ret)
> >  switch (ret) {
> >  case GNUTLS_E_AGAIN:
> >  case GNUTLS_E_INTERRUPTED:
> > +case GNUTLS_E_PREMATURE_TERMINATION:
> >  break;
> >  case GNUTLS_E_WARNING_ALERT_RECEIVED:
> >  av_log(h, AV_LOG_WARNING, "%s\n", gnutls_strerror(ret));
> 
> I also agree with this patch.

will apply after some basic testing

thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] GnuTLS: eat PREMATURE_TERMINATION error

2017-09-19 Thread wm4 
On Fri, 15 Sep 2017 17:04:38 +0900
Tatsuyuki Ishi  wrote:

> Subject: [PATCH] GnuTLS: eat PREMATURE_TERMINATION error
> 
> GnuTLS is too strict on the SSL shutdown alert, and it's neither
> mandatory in the spec or critical. As it's ignored in OpenSSL, we
> should also suppress it in GnuTLS as well.
> 
> Ticket: #6667
> 
> ---
>  libavformat/tls_gnutls.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavformat/tls_gnutls.c b/libavformat/tls_gnutls.c
> index ecc80bf..38f8ea4 100644
> --- a/libavformat/tls_gnutls.c
> +++ b/libavformat/tls_gnutls.c
> @@ -72,6 +72,7 @@ static int print_tls_error(URLContext *h, int ret)
>  switch (ret) {
>  case GNUTLS_E_AGAIN:
>  case GNUTLS_E_INTERRUPTED:
> +case GNUTLS_E_PREMATURE_TERMINATION:
>  break;
>  case GNUTLS_E_WARNING_ALERT_RECEIVED:
>  av_log(h, AV_LOG_WARNING, "%s\n", gnutls_strerror(ret));

I also agree with this patch.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] GnuTLS: eat PREMATURE_TERMINATION error

2017-09-15 Thread Jan Ekstrom 
Hi,

On Fri, Sep 15, 2017 at 11:04 AM, Tatsuyuki Ishi
 wrote:
> Subject: [PATCH] GnuTLS: eat PREMATURE_TERMINATION error
>
> GnuTLS is too strict on the SSL shutdown alert, and it's neither
> mandatory in the spec or critical. As it's ignored in OpenSSL, we
> should also suppress it in GnuTLS as well.
>

If anyone wants to test this, Youtube is a good example of this
message getting spammed. If we ignore this with OpenSSL as well, then
I totally agree with this change.


Jan
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] GnuTLS: eat PREMATURE_TERMINATION error

2017-09-15 Thread Tatsuyuki Ishi 
Subject: [PATCH] GnuTLS: eat PREMATURE_TERMINATION error

GnuTLS is too strict on the SSL shutdown alert, and it's neither
mandatory in the spec or critical. As it's ignored in OpenSSL, we
should also suppress it in GnuTLS as well.

Ticket: #6667

---
 libavformat/tls_gnutls.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavformat/tls_gnutls.c b/libavformat/tls_gnutls.c
index ecc80bf..38f8ea4 100644
--- a/libavformat/tls_gnutls.c
+++ b/libavformat/tls_gnutls.c
@@ -72,6 +72,7 @@ static int print_tls_error(URLContext *h, int ret)
 switch (ret) {
 case GNUTLS_E_AGAIN:
 case GNUTLS_E_INTERRUPTED:
+case GNUTLS_E_PREMATURE_TERMINATION:
 break;
 case GNUTLS_E_WARNING_ALERT_RECEIVED:
 av_log(h, AV_LOG_WARNING, "%s\n", gnutls_strerror(ret));
-- 
2.14.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel