Re: [FFmpeg-devel] [PATCH] Makefile: delete unneeded escape

2019-02-17 Thread Reto Kromer
Michael Niedermayer wrote:

>if someone adds a line after this he would have to change the
>previous line (adding the \ back) 
>that would make such a patch less tidy (2 lines changed instead
>of 1)
>i suspect that was the reason why all lines have a \

Possibly. The two other similar instances are handled
differently. Anyway, sorry for the noise! And best regards, Reto

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] Makefile: delete unneeded escape

2019-02-17 Thread Michael Niedermayer
On Sun, Feb 17, 2019 at 09:44:52AM +0100, Reto Kromer wrote:
> Best regards, Reto

>  Makefile |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> ed5a95e331e302563d0859bd3b514d88376696e6  
> 0001-Makefile-delete-unneeded-escape.patch
> From 764d9459caecc259952984258ae19ed0906c1176 Mon Sep 17 00:00:00 2001
> From: Reto Kromer 
> Date: Sun, 17 Feb 2019 09:40:01 +0100
> Subject: [PATCH] Makefile: delete unneeded escape
> 
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 59b26c65c9..08b3cfa9b1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -59,7 +59,7 @@ CONFIGURABLE_COMPONENTS =   
> \
>  $(wildcard $(FFLIBS:%=$(SRC_PATH)/lib%/all*.c)) \
>  $(SRC_PATH)/libavcodec/bitstream_filters.c  \
>  $(SRC_PATH)/libavcodec/parsers.c\
> -$(SRC_PATH)/libavformat/protocols.c \
> +$(SRC_PATH)/libavformat/protocols.c
>  

if someone adds a line after this he would have to change the previous line
(adding the \ back) 
that would make such a patch less tidy (2 lines changed instead of 1)
i suspect that was the reason why all lines have a \


[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


[FFmpeg-devel] [PATCH] Makefile: delete unneeded escape

2019-02-17 Thread Reto Kromer
Best regards, Reto

0001-Makefile-delete-unneeded-escape.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel