Re: [FFmpeg-devel] [PATCH] avcodec/truemotion2: Fix integer overflow in tm2_null_res_block()

2019-03-25 Thread Michael Niedermayer 
On Sat, Mar 16, 2019 at 09:39:10AM +0100, Michael Niedermayer wrote:
> Fixes: signed integer overflow: 638592 - -2122219136 cannot be 
> represented in type 'int'
> Fixes: 
> 13441/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-5732769815068672
> 
> Found-by: continuous fuzzing process 
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer 
> ---
>  libavcodec/truemotion2.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

will apply

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"- "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avcodec/truemotion2: Fix integer overflow in tm2_null_res_block()

2019-03-16 Thread Michael Niedermayer 
Fixes: signed integer overflow: 638592 - -2122219136 cannot be represented 
in type 'int'
Fixes: 
13441/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-5732769815068672

Found-by: continuous fuzzing process 
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer 
---
 libavcodec/truemotion2.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavcodec/truemotion2.c b/libavcodec/truemotion2.c
index 4d27f0cbfc..18719dae1c 100644
--- a/libavcodec/truemotion2.c
+++ b/libavcodec/truemotion2.c
@@ -600,7 +600,8 @@ static inline void tm2_null_res_block(TM2Context *ctx, 
AVFrame *pic, int bx, int
 {
 int i;
 int ct;
-int left, right, diff;
+unsigned left, right;
+int diff;
 int deltas[16];
 TM2_INIT_POINTERS();
 
-- 
2.21.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel