Re: [FFmpeg-devel] [PATCH] avcodec: remove unused avpriv_ac3_parse_header

2015-10-20 Thread Andreas Cadhalpun 
On 14.10.2015 01:53, James Almer wrote:
> On 10/13/2015 8:50 PM, Andreas Cadhalpun wrote:
>> It was replaced by avpriv_ac3_parse_header2.
> 
> You could rename it to avpriv_ac3_parse_header() while at it.
> The 2 suffix becomes silly with this.

I'll send a separate patch for that.

Best regards,
Andreas

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec: remove unused avpriv_ac3_parse_header

2015-10-20 Thread Andreas Cadhalpun 
On 14.10.2015 02:07, Michael Niedermayer wrote:
> On Wed, Oct 14, 2015 at 01:50:13AM +0200, Andreas Cadhalpun wrote:
>> It was replaced by avpriv_ac3_parse_header2.
>>
>> Signed-off-by: Andreas Cadhalpun 
>> ---
>>  libavcodec/ac3_parser.c | 9 -
>>  libavcodec/ac3_parser.h | 2 --
>>  2 files changed, 11 deletions(-)
> 
> should be ok

Pushed.

Best regards,
Andreas

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avcodec: remove unused avpriv_ac3_parse_header

2015-10-13 Thread Andreas Cadhalpun 
It was replaced by avpriv_ac3_parse_header2.

Signed-off-by: Andreas Cadhalpun 
---
 libavcodec/ac3_parser.c | 9 -
 libavcodec/ac3_parser.h | 2 --
 2 files changed, 11 deletions(-)

diff --git a/libavcodec/ac3_parser.c b/libavcodec/ac3_parser.c
index 5ab5627..0dd98b9 100644
--- a/libavcodec/ac3_parser.c
+++ b/libavcodec/ac3_parser.c
@@ -151,15 +151,6 @@ int avpriv_ac3_parse_header2(GetBitContext *gbc, 
AC3HeaderInfo **phdr)
 return 0;
 }
 
-int avpriv_ac3_parse_header(GetBitContext *gbc, AC3HeaderInfo *hdr)
-{
-AC3HeaderInfo tmp, *ptmp = 
-int ret = avpriv_ac3_parse_header2(gbc, );
-
-memcpy(hdr, ptmp, ((intptr_t)_layout) - ((intptr_t)) + 
sizeof(uint64_t));
-return ret;
-}
-
 static int ac3_sync(uint64_t state, AACAC3ParseContext *hdr_info,
 int *need_next_header, int *new_frame_start)
 {
diff --git a/libavcodec/ac3_parser.h b/libavcodec/ac3_parser.h
index f37387d..80bc5ef 100644
--- a/libavcodec/ac3_parser.h
+++ b/libavcodec/ac3_parser.h
@@ -39,6 +39,4 @@
  */
 int avpriv_ac3_parse_header2(GetBitContext *gbc, AC3HeaderInfo **hdr);
 
-int avpriv_ac3_parse_header(GetBitContext *gbc, AC3HeaderInfo *hdr);
-
 #endif /* AVCODEC_AC3_PARSER_H */
-- 
2.6.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel