Re: [FFmpeg-devel] [PATCH] avfilter/avfiltergraph: pass correct audio/video flags

[Nicolas George]

Le nonidi 29 brumaire, an CCXXVI, Paul B Mahol a écrit :
> Signed-off-by: Paul B Mahol 
> ---
>  libavfilter/avfiltergraph.c | 14 --
>  1 file changed, 8 insertions(+), 6 deletions(-)

LGTM. Maybe add in the commit message the real reason for the change
(a flag that was previously ignored?).

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avfilter/avfiltergraph: pass correct audio/video flags

[Paul B Mahol]

Signed-off-by: Paul B Mahol 
---
 libavfilter/avfiltergraph.c | 14 --
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c
index a009e0a760..a959a9ef3f 100644
--- a/libavfilter/avfiltergraph.c
+++ b/libavfilter/avfiltergraph.c
@@ -43,17 +43,19 @@
 #include "thread.h"
 
 #define OFFSET(x) offsetof(AVFilterGraph, x)
-#define FLAGS AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_FILTERING_PARAM
+#define F AV_OPT_FLAG_FILTERING_PARAM
+#define V AV_OPT_FLAG_VIDEO_PARAM
+#define A AV_OPT_FLAG_AUDIO_PARAM
 static const AVOption filtergraph_options[] = {
 { "thread_type", "Allowed thread types", OFFSET(thread_type), 
AV_OPT_TYPE_FLAGS,
-{ .i64 = AVFILTER_THREAD_SLICE }, 0, INT_MAX, FLAGS, "thread_type" },
-{ "slice", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = AVFILTER_THREAD_SLICE 
}, .flags = FLAGS, .unit = "thread_type" },
+{ .i64 = AVFILTER_THREAD_SLICE }, 0, INT_MAX, F|V|A, "thread_type" },
+{ "slice", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = AVFILTER_THREAD_SLICE 
}, .flags = F|V|A, .unit = "thread_type" },
 { "threads", "Maximum number of threads", OFFSET(nb_threads),
-AV_OPT_TYPE_INT,   { .i64 = 0 }, 0, INT_MAX, FLAGS },
+AV_OPT_TYPE_INT,   { .i64 = 0 }, 0, INT_MAX, F|V|A },
 {"scale_sws_opts"   , "default scale filter options", 
OFFSET(scale_sws_opts),
-AV_OPT_TYPE_STRING, {.str = NULL}, 0, 0, FLAGS },
+AV_OPT_TYPE_STRING, {.str = NULL}, 0, 0, F|V },
 {"aresample_swr_opts"   , "default aresample filter options", 
OFFSET(aresample_swr_opts),
-AV_OPT_TYPE_STRING, {.str = NULL}, 0, 0, FLAGS },
+AV_OPT_TYPE_STRING, {.str = NULL}, 0, 0, F|A },
 { NULL },
 };
 
-- 
2.11.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel