Re: [FFmpeg-devel] [PATCH] avfilter/vf_interlace: fix numerical options
Am Do., 30. Aug. 2018 um 10:37 Uhr schrieb Thomas Mundt : > Am Mo., 27. Aug. 2018 um 20:40 Uhr schrieb Thomas Mundt < > tmund...@gmail.com>: > >> Am Mo., 27. Aug. 2018 um 19:40 Uhr schrieb Paul B Mahol > >: >> >>> On 8/27/18, Thomas Mundt wrote: >>> > Am Fr., 24. Aug. 2018 um 15:05 Uhr schrieb Paul B Mahol < >>> one...@gmail.com>: >>> > >>> >> On 8/23/18, Thomas Mundt wrote: >>> >> > Currently numerical option values are misinterpreted in vf_interlace >>> >> > filter. >>> >> > Patch attached. >>> >> > >>> >> > Regards, >>> >> > Thomas >>> >> > >>> >> >>> >> ok >>> >> >>> > >>> > Thanks. Can you please push it? >>> >>> Does this breaks tinterlace numerical options? >>> >>> Anyway numerical options are not supported, and is free to change. >>> >> >> Indeed the numerical usage of the tinterlace option "flags" is changed. >> But, as you say, numerical usage is not supported or even documented in >> this case. >> The "mode" option is unchanged and can be used numerical as documented. >> > > Ping. > Do you still have concerns? > Ping. This patch fixes a regression and should be pushed. Paul, please tell me if you need more time or information or if I should ask someone else. Regards, Thomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avfilter/vf_interlace: fix numerical options
Am Mo., 27. Aug. 2018 um 20:40 Uhr schrieb Thomas Mundt : > Am Mo., 27. Aug. 2018 um 19:40 Uhr schrieb Paul B Mahol >: > >> On 8/27/18, Thomas Mundt wrote: >> > Am Fr., 24. Aug. 2018 um 15:05 Uhr schrieb Paul B Mahol < >> one...@gmail.com>: >> > >> >> On 8/23/18, Thomas Mundt wrote: >> >> > Currently numerical option values are misinterpreted in vf_interlace >> >> > filter. >> >> > Patch attached. >> >> > >> >> > Regards, >> >> > Thomas >> >> > >> >> >> >> ok >> >> >> > >> > Thanks. Can you please push it? >> >> Does this breaks tinterlace numerical options? >> >> Anyway numerical options are not supported, and is free to change. >> > > Indeed the numerical usage of the tinterlace option "flags" is changed. > But, as you say, numerical usage is not supported or even documented in > this case. > The "mode" option is unchanged and can be used numerical as documented. > Ping. Do you still have concerns? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avfilter/vf_interlace: fix numerical options
Am Mo., 27. Aug. 2018 um 19:40 Uhr schrieb Paul B Mahol : > On 8/27/18, Thomas Mundt wrote: > > Am Fr., 24. Aug. 2018 um 15:05 Uhr schrieb Paul B Mahol < > one...@gmail.com>: > > > >> On 8/23/18, Thomas Mundt wrote: > >> > Currently numerical option values are misinterpreted in vf_interlace > >> > filter. > >> > Patch attached. > >> > > >> > Regards, > >> > Thomas > >> > > >> > >> ok > >> > > > > Thanks. Can you please push it? > > Does this breaks tinterlace numerical options? > > Anyway numerical options are not supported, and is free to change. > Indeed the numerical usage of the tinterlace option "flags" is changed. But, as you say, numerical usage is not supported or even documented in this case. The "mode" option is unchanged and can be used numerical as documented. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avfilter/vf_interlace: fix numerical options
On 8/27/18, Thomas Mundt wrote: > Am Fr., 24. Aug. 2018 um 15:05 Uhr schrieb Paul B Mahol : > >> On 8/23/18, Thomas Mundt wrote: >> > Currently numerical option values are misinterpreted in vf_interlace >> > filter. >> > Patch attached. >> > >> > Regards, >> > Thomas >> > >> >> ok >> > > Thanks. Can you please push it? Does this breaks tinterlace numerical options? Anyway numerical options are not supported, and is free to change. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avfilter/vf_interlace: fix numerical options
Am Fr., 24. Aug. 2018 um 15:05 Uhr schrieb Paul B Mahol : > On 8/23/18, Thomas Mundt wrote: > > Currently numerical option values are misinterpreted in vf_interlace > > filter. > > Patch attached. > > > > Regards, > > Thomas > > > > ok > Thanks. Can you please push it? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avfilter/vf_interlace: fix numerical options
On 8/23/18, Thomas Mundt wrote: > Currently numerical option values are misinterpreted in vf_interlace > filter. > Patch attached. > > Regards, > Thomas > ok ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH] avfilter/vf_interlace: fix numerical options
Currently numerical option values are misinterpreted in vf_interlace filter. Patch attached. Regards, Thomas 0001-avfilter-vf_interlace-fix-numerical-options.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
