Re: [FFmpeg-devel] [PATCH] avformat/aiffdec: parse replaygain metadata

2019-09-20 Thread Michael Niedermayer 
On Thu, Sep 19, 2019 at 04:17:20PM +0200, Moritz Barsnick wrote:
> On Mon, Mar 18, 2019 at 11:01:21 +0100, Paul B Mahol wrote:
> > On 3/18/19, Moritz Barsnick  wrote:
> > >> Tested against sample provided here:
> > >> https://ffmpeg.org/pipermail/ffmpeg-user/2019-March/043717.html
> > >>
> > >>  libavformat/aiffdec.c | 5 +
> > >>  1 file changed, 5 insertions(+)
> > >
> > > Friendly ping.
> >
> > LGTM
> 
> Another ping for push of patch. (Still applies cleanly to HEAD of
> master.)

will apply

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/aiffdec: parse replaygain metadata

2019-09-19 Thread Moritz Barsnick 
On Mon, Mar 18, 2019 at 11:01:21 +0100, Paul B Mahol wrote:
> On 3/18/19, Moritz Barsnick  wrote:
> >> Tested against sample provided here:
> >> https://ffmpeg.org/pipermail/ffmpeg-user/2019-March/043717.html
> >>
> >>  libavformat/aiffdec.c | 5 +
> >>  1 file changed, 5 insertions(+)
> >
> > Friendly ping.
>
> LGTM

Another ping for push of patch. (Still applies cleanly to HEAD of
master.)

Moritz

https://patchwork.ffmpeg.org/patch/12302/
in case it got out of view...
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/aiffdec: parse replaygain metadata

2019-03-18 Thread Paul B Mahol 
On 3/18/19, Moritz Barsnick  wrote:
> On Wed, Mar 13, 2019 at 10:17:40 +0100, Moritz Barsnick wrote:
>> Signed-off-by: Moritz Barsnick 
>> ---
>> Tested against sample provided here:
>> https://ffmpeg.org/pipermail/ffmpeg-user/2019-March/043717.html
>>
>>  libavformat/aiffdec.c | 5 +
>>  1 file changed, 5 insertions(+)
>
> Friendly ping.

LGTM
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/aiffdec: parse replaygain metadata

2019-03-18 Thread Moritz Barsnick 
On Wed, Mar 13, 2019 at 10:17:40 +0100, Moritz Barsnick wrote:
> Signed-off-by: Moritz Barsnick 
> ---
> Tested against sample provided here:
> https://ffmpeg.org/pipermail/ffmpeg-user/2019-March/043717.html
> 
>  libavformat/aiffdec.c | 5 +
>  1 file changed, 5 insertions(+)

Friendly ping.

Cheers,
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avformat/aiffdec: parse replaygain metadata

2019-03-13 Thread Moritz Barsnick 
Signed-off-by: Moritz Barsnick 
---
Tested against sample provided here:
https://ffmpeg.org/pipermail/ffmpeg-user/2019-March/043717.html

 libavformat/aiffdec.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c
index 7c701e0c70..ea2955816a 100644
--- a/libavformat/aiffdec.c
+++ b/libavformat/aiffdec.c
@@ -29,6 +29,7 @@
 #include "isom.h"
 #include "id3v2.h"
 #include "mov_chan.h"
+#include "replaygain.h"
 
 #define AIFF0
 #define AIFF_C_VERSION1 0xA2805140
@@ -348,6 +349,10 @@ static int aiff_read_header(AVFormatContext *s)
 }
 }
 
+ret = ff_replaygain_export(st, s->metadata);
+if (ret < 0)
+return ret;
+
 got_sound:
 if (!st->codecpar->block_align && st->codecpar->codec_id == 
AV_CODEC_ID_QCELP) {
 av_log(s, AV_LOG_WARNING, "qcelp without wave chunk, assuming full 
rate\n");
-- 
2.20.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel