Re: [FFmpeg-devel] [PATCH] avformat/dashenc: Fix a bug with writing "final" manifest

[Jeyapal, Karthick]

On 4/17/19 11:28 AM, Karthick J wrote:
> This bug was introduced in the commit 951561b64ee6c11f01daedd9dcf73276cc1e765b
> ---
>  libavformat/dashenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index 5f1333e436..b88d4b3496 100644
> --- a/libavformat/dashenc.c
> +++ b/libavformat/dashenc.c
> @@ -1631,7 +1631,7 @@ static int dash_flush(AVFormatContext *s, int final, 
> int stream)
>  }
>  }
>  if (ret >= 0) {
> -if (c->has_video) {
> +if (c->has_video && !final) {
>  c->nr_of_streams_flushed++;
>  if (c->nr_of_streams_flushed != c->nr_of_streams_to_flush)
>  return ret;

Pushed.

Regards,
Karthick 

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avformat/dashenc: Fix a bug with writing "final" manifest

[Karthick J via ffmpeg-devel]

This bug was introduced in the commit 951561b64ee6c11f01daedd9dcf73276cc1e765b
---
 libavformat/dashenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
index 5f1333e436..b88d4b3496 100644
--- a/libavformat/dashenc.c
+++ b/libavformat/dashenc.c
@@ -1631,7 +1631,7 @@ static int dash_flush(AVFormatContext *s, int final, int 
stream)
 }
 }
 if (ret >= 0) {
-if (c->has_video) {
+if (c->has_video && !final) {
 c->nr_of_streams_flushed++;
 if (c->nr_of_streams_flushed != c->nr_of_streams_to_flush)
 return ret;
-- 
2.20.1 (Apple Git-117)

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".