Re: [FFmpeg-devel] [PATCH] avformat/mux: remove unnecessary autobsf hack

2016-11-05 Thread James Almer 
On 11/5/2016 9:49 PM, James Almer wrote:
> On 11/5/2016 9:46 PM, Michael Niedermayer wrote:
>> On Fri, Sep 23, 2016 at 02:04:08AM -0300, James Almer wrote:
>>> autobsf has been ported to the new bsf API.
>>>
>>> Signed-off-by: James Almer 
>>> ---
>>>  libavformat/mux.c | 6 --
>>>  1 file changed, 6 deletions(-)
>>
>> has this patch been forgotten ?
> 
> It didn't get a review, and then we began working on the ffmpeg bsf
> port so i kinda forgot, yeah.
> Will re-run fate with it now that we have a better autobsf coverage
> and apply it if it passes.

FATE passes, so applied.

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/mux: remove unnecessary autobsf hack

2016-11-05 Thread James Almer 
On 11/5/2016 9:46 PM, Michael Niedermayer wrote:
> On Fri, Sep 23, 2016 at 02:04:08AM -0300, James Almer wrote:
>> autobsf has been ported to the new bsf API.
>>
>> Signed-off-by: James Almer 
>> ---
>>  libavformat/mux.c | 6 --
>>  1 file changed, 6 deletions(-)
> 
> has this patch been forgotten ?

It didn't get a review, and then we began working on the ffmpeg bsf
port so i kinda forgot, yeah.
Will re-run fate with it now that we have a better autobsf coverage
and apply it if it passes.

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/mux: remove unnecessary autobsf hack

2016-11-05 Thread Michael Niedermayer 
On Fri, Sep 23, 2016 at 02:04:08AM -0300, James Almer wrote:
> autobsf has been ported to the new bsf API.
> 
> Signed-off-by: James Almer 
> ---
>  libavformat/mux.c | 6 --
>  1 file changed, 6 deletions(-)

has this patch been forgotten ?

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avformat/mux: remove unnecessary autobsf hack

2016-09-22 Thread James Almer 
autobsf has been ported to the new bsf API.

Signed-off-by: James Almer 
---
 libavformat/mux.c | 6 --
 1 file changed, 6 deletions(-)

diff --git a/libavformat/mux.c b/libavformat/mux.c
index bbfc0fc..79fbbfc 100644
--- a/libavformat/mux.c
+++ b/libavformat/mux.c
@@ -309,12 +309,6 @@ FF_DISABLE_DEPRECATION_WARNINGS
 FF_ENABLE_DEPRECATION_WARNINGS
 #endif
 
-/* update internal context from codecpar, old bsf api needs this
- * FIXME: remove when autobsf uses new bsf API */
-ret = avcodec_parameters_to_context(st->internal->avctx, st->codecpar);
-if (ret < 0)
-goto fail;
-
 if (!st->time_base.num) {
 /* fall back on the default timebase values */
 if (par->codec_type == AVMEDIA_TYPE_AUDIO && par->sample_rate)
-- 
2.9.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel