Re: [FFmpeg-devel] [PATCH] avutil/frame: flag A53_CC side data type as allowing multiple entries
On 4/11/2024 5:17 PM, Kieran Kunhya wrote: On Thu, 11 Apr 2024, 16:42 James Almer, wrote: Some interlaced h264 samples may export one caption per field. Signed-off-by: James Almer --- libavutil/frame.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 0775e2abd9..fdac6f8ee2 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -30,7 +30,6 @@ static const AVSideDataDescriptor sd_props[] = { [AV_FRAME_DATA_PANSCAN] = { "AVPanScan" }, -[AV_FRAME_DATA_A53_CC] = { "ATSC A53 Part 4 Closed Captions" }, [AV_FRAME_DATA_MATRIXENCODING] = { "AVMatrixEncoding" }, [AV_FRAME_DATA_DOWNMIX_INFO]= { "Metadata relevant to a downmix procedure" }, [AV_FRAME_DATA_AFD] = { "Active format description" }, @@ -55,6 +54,7 @@ static const AVSideDataDescriptor sd_props[] = { [AV_FRAME_DATA_AMBIENT_VIEWING_ENVIRONMENT] = { "Ambient viewing environment", AV_SIDE_DATA_PROP_GLOBAL }, [AV_FRAME_DATA_SPHERICAL] = { "Spherical Mapping", AV_SIDE_DATA_PROP_GLOBAL }, [AV_FRAME_DATA_ICC_PROFILE] = { "ICC profile", AV_SIDE_DATA_PROP_GLOBAL }, +[AV_FRAME_DATA_A53_CC] = { "ATSC A53 Part 4 Closed Captions", AV_SIDE_DATA_PROP_MULTI }, [AV_FRAME_DATA_SEI_UNREGISTERED]= { "H.26[45] User Data Unregistered SEI message", AV_SIDE_DATA_PROP_MULTI }, }; -- 2.44.0 But we merge the captions into a single side data element, no? Kieran Oh, I must have misread how it was exported. Dropping this patch then. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] avutil/frame: flag A53_CC side data type as allowing multiple entries
On Thu, 11 Apr 2024, 16:42 James Almer, wrote: > Some interlaced h264 samples may export one caption per field. > > Signed-off-by: James Almer > --- > libavutil/frame.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/frame.c b/libavutil/frame.c > index 0775e2abd9..fdac6f8ee2 100644 > --- a/libavutil/frame.c > +++ b/libavutil/frame.c > @@ -30,7 +30,6 @@ > > static const AVSideDataDescriptor sd_props[] = { > [AV_FRAME_DATA_PANSCAN] = { "AVPanScan" }, > -[AV_FRAME_DATA_A53_CC] = { "ATSC A53 Part 4 > Closed Captions" }, > [AV_FRAME_DATA_MATRIXENCODING] = { "AVMatrixEncoding" }, > [AV_FRAME_DATA_DOWNMIX_INFO]= { "Metadata relevant to > a downmix procedure" }, > [AV_FRAME_DATA_AFD] = { "Active format > description" }, > @@ -55,6 +54,7 @@ static const AVSideDataDescriptor sd_props[] = { > [AV_FRAME_DATA_AMBIENT_VIEWING_ENVIRONMENT] = { "Ambient viewing > environment", AV_SIDE_DATA_PROP_GLOBAL }, > [AV_FRAME_DATA_SPHERICAL] = { "Spherical Mapping", > AV_SIDE_DATA_PROP_GLOBAL }, > [AV_FRAME_DATA_ICC_PROFILE] = { "ICC profile", > AV_SIDE_DATA_PROP_GLOBAL }, > +[AV_FRAME_DATA_A53_CC] = { "ATSC A53 Part 4 > Closed Captions", AV_SIDE_DATA_PROP_MULTI }, > [AV_FRAME_DATA_SEI_UNREGISTERED]= { "H.26[45] User Data > Unregistered SEI message", AV_SIDE_DATA_PROP_MULTI }, > }; > > -- > 2.44.0 > But we merge the captions into a single side data element, no? Kieran > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH] avutil/frame: flag A53_CC side data type as allowing multiple entries
Some interlaced h264 samples may export one caption per field. Signed-off-by: James Almer --- libavutil/frame.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 0775e2abd9..fdac6f8ee2 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -30,7 +30,6 @@ static const AVSideDataDescriptor sd_props[] = { [AV_FRAME_DATA_PANSCAN] = { "AVPanScan" }, -[AV_FRAME_DATA_A53_CC] = { "ATSC A53 Part 4 Closed Captions" }, [AV_FRAME_DATA_MATRIXENCODING] = { "AVMatrixEncoding" }, [AV_FRAME_DATA_DOWNMIX_INFO]= { "Metadata relevant to a downmix procedure" }, [AV_FRAME_DATA_AFD] = { "Active format description" }, @@ -55,6 +54,7 @@ static const AVSideDataDescriptor sd_props[] = { [AV_FRAME_DATA_AMBIENT_VIEWING_ENVIRONMENT] = { "Ambient viewing environment", AV_SIDE_DATA_PROP_GLOBAL }, [AV_FRAME_DATA_SPHERICAL] = { "Spherical Mapping", AV_SIDE_DATA_PROP_GLOBAL }, [AV_FRAME_DATA_ICC_PROFILE] = { "ICC profile", AV_SIDE_DATA_PROP_GLOBAL }, +[AV_FRAME_DATA_A53_CC] = { "ATSC A53 Part 4 Closed Captions", AV_SIDE_DATA_PROP_MULTI }, [AV_FRAME_DATA_SEI_UNREGISTERED]= { "H.26[45] User Data Unregistered SEI message", AV_SIDE_DATA_PROP_MULTI }, }; -- 2.44.0 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".