Re: [FFmpeg-devel] [PATCH] avutil/tx: print debug log at trace level
On 2/22/2024 12:16 AM, Lynne wrote: I see... If you keep the "Transform tree" printout on debug, lgtm. Done. Thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] avutil/tx: print debug log at trace level
Feb 21, 2024, 17:38 by jamr...@gmail.com:
> On 2/21/2024 1:32 PM, Lynne wrote:
>
>> Feb 21, 2024, 15:43 by jamr...@gmail.com:
>>
>>> The output of TX is extremely verbose and makes it harder to find other
>>> debug
>>> log messages, so only print it at trace level.
>>>
>>> Signed-off-by: James Almer
>>> ---
>>> libavutil/tx.c | 10 +-
>>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/libavutil/tx.c b/libavutil/tx.c
>>> index f991618b4b..eefb3e2ac7 100644
>>> --- a/libavutil/tx.c
>>> +++ b/libavutil/tx.c
>>> @@ -643,7 +643,7 @@ static void print_cd_info(const FFTXCodelet *cd, int
>>> prio, int len, int print_pr
>>> if (print_prio)
>>> av_bprintf(, ", prio: %i", prio);
>>> -av_log(NULL, AV_LOG_DEBUG, "%s\n", bp.str);
>>> +av_log(NULL, AV_LOG_TRACE, "%s\n", bp.str);
>>> }
>>> static void print_tx_structure(AVTXContext *s, int depth)
>>> @@ -651,7 +651,7 @@ static void print_tx_structure(AVTXContext *s, int
>>> depth)
>>> const FFTXCodelet *cd = s->cd_self;
>>> for (int i = 0; i <= depth; i++)
>>> -av_log(NULL, AV_LOG_DEBUG, "");
>>> +av_log(NULL, AV_LOG_TRACE, "");
>>> print_cd_info(cd, cd->prio, s->len, 0);
>>> @@ -816,10 +816,10 @@ av_cold int ff_tx_init_subtx(AVTXContext *s, enum
>>> AVTXType type,
>>> AV_QSORT(cd_matches, nb_cd_matches, TXCodeletMatch, cmp_matches);
>>> #if !CONFIG_SMALL
>>> -av_log(NULL, AV_LOG_DEBUG, "%s\n", bp.str);
>>> +av_log(NULL, AV_LOG_TRACE, "%s\n", bp.str);
>>> for (int i = 0; i < nb_cd_matches; i++) {
>>> -av_log(NULL, AV_LOG_DEBUG, "%i: ", i + 1);
>>> +av_log(NULL, AV_LOG_TRACE, "%i: ", i + 1);
>>> print_cd_info(cd_matches[i].cd, cd_matches[i].prio, 0, 1);
>>> }
>>> #endif
>>> @@ -929,7 +929,7 @@ av_cold int av_tx_init(AVTXContext **ctx, av_tx_fn *tx,
>>> enum AVTXType type,
>>> *tx = tmp.fn[0];
>>> #if !CONFIG_SMALL
>>> -av_log(NULL, AV_LOG_DEBUG, "Transform tree:\n");
>>> +av_log(NULL, AV_LOG_TRACE, "Transform tree:\n");
>>> print_tx_structure(*ctx, 0);
>>> #endif
>>>
>>
>> It's a chunk of few dozen lines, I don't think it's spammy enough for trace.
>>
>
> It's extremely spammy. Here's what i get when i simply do "ffmpeg -loglevel
> debug -i INPUT" with a file that has four Opus streams, simply for probing
> them:
>
>> For transform of length 120, inverse, mdct_float, flags: [aligned,
>> out_of_place], found 6 matches:
>> 1: mdct_inv_float_avx2 - type: mdct_float, len: [16, ∞], factors[2]: [2,
>> any], flags: [aligned, out_of_place, inv_only], prio: 544
>> 2: mdct_pfa_15xM_inv_float_c - type: mdct_float, len: [30, ∞], factors[2]:
>> [15, any], flags: [unaligned, out_of_place, inv_only], prio: 304
>> 3: mdct_pfa_5xM_inv_float_c - type: mdct_float, len: [10, ∞], factors[2]:
>> [5, any], flags: [unaligned, out_of_place, inv_only], prio: 144
>> 4: mdct_pfa_3xM_inv_float_c - type: mdct_float, len: [6, ∞], factors[2]:
>> [3, any], flags: [unaligned, out_of_place, inv_only], prio: 112
>> 5: mdct_inv_float_c - type: mdct_float, len: [2, ∞], factors[2]: [2, any],
>> flags: [unaligned, out_of_place, inv_only], prio: 96
>> 6: mdct_naive_inv_float_c - type: mdct_float, len: [2, ∞], factors[2]: [2,
>> any], flags: [unaligned, out_of_place, inv_only], prio: -130976
>> For transform of length 60, inverse, fft_float, flags: [aligned, inplace,
>> preshuf, asm_call], found 1 matches:
>> 1: fft_pfa_15xM_asm_float_avx2 - type: fft_float, len: [60, ∞], factors[2]:
>> [15, 2], flags: [aligned, inplace, out_of_place, preshuf, asm_call], prio:
>> 688
>> For transform of length 4, inverse, fft_float, flags: [aligned, inplace,
>> preshuf, asm_call], found 1 matches:
>> 1: fft4_fwd_asm_float_sse2 - type: fft_float, len: 4, factor: 2, flags:
>> [aligned, inplace, out_of_place, preshuf, asm_call], prio: 352
>> Transform tree:
>> mdct_inv_float_avx2 - type: mdct_float, len: 120, factors[2]: [2, any],
>> flags: [aligned, out_of_place, inv_only]
>> fft_pfa_15xM_asm_float_avx2 - type: fft_float, len: 60, factors[2]: [15,
>> 2], flags: [aligned, inplace, out_of_place, preshuf, asm_call]
>> fft4_fwd_asm_float_sse2 - type: fft_float, len: 4, factor: 2, flags:
>> [aligned, inplace, out_of_place, preshuf, asm_call]
>> For transform of length 240, inverse, mdct_float, flags: [aligned,
>> out_of_place], found 6 matches:
>> 1: mdct_inv_float_avx2 - type: mdct_float, len: [16, ∞], factors[2]: [2,
>> any], flags: [aligned, out_of_place, inv_only], prio: 544
>> 2: mdct_pfa_15xM_inv_float_c - type: mdct_float, len: [30, ∞], factors[2]:
>> [15, any], flags: [unaligned, out_of_place, inv_only], prio: 304
>> 3: mdct_pfa_5xM_inv_float_c - type: mdct_float, len: [10, ∞], factors[2]:
>> [5, any], flags: [unaligned, out_of_place, inv_only], prio: 144
>> 4: mdct_pfa_3xM_inv_float_c - type: mdct_float, len: [6, ∞], factors[2]:
>> [3, any], flags: [unaligned, out_of_place, inv_only], prio: 112
>> 5: mdct_inv_float_c - type: mdct_float, len: [2, ∞], factors[2]:
Re: [FFmpeg-devel] [PATCH] avutil/tx: print debug log at trace level
On 2/21/2024 1:32 PM, Lynne wrote:
Feb 21, 2024, 15:43 by jamr...@gmail.com:
The output of TX is extremely verbose and makes it harder to find other debug
log messages, so only print it at trace level.
Signed-off-by: James Almer
---
libavutil/tx.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavutil/tx.c b/libavutil/tx.c
index f991618b4b..eefb3e2ac7 100644
--- a/libavutil/tx.c
+++ b/libavutil/tx.c
@@ -643,7 +643,7 @@ static void print_cd_info(const FFTXCodelet *cd, int prio,
int len, int print_pr
if (print_prio)
av_bprintf(, ", prio: %i", prio);
-av_log(NULL, AV_LOG_DEBUG, "%s\n", bp.str);
+av_log(NULL, AV_LOG_TRACE, "%s\n", bp.str);
}
static void print_tx_structure(AVTXContext *s, int depth)
@@ -651,7 +651,7 @@ static void print_tx_structure(AVTXContext *s, int depth)
const FFTXCodelet *cd = s->cd_self;
for (int i = 0; i <= depth; i++)
-av_log(NULL, AV_LOG_DEBUG, "");
+av_log(NULL, AV_LOG_TRACE, "");
print_cd_info(cd, cd->prio, s->len, 0);
@@ -816,10 +816,10 @@ av_cold int ff_tx_init_subtx(AVTXContext *s, enum AVTXType type,
AV_QSORT(cd_matches, nb_cd_matches, TXCodeletMatch, cmp_matches);
#if !CONFIG_SMALL
-av_log(NULL, AV_LOG_DEBUG, "%s\n", bp.str);
+av_log(NULL, AV_LOG_TRACE, "%s\n", bp.str);
for (int i = 0; i < nb_cd_matches; i++) {
-av_log(NULL, AV_LOG_DEBUG, "%i: ", i + 1);
+av_log(NULL, AV_LOG_TRACE, "%i: ", i + 1);
print_cd_info(cd_matches[i].cd, cd_matches[i].prio, 0, 1);
}
#endif
@@ -929,7 +929,7 @@ av_cold int av_tx_init(AVTXContext **ctx, av_tx_fn *tx,
enum AVTXType type,
*tx = tmp.fn[0];
#if !CONFIG_SMALL
-av_log(NULL, AV_LOG_DEBUG, "Transform tree:\n");
+av_log(NULL, AV_LOG_TRACE, "Transform tree:\n");
print_tx_structure(*ctx, 0);
#endif
It's a chunk of few dozen lines, I don't think it's spammy enough for trace.
It's extremely spammy. Here's what i get when i simply do "ffmpeg
-loglevel debug -i INPUT" with a file that has four Opus streams, simply
for probing them:
For transform of length 120, inverse, mdct_float, flags: [aligned,
out_of_place], found 6 matches:
1: mdct_inv_float_avx2 - type: mdct_float, len: [16, ∞], factors[2]: [2,
any], flags: [aligned, out_of_place, inv_only], prio: 544
2: mdct_pfa_15xM_inv_float_c - type: mdct_float, len: [30, ∞], factors[2]:
[15, any], flags: [unaligned, out_of_place, inv_only], prio: 304
3: mdct_pfa_5xM_inv_float_c - type: mdct_float, len: [10, ∞], factors[2]:
[5, any], flags: [unaligned, out_of_place, inv_only], prio: 144
4: mdct_pfa_3xM_inv_float_c - type: mdct_float, len: [6, ∞], factors[2]:
[3, any], flags: [unaligned, out_of_place, inv_only], prio: 112
5: mdct_inv_float_c - type: mdct_float, len: [2, ∞], factors[2]: [2, any],
flags: [unaligned, out_of_place, inv_only], prio: 96
6: mdct_naive_inv_float_c - type: mdct_float, len: [2, ∞], factors[2]: [2,
any], flags: [unaligned, out_of_place, inv_only], prio: -130976
For transform of length 60, inverse, fft_float, flags: [aligned, inplace,
preshuf, asm_call], found 1 matches:
1: fft_pfa_15xM_asm_float_avx2 - type: fft_float, len: [60, ∞], factors[2]:
[15, 2], flags: [aligned, inplace, out_of_place, preshuf, asm_call], prio: 688
For transform of length 4, inverse, fft_float, flags: [aligned, inplace,
preshuf, asm_call], found 1 matches:
1: fft4_fwd_asm_float_sse2 - type: fft_float, len: 4, factor: 2, flags:
[aligned, inplace, out_of_place, preshuf, asm_call], prio: 352
Transform tree:
mdct_inv_float_avx2 - type: mdct_float, len: 120, factors[2]: [2, any],
flags: [aligned, out_of_place, inv_only]
fft_pfa_15xM_asm_float_avx2 - type: fft_float, len: 60, factors[2]:
[15, 2], flags: [aligned, inplace, out_of_place, preshuf, asm_call]
fft4_fwd_asm_float_sse2 - type: fft_float, len: 4, factor: 2,
flags: [aligned, inplace, out_of_place, preshuf, asm_call]
For transform of length 240, inverse, mdct_float, flags: [aligned,
out_of_place], found 6 matches:
1: mdct_inv_float_avx2 - type: mdct_float, len: [16, ∞], factors[2]: [2,
any], flags: [aligned, out_of_place, inv_only], prio: 544
2: mdct_pfa_15xM_inv_float_c - type: mdct_float, len: [30, ∞], factors[2]:
[15, any], flags: [unaligned, out_of_place, inv_only], prio: 304
3: mdct_pfa_5xM_inv_float_c - type: mdct_float, len: [10, ∞], factors[2]:
[5, any], flags: [unaligned, out_of_place, inv_only], prio: 144
4: mdct_pfa_3xM_inv_float_c - type: mdct_float, len: [6, ∞], factors[2]:
[3, any], flags: [unaligned, out_of_place, inv_only], prio: 112
5: mdct_inv_float_c - type: mdct_float, len: [2, ∞], factors[2]: [2, any],
flags: [unaligned, out_of_place, inv_only], prio: 96
6: mdct_naive_inv_float_c - type: mdct_float, len: [2, ∞], factors[2]: [2,
any], flags: [unaligned, out_of_place, inv_only], prio: -130976
For transform of length 120, inverse, fft_float, flags: [aligned,
Re: [FFmpeg-devel] [PATCH] avutil/tx: print debug log at trace level
Feb 21, 2024, 15:43 by jamr...@gmail.com:
> The output of TX is extremely verbose and makes it harder to find other debug
> log messages, so only print it at trace level.
>
> Signed-off-by: James Almer
> ---
> libavutil/tx.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/libavutil/tx.c b/libavutil/tx.c
> index f991618b4b..eefb3e2ac7 100644
> --- a/libavutil/tx.c
> +++ b/libavutil/tx.c
> @@ -643,7 +643,7 @@ static void print_cd_info(const FFTXCodelet *cd, int
> prio, int len, int print_pr
> if (print_prio)
> av_bprintf(, ", prio: %i", prio);
>
> -av_log(NULL, AV_LOG_DEBUG, "%s\n", bp.str);
> +av_log(NULL, AV_LOG_TRACE, "%s\n", bp.str);
> }
>
> static void print_tx_structure(AVTXContext *s, int depth)
> @@ -651,7 +651,7 @@ static void print_tx_structure(AVTXContext *s, int depth)
> const FFTXCodelet *cd = s->cd_self;
>
> for (int i = 0; i <= depth; i++)
> -av_log(NULL, AV_LOG_DEBUG, "");
> +av_log(NULL, AV_LOG_TRACE, "");
>
> print_cd_info(cd, cd->prio, s->len, 0);
>
> @@ -816,10 +816,10 @@ av_cold int ff_tx_init_subtx(AVTXContext *s, enum
> AVTXType type,
> AV_QSORT(cd_matches, nb_cd_matches, TXCodeletMatch, cmp_matches);
>
> #if !CONFIG_SMALL
> -av_log(NULL, AV_LOG_DEBUG, "%s\n", bp.str);
> +av_log(NULL, AV_LOG_TRACE, "%s\n", bp.str);
>
> for (int i = 0; i < nb_cd_matches; i++) {
> -av_log(NULL, AV_LOG_DEBUG, "%i: ", i + 1);
> +av_log(NULL, AV_LOG_TRACE, "%i: ", i + 1);
> print_cd_info(cd_matches[i].cd, cd_matches[i].prio, 0, 1);
> }
> #endif
> @@ -929,7 +929,7 @@ av_cold int av_tx_init(AVTXContext **ctx, av_tx_fn *tx,
> enum AVTXType type,
> *tx = tmp.fn[0];
>
> #if !CONFIG_SMALL
> -av_log(NULL, AV_LOG_DEBUG, "Transform tree:\n");
> +av_log(NULL, AV_LOG_TRACE, "Transform tree:\n");
> print_tx_structure(*ctx, 0);
> #endif
>
It's a chunk of few dozen lines, I don't think it's spammy enough for trace.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH] avutil/tx: print debug log at trace level
The output of TX is extremely verbose and makes it harder to find other debug
log messages, so only print it at trace level.
Signed-off-by: James Almer
---
libavutil/tx.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavutil/tx.c b/libavutil/tx.c
index f991618b4b..eefb3e2ac7 100644
--- a/libavutil/tx.c
+++ b/libavutil/tx.c
@@ -643,7 +643,7 @@ static void print_cd_info(const FFTXCodelet *cd, int prio,
int len, int print_pr
if (print_prio)
av_bprintf(, ", prio: %i", prio);
-av_log(NULL, AV_LOG_DEBUG, "%s\n", bp.str);
+av_log(NULL, AV_LOG_TRACE, "%s\n", bp.str);
}
static void print_tx_structure(AVTXContext *s, int depth)
@@ -651,7 +651,7 @@ static void print_tx_structure(AVTXContext *s, int depth)
const FFTXCodelet *cd = s->cd_self;
for (int i = 0; i <= depth; i++)
-av_log(NULL, AV_LOG_DEBUG, "");
+av_log(NULL, AV_LOG_TRACE, "");
print_cd_info(cd, cd->prio, s->len, 0);
@@ -816,10 +816,10 @@ av_cold int ff_tx_init_subtx(AVTXContext *s, enum
AVTXType type,
AV_QSORT(cd_matches, nb_cd_matches, TXCodeletMatch, cmp_matches);
#if !CONFIG_SMALL
-av_log(NULL, AV_LOG_DEBUG, "%s\n", bp.str);
+av_log(NULL, AV_LOG_TRACE, "%s\n", bp.str);
for (int i = 0; i < nb_cd_matches; i++) {
-av_log(NULL, AV_LOG_DEBUG, "%i: ", i + 1);
+av_log(NULL, AV_LOG_TRACE, "%i: ", i + 1);
print_cd_info(cd_matches[i].cd, cd_matches[i].prio, 0, 1);
}
#endif
@@ -929,7 +929,7 @@ av_cold int av_tx_init(AVTXContext **ctx, av_tx_fn *tx,
enum AVTXType type,
*tx = tmp.fn[0];
#if !CONFIG_SMALL
-av_log(NULL, AV_LOG_DEBUG, "Transform tree:\n");
+av_log(NULL, AV_LOG_TRACE, "Transform tree:\n");
print_tx_structure(*ctx, 0);
#endif
--
2.43.2
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
