Re: [FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.
Am 08.02.15 um 15:19 schrieb Carl Eugen Hoyos: Hi! On Wednesday 04 February 2015 01:48:53 pm Thilo Borgmann wrote: fixes Ticket #4238. Testing for CGImageGetTypeID function is questionable (see trac discussion). If someone has a better idea, please let me know. Alternative patch attached. Also attached is a patch that I believe is necessary for iOS audio capture, but it is mostly untested. (It allows device listing though.) Please comment, Carl Eugen Please apply patchavfs16.diff anyone. Thanks! -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.
On Thu, Mar 05, 2015 at 08:18:26PM +0100, Thilo Borgmann wrote: Am 08.02.15 um 15:19 schrieb Carl Eugen Hoyos: Hi! On Wednesday 04 February 2015 01:48:53 pm Thilo Borgmann wrote: fixes Ticket #4238. Testing for CGImageGetTypeID function is questionable (see trac discussion). If someone has a better idea, please let me know. Alternative patch attached. Also attached is a patch that I believe is necessary for iOS audio capture, but it is mostly untested. (It allows device listing though.) Please comment, Carl Eugen Please apply patchavfs16.diff anyone. id do it, but i dont know what commit message to use [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.
Am 05.03.15 um 22:57 schrieb Michael Niedermayer: On Thu, Mar 05, 2015 at 08:18:26PM +0100, Thilo Borgmann wrote: Am 08.02.15 um 15:19 schrieb Carl Eugen Hoyos: Hi! On Wednesday 04 February 2015 01:48:53 pm Thilo Borgmann wrote: fixes Ticket #4238. Testing for CGImageGetTypeID function is questionable (see trac discussion). If someone has a better idea, please let me know. Alternative patch attached. Also attached is a patch that I believe is necessary for iOS audio capture, but it is mostly untested. (It allows device listing though.) Please comment, Carl Eugen Please apply patchavfs16.diff anyone. id do it, but i dont know what commit message to use lavd/avfoundation: Add support for 16bit integer input. -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.
Thilo Borgmann thilo.borgmann at mail.de writes: lavd/avfoundation: Add support for 16bit integer input. I used this commit message for my patch and also pushed John Robinson's patch with a similar message. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.
Thilo Borgmann thilo.borgmann at mail.de writes: New, simpler patch attached. Please apply but check for CoreGraphics first, please. I applied this patch. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.
Am 09.02.15 um 21:55 schrieb Carl Eugen Hoyos: Thilo Borgmann thilo.borgmann at mail.de writes: Am 09.02.15 um 12:33 schrieb Carl Eugen Hoyos: On Monday 09 February 2015 11:26:57 am Thilo Borgmann wrote: do you really mean to check for CoreGraphics.h in case of lib ApplicationServices? New, simpler patch attached. This patch works locally for the build-only aarch64 fate slot. It builds a static libavdevice.a, so I think it works. It works fine here for iOS (as did the last iteration). Please apply but check for CoreGraphics first, please. Thanks, Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.
Am 08.02.15 um 15:19 schrieb Carl Eugen Hoyos: [...] Also attached is a patch that I believe is necessary for iOS audio capture, but it is mostly untested. (It allows device listing though.) Looks OK, please apply. -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.
Am 09.02.15 um 12:33 schrieb Carl Eugen Hoyos: On Monday 09 February 2015 11:26:57 am Thilo Borgmann wrote: do you really mean to check for CoreGraphics.h in case of lib ApplicationServices? New, simpler patch attached. This patch works locally for the build-only aarch64 fate slot. It builds a static libavdevice.a, so I think it works. However I'm confused because it does not include either ApplicationServices nor CoreGraphics. Thus I think that a) this patch does not work as expected b) neither framework is actually needed for iOS (7.1 SDK) The iPhone hung for days on one of the tests, therefore I could not run a test on that by now. @CE: Have you tested this on 10.7? (or could you please post your patch in trac for Nieder to test it on 10.7?) -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.
Thilo Borgmann thilo.borgmann at mail.de writes: Am 09.02.15 um 12:33 schrieb Carl Eugen Hoyos: On Monday 09 February 2015 11:26:57 am Thilo Borgmann wrote: do you really mean to check for CoreGraphics.h in case of lib ApplicationServices? New, simpler patch attached. This patch works locally for the build-only aarch64 fate slot. It builds a static libavdevice.a, so I think it works. It works fine here for iOS (as did the last iteration). However I'm confused because it does not include either ApplicationServices nor CoreGraphics. Thus I think that a) this patch does not work as expected b) neither framework is actually needed for iOS (7.1 SDK) I thought that you had explained that to me... Have you tested this on 10.7? I don't have access to a 10.7 box but the patch does not behave differently than yours afaict. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.
Am 08.02.15 um 15:56 schrieb Michael Niedermayer: On Sun, Feb 08, 2015 at 03:19:40PM +0100, Carl Eugen Hoyos wrote: Hi! On Wednesday 04 February 2015 01:48:53 pm Thilo Borgmann wrote: fixes Ticket #4238. Testing for CGImageGetTypeID function is questionable (see trac discussion). If someone has a better idea, please let me know. Alternative patch attached. Also attached is a patch that I believe is necessary for iOS audio capture, but it is mostly untested. (It allows device listing though.) Please comment, Carl Eugen i can confirm that this doesnt break build anymore Like I wrote in Trac, I think CGGetActiveDisplayList is not available for iOS - the Apple reference makes me believe that. Thus, this has worked on my Mac but I could not yet really test it on the iPhone. This is why I had choosen a function available on almost any SDK version and OS, although unused in the code. Also, do you really mean to check for CoreGraphics.h in case of lib ApplicationServices? You might have noticed that I (finally) reworked my local FATE framework and it seems to be much more stable and reliable than before (sorry for the everlasting delay on that part) - except for the iPhone which I will try to fix asap and test this patch better. I will also try to test the audio part in the second patch then. I will just need some time... -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.
On Monday 09 February 2015 11:26:57 am Thilo Borgmann wrote: do you really mean to check for CoreGraphics.h in case of lib ApplicationServices? New, simpler patch attached. Thank you, Carl Eugen diff --git a/configure b/configure index f31d372..21d6a7e 100755 --- a/configure +++ b/configure @@ -2483,7 +2483,7 @@ xwma_demuxer_select=riffdec # indevs / outdevs alsa_indev_deps=alsa_asoundlib_h snd_pcm_htimestamp alsa_outdev_deps=alsa_asoundlib_h -avfoundation_indev_extralibs=-framework CoreVideo -framework Foundation -framework AVFoundation -framework CoreMedia -framework CoreGraphics +avfoundation_indev_extralibs=-framework CoreVideo -framework Foundation -framework AVFoundation -framework CoreMedia avfoundation_indev_select=avfoundation bktr_indev_deps_any=dev_bktr_ioctl_bt848_h machine_ioctl_bt848_h dev_video_bktr_ioctl_bt848_h dev_ic_bt8xx_h caca_outdev_deps=libcaca @@ -4869,6 +4869,8 @@ done # these are off by default, so fail if requested and not available enabled avfoundation_indev { check_header_oc AVFoundation/AVFoundation.h || disable avfoundation_indev; } +enabled avfoundation_indev { check_lib2 ApplicationServices/ApplicationServices.h CGGetActiveDisplayList -framework ApplicationServices || +check_lib2 CoreGraphics/CoreGraphics.h CGGetActiveDisplayList -framework CoreGraphics; } enabled avisynth { { check_lib2 windows.h LoadLibrary; } || { check_lib2 dlfcn.h dlopen -ldl; } || die ERROR: LoadLibrary/dlopen not found for avisynth; } ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.
Hi! On Wednesday 04 February 2015 01:48:53 pm Thilo Borgmann wrote: fixes Ticket #4238. Testing for CGImageGetTypeID function is questionable (see trac discussion). If someone has a better idea, please let me know. Alternative patch attached. Also attached is a patch that I believe is necessary for iOS audio capture, but it is mostly untested. (It allows device listing though.) Please comment, Carl Eugen diff --git a/configure b/configure index f31d372..d948757 100755 --- a/configure +++ b/configure @@ -2483,7 +2483,7 @@ xwma_demuxer_select=riffdec # indevs / outdevs alsa_indev_deps=alsa_asoundlib_h snd_pcm_htimestamp alsa_outdev_deps=alsa_asoundlib_h -avfoundation_indev_extralibs=-framework CoreVideo -framework Foundation -framework AVFoundation -framework CoreMedia -framework CoreGraphics +avfoundation_indev_extralibs=-framework CoreVideo -framework Foundation -framework AVFoundation -framework CoreMedia avfoundation_indev_select=avfoundation bktr_indev_deps_any=dev_bktr_ioctl_bt848_h machine_ioctl_bt848_h dev_video_bktr_ioctl_bt848_h dev_ic_bt8xx_h caca_outdev_deps=libcaca @@ -4868,7 +4868,11 @@ for func in $MATH_FUNCS; do done # these are off by default, so fail if requested and not available -enabled avfoundation_indev { check_header_oc AVFoundation/AVFoundation.h || disable avfoundation_indev; } +enabled avfoundation_indev { check_header_oc AVFoundation/AVFoundation.h +{ check_lib2 CoreGraphics/CoreGraphics.h CGGetActiveDisplayList -framework ApplicationServices || + check_lib2 CoreGraphics/CoreGraphics.h CGGetActiveDisplayList -framework CoreGraphics || + true; } || +disable avfoundation_indev; } enabled avisynth { { check_lib2 windows.h LoadLibrary; } || { check_lib2 dlfcn.h dlopen -ldl; } || die ERROR: LoadLibrary/dlopen not found for avisynth; } diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m index 1a7eb5b..e1d1050 100644 --- a/libavdevice/avfoundation.m +++ b/libavdevice/avfoundation.m @@ -500,8 +500,14 @@ static int get_audio_config(AVFormatContext *s) if (basic_desc-mFormatID == kAudioFormatLinearPCM ctx-audio_float +ctx-audio_bits_per_sample == 32 ctx-audio_packed) { stream-codec-codec_id = ctx-audio_be ? AV_CODEC_ID_PCM_F32BE : AV_CODEC_ID_PCM_F32LE; +} else if (basic_desc-mFormatID == kAudioFormatLinearPCM +ctx-audio_signed_integer +ctx-audio_bits_per_sample == 16 +ctx-audio_packed) { +stream-codec-codec_id = ctx-audio_be ? AV_CODEC_ID_PCM_S16BE : AV_CODEC_ID_PCM_S16LE; } else { av_log(s, AV_LOG_ERROR, audio format is not supported\n); return 1; ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.
On Sun, Feb 08, 2015 at 03:19:40PM +0100, Carl Eugen Hoyos wrote: Hi! On Wednesday 04 February 2015 01:48:53 pm Thilo Borgmann wrote: fixes Ticket #4238. Testing for CGImageGetTypeID function is questionable (see trac discussion). If someone has a better idea, please let me know. Alternative patch attached. Also attached is a patch that I believe is necessary for iOS audio capture, but it is mostly untested. (It allows device listing though.) Please comment, Carl Eugen i can confirm that this doesnt break build anymore [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have often repented speaking, but never of holding my tongue. -- Xenocrates signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.
On Wed, Feb 04, 2015 at 01:53:20PM +0100, Thilo Borgmann wrote: Am 04.02.15 um 13:48 schrieb Thilo Borgmann: [PATCH] configure: Check linking against CoreGraphics or ApplicationServices framework for avfoundation input device. Fixes ticket #4238. Updated patch without blank line. -Thilo configure |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) 0be741563cf30a335ddba38613e98ac10a2cbee6 0001-configure-Check-linking-against-CoreGraphics-or-Appl.patch From 921f571d601fe51d21ec29320a157dc4e0ba72ed Mon Sep 17 00:00:00 2001 From: Thilo Borgmann thilo.borgm...@mail.de Date: Wed, 4 Feb 2015 13:52:20 +0100 Subject: [PATCH] configure: Check linking against CoreGraphics or ApplicationServices framework for avfoundation input device. Fixes ticket #4238. This patch breaks build on linux CC libavdevice/avfoundation.o gcc: error trying to exec 'cc1obj': execvp: No such file or directory make: *** [libavdevice/avfoundation.o] Error 1 grep FOUND config.* config.asm:%define CONFIG_AVFOUNDATION_INDEV 1 config.h:#define CONFIG_AVFOUNDATION_INDEV 1 config.mak:CONFIG_AVFOUNDATION_INDEV=yes [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB it is not once nor twice but times without number that the same ideas make their appearance in the world. -- Aristotle signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.
Hi, fixes Ticket #4238. Testing for CGImageGetTypeID function is questionable (see trac discussion). If someone has a better idea, please let me know. -Thilo From be77bd85b61a922b442235ef7a0c494137672890 Mon Sep 17 00:00:00 2001 From: Thilo Borgmann thilo.borgm...@mail.de Date: Wed, 4 Feb 2015 13:44:43 +0100 Subject: [PATCH] configure: Check linking against CoreGraphics or ApplicationServices framework for avfoundation input device. Fixes ticket #4238. --- configure | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 6d56f59..e3f49aa 100755 --- a/configure +++ b/configure @@ -2483,7 +2483,7 @@ xwma_demuxer_select=riffdec # indevs / outdevs alsa_indev_deps=alsa_asoundlib_h snd_pcm_htimestamp alsa_outdev_deps=alsa_asoundlib_h -avfoundation_indev_extralibs=-framework CoreVideo -framework Foundation -framework AVFoundation -framework CoreMedia -framework CoreGraphics +avfoundation_indev_extralibs=-framework CoreVideo -framework Foundation -framework AVFoundation -framework CoreMedia avfoundation_indev_select=avfoundation bktr_indev_deps_any=dev_bktr_ioctl_bt848_h machine_ioctl_bt848_h dev_video_bktr_ioctl_bt848_h dev_ic_bt8xx_h caca_outdev_deps=libcaca @@ -4868,7 +4868,11 @@ for func in $MATH_FUNCS; do done # these are off by default, so fail if requested and not available -enabled avfoundation_indev { check_header_oc AVFoundation/AVFoundation.h || disable avfoundation_indev; } +enabled avfoundation_indev check_header_oc AVFoundation/AVFoundation.h +{ check_lib2 CoreGraphics/CoreGraphics.h CGImageGetTypeID -Wl,-framework,CoreGraphics || + check_lib2 ApplicationServices/ApplicationServices.h CGImageGetTypeID -Wl,-framework,ApplicationServices || + disable avfoundation_indev; } + enabled avisynth { { check_lib2 windows.h LoadLibrary; } || { check_lib2 dlfcn.h dlopen -ldl; } || die ERROR: LoadLibrary/dlopen not found for avisynth; } -- 1.9.3 (Apple Git-50) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: Check linking against CoreGraphics or, ApplicationServices framework for avfoundation input device.
Am 04.02.15 um 13:48 schrieb Thilo Borgmann: [PATCH] configure: Check linking against CoreGraphics or ApplicationServices framework for avfoundation input device. Fixes ticket #4238. Updated patch without blank line. -Thilo From 921f571d601fe51d21ec29320a157dc4e0ba72ed Mon Sep 17 00:00:00 2001 From: Thilo Borgmann thilo.borgm...@mail.de Date: Wed, 4 Feb 2015 13:52:20 +0100 Subject: [PATCH] configure: Check linking against CoreGraphics or ApplicationServices framework for avfoundation input device. Fixes ticket #4238. --- configure | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 6d56f59..4a2e7d2 100755 --- a/configure +++ b/configure @@ -2483,7 +2483,7 @@ xwma_demuxer_select=riffdec # indevs / outdevs alsa_indev_deps=alsa_asoundlib_h snd_pcm_htimestamp alsa_outdev_deps=alsa_asoundlib_h -avfoundation_indev_extralibs=-framework CoreVideo -framework Foundation -framework AVFoundation -framework CoreMedia -framework CoreGraphics +avfoundation_indev_extralibs=-framework CoreVideo -framework Foundation -framework AVFoundation -framework CoreMedia avfoundation_indev_select=avfoundation bktr_indev_deps_any=dev_bktr_ioctl_bt848_h machine_ioctl_bt848_h dev_video_bktr_ioctl_bt848_h dev_ic_bt8xx_h caca_outdev_deps=libcaca @@ -4868,7 +4868,10 @@ for func in $MATH_FUNCS; do done # these are off by default, so fail if requested and not available -enabled avfoundation_indev { check_header_oc AVFoundation/AVFoundation.h || disable avfoundation_indev; } +enabled avfoundation_indev check_header_oc AVFoundation/AVFoundation.h +{ check_lib2 CoreGraphics/CoreGraphics.h CGImageGetTypeID -Wl,-framework,CoreGraphics || + check_lib2 ApplicationServices/ApplicationServices.h CGImageGetTypeID -Wl,-framework,ApplicationServices || + disable avfoundation_indev; } enabled avisynth { { check_lib2 windows.h LoadLibrary; } || { check_lib2 dlfcn.h dlopen -ldl; } || die ERROR: LoadLibrary/dlopen not found for avisynth; } -- 1.9.3 (Apple Git-50) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel