Re: [FFmpeg-devel] [PATCH] ffserver_config: check for INT_MIN before doing FFABS

2015-10-13 Thread Ganesh Ajjanagadde 
On Tue, Oct 13, 2015 at 3:45 PM, Michael Niedermayer
 wrote:
> On Fri, Oct 09, 2015 at 11:31:22AM -0400, Ganesh Ajjanagadde wrote:
>> FFABS(INT_MIN) is not safe. Alternative of using FFNABS is not as
>> readable.
>>
>> Signed-off-by: Ganesh Ajjanagadde 
>> ---
>>  ffserver_config.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> LGTM
>
> thanks

pushed, thanks.

>
> [...]
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> There will always be a question for which you do not know the correct answer.
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] ffserver_config: check for INT_MIN before doing FFABS

2015-10-13 Thread Michael Niedermayer 
On Fri, Oct 09, 2015 at 11:31:22AM -0400, Ganesh Ajjanagadde wrote:
> FFABS(INT_MIN) is not safe. Alternative of using FFNABS is not as
> readable.
> 
> Signed-off-by: Ganesh Ajjanagadde 
> ---
>  ffserver_config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM

thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] ffserver_config: check for INT_MIN before doing FFABS

2015-10-12 Thread Ganesh Ajjanagadde 
On Fri, Oct 9, 2015 at 11:31 AM, Ganesh Ajjanagadde
 wrote:
> FFABS(INT_MIN) is not safe. Alternative of using FFNABS is not as
> readable.
>
> Signed-off-by: Ganesh Ajjanagadde 
> ---
>  ffserver_config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ffserver_config.c b/ffserver_config.c
> index 691ff7b..9fc1f00 100644
> --- a/ffserver_config.c
> +++ b/ffserver_config.c
> @@ -460,7 +460,7 @@ static int ffserver_set_int_param(int *dest, const char 
> *value, int factor,
>  if (tmp < min || tmp > max)
>  goto error;
>  if (factor) {
> -if (FFABS(tmp) > INT_MAX / FFABS(factor))
> +if (tmp == INT_MIN || FFABS(tmp) > INT_MAX / FFABS(factor))
>  goto error;
>  tmp *= factor;
>  }
> --
> 2.6.1
>

ping
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] ffserver_config: check for INT_MIN before doing FFABS

2015-10-09 Thread Ganesh Ajjanagadde 
FFABS(INT_MIN) is not safe. Alternative of using FFNABS is not as
readable.

Signed-off-by: Ganesh Ajjanagadde 
---
 ffserver_config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ffserver_config.c b/ffserver_config.c
index 691ff7b..9fc1f00 100644
--- a/ffserver_config.c
+++ b/ffserver_config.c
@@ -460,7 +460,7 @@ static int ffserver_set_int_param(int *dest, const char 
*value, int factor,
 if (tmp < min || tmp > max)
 goto error;
 if (factor) {
-if (FFABS(tmp) > INT_MAX / FFABS(factor))
+if (tmp == INT_MIN || FFABS(tmp) > INT_MAX / FFABS(factor))
 goto error;
 tmp *= factor;
 }
-- 
2.6.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel