Re: [FFmpeg-devel] [PATCH] h2645_parse: Fix loglevel for NAL header parsing

2019-03-18 Thread Michael Niedermayer 
On Mon, Mar 18, 2019 at 07:19:06PM +, Derek Buitenhuis wrote:
> We don't treat this as an error.
> 
> Signed-off-by: Derek Buitenhuis 
> ---
>  libavcodec/h2645_parse.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c
> index 942f2c5d71..24658b3dfa 100644
> --- a/libavcodec/h2645_parse.c
> +++ b/libavcodec/h2645_parse.c
> @@ -499,7 +499,7 @@ int ff_h2645_packet_split(H2645Packet *pkt, const uint8_t 
> *buf, int length,
>  ret = h264_parse_nal_header(nal, logctx);
>  if (ret <= 0 || nal->size <= 0 || nal->size_bits <= 0) {
>  if (ret < 0) {
> -av_log(logctx, AV_LOG_ERROR, "Invalid NAL unit %d, 
> skipping.\n",
> +av_log(logctx, AV_LOG_WARNING, "Invalid NAL unit %d, 
> skipping.\n",
> nal->type);
>  }
>  pkt->nb_nals--;

LGTM

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] h2645_parse: Fix loglevel for NAL header parsing

2019-03-18 Thread James Almer 
On 3/18/2019 4:19 PM, Derek Buitenhuis wrote:
> We don't treat this as an error.
> 
> Signed-off-by: Derek Buitenhuis 
> ---
>  libavcodec/h2645_parse.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c
> index 942f2c5d71..24658b3dfa 100644
> --- a/libavcodec/h2645_parse.c
> +++ b/libavcodec/h2645_parse.c
> @@ -499,7 +499,7 @@ int ff_h2645_packet_split(H2645Packet *pkt, const uint8_t 
> *buf, int length,
>  ret = h264_parse_nal_header(nal, logctx);
>  if (ret <= 0 || nal->size <= 0 || nal->size_bits <= 0) {
>  if (ret < 0) {
> -av_log(logctx, AV_LOG_ERROR, "Invalid NAL unit %d, 
> skipping.\n",
> +av_log(logctx, AV_LOG_WARNING, "Invalid NAL unit %d, 
> skipping.\n",
> nal->type);
>  }
>  pkt->nb_nals--;

LGTM
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] h2645_parse: Fix loglevel for NAL header parsing

2019-03-18 Thread Derek Buitenhuis 
We don't treat this as an error.

Signed-off-by: Derek Buitenhuis 
---
 libavcodec/h2645_parse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c
index 942f2c5d71..24658b3dfa 100644
--- a/libavcodec/h2645_parse.c
+++ b/libavcodec/h2645_parse.c
@@ -499,7 +499,7 @@ int ff_h2645_packet_split(H2645Packet *pkt, const uint8_t 
*buf, int length,
 ret = h264_parse_nal_header(nal, logctx);
 if (ret <= 0 || nal->size <= 0 || nal->size_bits <= 0) {
 if (ret < 0) {
-av_log(logctx, AV_LOG_ERROR, "Invalid NAL unit %d, 
skipping.\n",
+av_log(logctx, AV_LOG_WARNING, "Invalid NAL unit %d, 
skipping.\n",
nal->type);
 }
 pkt->nb_nals--;
-- 
2.20.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel