Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
On Sat, 2022-11-26 at 02:54 +, Soft Works wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > James Almer > > Sent: Saturday, November 26, 2022 3:36 AM > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support > > P010 format > > > > On 11/25/2022 11:31 PM, Soft Works wrote: > > > > > > > -Original Message- > > > > From: ffmpeg-devel On Behalf Of > > > > James Almer > > > > Sent: Saturday, November 26, 2022 2:01 AM > > > > To: ffmpeg-devel@ffmpeg.org > > > > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't > > support > > > > P010 format > > > > > > > > On 11/25/2022 9:58 PM, Soft Works wrote: > > > > > > > > > > > -Original Message----- > > > > > > From: ffmpeg-devel On Behalf > > Of > > > > > > James Almer > > > > > > Sent: Saturday, November 26, 2022 12:58 AM > > > > > > To: ffmpeg-devel@ffmpeg.org > > > > > > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't > > > > support > > > > > > P010 format > > > > > > > > > > > > On 11/25/2022 8:51 PM, Soft Works wrote: > > > > > > > > > > > > > > > -Original Message- > > > > > > > > From: ffmpeg-devel On Behalf > > > > Of > > > > > > > > James Almer > > > > > > > > Sent: Saturday, November 26, 2022 12:35 AM > > > > > > > > To: ffmpeg-devel@ffmpeg.org > > > > > > > > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't > > > > > > support > > > > > > > > P010 format > > > > > > > > > > > > > > > > On 11/25/2022 8:26 PM, Dong, Ruijing wrote: > > > > > > > > > [AMD Official Use Only - General] > > > > > > > > > > > > > > > > > > Will it make sense to accept P010 input, however encode to > > h264 > > > > > > > > 8bit? > > > > > > > > > > > > > > > > If it works (the encoder accepts the 10 bit input even if it > > > > > > encodes > > > > > > > > it > > > > > > > > as 8bit), then i don't see why not. I assume it would also be > > > > > > faster > > > > > > > > than using swscale to convert said 10bit input to nv12 before > > > > > > passing > > > > > > > > that to the encoder. > > > > > > > > > > > > > > > > Removing support for a pixel format as input in an encoder > > needs > > > > a > > > > > > > > reason other than "It's rarely used", more so when it's a > > single > > > > > > > > line. > > > > > > > > It either needs to not work, or somehow get in the way of > > > > further > > > > > > > > improvements. > > > > > > > > > > > > > > Oh sorry, I noticed that there was a misunderstanding. > > > > > > > > > > > > > > When I said "It's rarely used", I didn't mean that as a > > > > > > justification > > > > > > > for the removal, it was meant as an explanation why none of the > > > > > > > hwaccels has implemented it. > > > > > > > > > > > > > > softworkz > > > > > > > > > > > > Alright, then i'll repeat my question: Does it work? > > > > > > > > > > No. > > > > > > > > What does this encoder currently do when you feed it p010 input? > > What > > > > does it output? > > > > > > An error: > > > > > > > > > 1. 10bit from HW context: > > > > > > > > > [graph 0 video input from stream 0:0 @ 01dc301aeec0] w:3840 > > h:2160 pixfmt:yuv420p10le tb:1/6 fr:6/1001 sar:1/1 > > > [auto_scale_0 @ 01dc2362a700] w:iw h:ih flags:'' interl:0 > > > [hwupload@f1 @ 01dc2944ef00] auto-inserting filter > > 'auto_scale_0' between the filter 'graph 0 video input from stream > > 0:0' and the filter 'hwup
Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Saturday, November 26, 2022 3:36 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support > P010 format > > On 11/25/2022 11:31 PM, Soft Works wrote: > > > > > >> -Original Message- > >> From: ffmpeg-devel On Behalf Of > >> James Almer > >> Sent: Saturday, November 26, 2022 2:01 AM > >> To: ffmpeg-devel@ffmpeg.org > >> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't > support > >> P010 format > >> > >> On 11/25/2022 9:58 PM, Soft Works wrote: > >>> > >>> > >>>> -Original Message- > >>>> From: ffmpeg-devel On Behalf > Of > >>>> James Almer > >>>> Sent: Saturday, November 26, 2022 12:58 AM > >>>> To: ffmpeg-devel@ffmpeg.org > >>>> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't > >> support > >>>> P010 format > >>>> > >>>> On 11/25/2022 8:51 PM, Soft Works wrote: > >>>>> > >>>>> > >>>>>> -Original Message- > >>>>>> From: ffmpeg-devel On Behalf > >> Of > >>>>>> James Almer > >>>>>> Sent: Saturday, November 26, 2022 12:35 AM > >>>>>> To: ffmpeg-devel@ffmpeg.org > >>>>>> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't > >>>> support > >>>>>> P010 format > >>>>>> > >>>>>> On 11/25/2022 8:26 PM, Dong, Ruijing wrote: > >>>>>>> [AMD Official Use Only - General] > >>>>>>> > >>>>>>> Will it make sense to accept P010 input, however encode to > h264 > >>>>>> 8bit? > >>>>>> > >>>>>> If it works (the encoder accepts the 10 bit input even if it > >>>> encodes > >>>>>> it > >>>>>> as 8bit), then i don't see why not. I assume it would also be > >>>> faster > >>>>>> than using swscale to convert said 10bit input to nv12 before > >>>> passing > >>>>>> that to the encoder. > >>>>>> > >>>>>> Removing support for a pixel format as input in an encoder > needs > >> a > >>>>>> reason other than "It's rarely used", more so when it's a > single > >>>>>> line. > >>>>>> It either needs to not work, or somehow get in the way of > >> further > >>>>>> improvements. > >>>>> > >>>>> Oh sorry, I noticed that there was a misunderstanding. > >>>>> > >>>>> When I said "It's rarely used", I didn't mean that as a > >>>> justification > >>>>> for the removal, it was meant as an explanation why none of the > >>>>> hwaccels has implemented it. > >>>>> > >>>>> softworkz > >>>> > >>>> Alright, then i'll repeat my question: Does it work? > >>> > >>> No. > >> > >> What does this encoder currently do when you feed it p010 input? > What > >> does it output? > > > > An error: > > > > > > 1. 10bit from HW context: > > > > > > [graph 0 video input from stream 0:0 @ 01dc301aeec0] w:3840 > h:2160 pixfmt:yuv420p10le tb:1/6 fr:6/1001 sar:1/1 > > [auto_scale_0 @ 01dc2362a700] w:iw h:ih flags:'' interl:0 > > [hwupload@f1 @ 01dc2944ef00] auto-inserting filter > 'auto_scale_0' between the filter 'graph 0 video input from stream > 0:0' and the filter 'hwupload@f1' > > [auto_scale_0 @ 01dc2362a700] w:3840 h:2160 fmt:yuv420p10le > sar:1/1 -> w:3840 h:2160 fmt:p010le sar:1/1 flags:0x0 > > [AVHWDeviceContext @ 01dc444f9a00] D3D11 Init > > [AVHWDeviceContext @ 01dc444fab80] D3D11 Init > > [vpp_qsv@f2 @ 01dc22a3d880] VPP: input is video memory surface > > [vpp_qsv@f2 @ 01dc22a3d880] VPP: output is video memory surface > > [auto_scale_0 @ 01dc2362a700] w:3840 h:2160 fmt:yuv420p10le > sar:1/1 -> w:3840 h:2160 fmt:p010le sar:1/1 flags:0x0 > > Last message repeated 2 times > > [h264_qsv @ 01dc161b6040] Using input frames context (format > qsv) with h264_qsv encoder. > > [h264_qsv @ 01dc161
Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
On 11/25/2022 11:31 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Saturday, November 26, 2022 2:01 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format On 11/25/2022 9:58 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Saturday, November 26, 2022 12:58 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format On 11/25/2022 8:51 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Saturday, November 26, 2022 12:35 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format On 11/25/2022 8:26 PM, Dong, Ruijing wrote: [AMD Official Use Only - General] Will it make sense to accept P010 input, however encode to h264 8bit? If it works (the encoder accepts the 10 bit input even if it encodes it as 8bit), then i don't see why not. I assume it would also be faster than using swscale to convert said 10bit input to nv12 before passing that to the encoder. Removing support for a pixel format as input in an encoder needs a reason other than "It's rarely used", more so when it's a single line. It either needs to not work, or somehow get in the way of further improvements. Oh sorry, I noticed that there was a misunderstanding. When I said "It's rarely used", I didn't mean that as a justification for the removal, it was meant as an explanation why none of the hwaccels has implemented it. softworkz Alright, then i'll repeat my question: Does it work? No. What does this encoder currently do when you feed it p010 input? What does it output? An error: 1. 10bit from HW context: [graph 0 video input from stream 0:0 @ 01dc301aeec0] w:3840 h:2160 pixfmt:yuv420p10le tb:1/6 fr:6/1001 sar:1/1 [auto_scale_0 @ 01dc2362a700] w:iw h:ih flags:'' interl:0 [hwupload@f1 @ 01dc2944ef00] auto-inserting filter 'auto_scale_0' between the filter 'graph 0 video input from stream 0:0' and the filter 'hwupload@f1' [auto_scale_0 @ 01dc2362a700] w:3840 h:2160 fmt:yuv420p10le sar:1/1 -> w:3840 h:2160 fmt:p010le sar:1/1 flags:0x0 [AVHWDeviceContext @ 01dc444f9a00] D3D11 Init [AVHWDeviceContext @ 01dc444fab80] D3D11 Init [vpp_qsv@f2 @ 01dc22a3d880] VPP: input is video memory surface [vpp_qsv@f2 @ 01dc22a3d880] VPP: output is video memory surface [auto_scale_0 @ 01dc2362a700] w:3840 h:2160 fmt:yuv420p10le sar:1/1 -> w:3840 h:2160 fmt:p010le sar:1/1 flags:0x0 Last message repeated 2 times [h264_qsv @ 01dc161b6040] Using input frames context (format qsv) with h264_qsv encoder. [h264_qsv @ 01dc161b6040] Encoder: input is video memory surface [h264_qsv @ 01dc161b6040] Using the average variable bitrate (AVBR) ratecontrol method [h264_qsv @ 01dc161b6040] Current pixel format is unsupported [h264_qsv @ 01dc161b6040] some encoding parameters are not supported by the QSV runtime. Please double check the input parameters. Error initializing output stream 0:0 -- Error while opening encoder for output stream #0:0 - maybe incorrect parameters such as bit_rate, rate, width or height [AVHWDeviceContext @ 01dc444f9a00] D3D11 Uninit [AVIOContext @ 01dc16197c80] Statistics: 0 bytes written, 0 seeks, 0 writeouts [AVHWDeviceContext @ 01dc444fab80] D3D11 Uninit [AVIOContext @ 01dc161839c0] Statistics: 131146 bytes read, 2 seeks Conversion failed! 2. 10bit from SW context: [graph 0 video input from stream 0:0 @ 019e915dee00] w:3840 h:2160 pixfmt:yuv420p10le tb:1/6 fr:6/1001 sar:1/1 [auto_scale_0 @ 019ee99936c0] w:iw h:ih flags:'' interl:0 [format @ 019ee9993240] auto-inserting filter 'auto_scale_0' between the filter 'Parsed_null_0' and the filter 'format' [auto_scale_0 @ 019ee99936c0] w:3840 h:2160 fmt:yuv420p10le sar:1/1 -> w:3840 h:2160 fmt:p010le sar:1/1 flags:0x0 Last message repeated 3 times [h264_qsv @ 019ee9995dc0] Using device qd1 (type qsv) with h264_qsv encoder. [h264_qsv @ 019ee9995dc0] Encoder: input is system memory surface [h264_qsv @ 019ee9995dc0] Using the average variable bitrate (AVBR) ratecontrol method [h264_qsv @ 019ee9995dc0] Current pixel format is unsupported [h264_qsv @ 019ee9995dc0] some encoding parameters are not supported by the QSV runtime. Please double check the input parameters. Error initializing output stream 0:0 -- Error while opening encoder for output stream #0:0 - maybe incorrect parameters such as bit_rate, rate, width or height [AVIOContext @ 019ef62b4000] Statistics: 0 bytes written, 0 seeks, 0 writeouts [AVIOContext @ 019ee995abc0] Statistics: 131146 bytes read, 2 seeks Conversion failed! softworkz Alright, thanks for testing it. The commit message should mention the pixel fo
Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Saturday, November 26, 2022 2:01 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support > P010 format > > On 11/25/2022 9:58 PM, Soft Works wrote: > > > > > >> -Original Message- > >> From: ffmpeg-devel On Behalf Of > >> James Almer > >> Sent: Saturday, November 26, 2022 12:58 AM > >> To: ffmpeg-devel@ffmpeg.org > >> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't > support > >> P010 format > >> > >> On 11/25/2022 8:51 PM, Soft Works wrote: > >>> > >>> > >>>> -Original Message- > >>>> From: ffmpeg-devel On Behalf > Of > >>>> James Almer > >>>> Sent: Saturday, November 26, 2022 12:35 AM > >>>> To: ffmpeg-devel@ffmpeg.org > >>>> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't > >> support > >>>> P010 format > >>>> > >>>> On 11/25/2022 8:26 PM, Dong, Ruijing wrote: > >>>>> [AMD Official Use Only - General] > >>>>> > >>>>> Will it make sense to accept P010 input, however encode to h264 > >>>> 8bit? > >>>> > >>>> If it works (the encoder accepts the 10 bit input even if it > >> encodes > >>>> it > >>>> as 8bit), then i don't see why not. I assume it would also be > >> faster > >>>> than using swscale to convert said 10bit input to nv12 before > >> passing > >>>> that to the encoder. > >>>> > >>>> Removing support for a pixel format as input in an encoder needs > a > >>>> reason other than "It's rarely used", more so when it's a single > >>>> line. > >>>> It either needs to not work, or somehow get in the way of > further > >>>> improvements. > >>> > >>> Oh sorry, I noticed that there was a misunderstanding. > >>> > >>> When I said "It's rarely used", I didn't mean that as a > >> justification > >>> for the removal, it was meant as an explanation why none of the > >>> hwaccels has implemented it. > >>> > >>> softworkz > >> > >> Alright, then i'll repeat my question: Does it work? > > > > No. > > What does this encoder currently do when you feed it p010 input? What > does it output? An error: 1. 10bit from HW context: [graph 0 video input from stream 0:0 @ 01dc301aeec0] w:3840 h:2160 pixfmt:yuv420p10le tb:1/6 fr:6/1001 sar:1/1 [auto_scale_0 @ 01dc2362a700] w:iw h:ih flags:'' interl:0 [hwupload@f1 @ 01dc2944ef00] auto-inserting filter 'auto_scale_0' between the filter 'graph 0 video input from stream 0:0' and the filter 'hwupload@f1' [auto_scale_0 @ 01dc2362a700] w:3840 h:2160 fmt:yuv420p10le sar:1/1 -> w:3840 h:2160 fmt:p010le sar:1/1 flags:0x0 [AVHWDeviceContext @ 01dc444f9a00] D3D11 Init [AVHWDeviceContext @ 01dc444fab80] D3D11 Init [vpp_qsv@f2 @ 01dc22a3d880] VPP: input is video memory surface [vpp_qsv@f2 @ 01dc22a3d880] VPP: output is video memory surface [auto_scale_0 @ 01dc2362a700] w:3840 h:2160 fmt:yuv420p10le sar:1/1 -> w:3840 h:2160 fmt:p010le sar:1/1 flags:0x0 Last message repeated 2 times [h264_qsv @ 01dc161b6040] Using input frames context (format qsv) with h264_qsv encoder. [h264_qsv @ 01dc161b6040] Encoder: input is video memory surface [h264_qsv @ 01dc161b6040] Using the average variable bitrate (AVBR) ratecontrol method [h264_qsv @ 01dc161b6040] Current pixel format is unsupported [h264_qsv @ 01dc161b6040] some encoding parameters are not supported by the QSV runtime. Please double check the input parameters. Error initializing output stream 0:0 -- Error while opening encoder for output stream #0:0 - maybe incorrect parameters such as bit_rate, rate, width or height [AVHWDeviceContext @ 01dc444f9a00] D3D11 Uninit [AVIOContext @ 01dc16197c80] Statistics: 0 bytes written, 0 seeks, 0 writeouts [AVHWDeviceContext @ 01dc444fab80] D3D11 Uninit [AVIOContext @ 01dc161839c0] Statistics: 131146 bytes read, 2 seeks Conversion failed! 2. 10bit from SW context: [graph 0 video input from stream 0:0 @ 019e915dee00] w:3840 h:2160 pixfmt:yuv420p10le tb:1/6 fr:6/1001 sar:1/1 [auto_scale_0 @ 019ee99936c0] w:iw h:ih flags:'' interl:0 [format @ 019ee9993240] auto-inserting filter 'auto_scale_0' between the filter 'Parsed_null_0' and the filter 'format' [auto_scale_0 @ 019ee
Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
On 11/25/2022 9:58 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Saturday, November 26, 2022 12:58 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format On 11/25/2022 8:51 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Saturday, November 26, 2022 12:35 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format On 11/25/2022 8:26 PM, Dong, Ruijing wrote: [AMD Official Use Only - General] Will it make sense to accept P010 input, however encode to h264 8bit? If it works (the encoder accepts the 10 bit input even if it encodes it as 8bit), then i don't see why not. I assume it would also be faster than using swscale to convert said 10bit input to nv12 before passing that to the encoder. Removing support for a pixel format as input in an encoder needs a reason other than "It's rarely used", more so when it's a single line. It either needs to not work, or somehow get in the way of further improvements. Oh sorry, I noticed that there was a misunderstanding. When I said "It's rarely used", I didn't mean that as a justification for the removal, it was meant as an explanation why none of the hwaccels has implemented it. softworkz Alright, then i'll repeat my question: Does it work? No. What does this encoder currently do when you feed it p010 input? What does it output? If it does not, then that should have been mentioned in the patch as the reason why this is being done. For me it was clear, albeit a bit short. Anyway, I'll let Haihao, respond. Best, softworkz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Saturday, November 26, 2022 12:58 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support > P010 format > > On 11/25/2022 8:51 PM, Soft Works wrote: > > > > > >> -Original Message- > >> From: ffmpeg-devel On Behalf Of > >> James Almer > >> Sent: Saturday, November 26, 2022 12:35 AM > >> To: ffmpeg-devel@ffmpeg.org > >> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't > support > >> P010 format > >> > >> On 11/25/2022 8:26 PM, Dong, Ruijing wrote: > >>> [AMD Official Use Only - General] > >>> > >>> Will it make sense to accept P010 input, however encode to h264 > >> 8bit? > >> > >> If it works (the encoder accepts the 10 bit input even if it > encodes > >> it > >> as 8bit), then i don't see why not. I assume it would also be > faster > >> than using swscale to convert said 10bit input to nv12 before > passing > >> that to the encoder. > >> > >> Removing support for a pixel format as input in an encoder needs a > >> reason other than "It's rarely used", more so when it's a single > >> line. > >> It either needs to not work, or somehow get in the way of further > >> improvements. > > > > Oh sorry, I noticed that there was a misunderstanding. > > > > When I said "It's rarely used", I didn't mean that as a > justification > > for the removal, it was meant as an explanation why none of the > > hwaccels has implemented it. > > > > softworkz > > Alright, then i'll repeat my question: Does it work? No. > If it does > not, > then that should have been mentioned in the patch as the reason why > this > is being done. For me it was clear, albeit a bit short. Anyway, I'll let Haihao, respond. Best, softworkz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
On 11/25/2022 8:51 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Saturday, November 26, 2022 12:35 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format On 11/25/2022 8:26 PM, Dong, Ruijing wrote: [AMD Official Use Only - General] Will it make sense to accept P010 input, however encode to h264 8bit? If it works (the encoder accepts the 10 bit input even if it encodes it as 8bit), then i don't see why not. I assume it would also be faster than using swscale to convert said 10bit input to nv12 before passing that to the encoder. Removing support for a pixel format as input in an encoder needs a reason other than "It's rarely used", more so when it's a single line. It either needs to not work, or somehow get in the way of further improvements. Oh sorry, I noticed that there was a misunderstanding. When I said "It's rarely used", I didn't mean that as a justification for the removal, it was meant as an explanation why none of the hwaccels has implemented it. softworkz Alright, then i'll repeat my question: Does it work? And I don't mean the encoder outputting a 10bit h264 stream, since you made it clear it doesn't, i mean accepting 10bit input in p010 pixel format and outputting a valid stream and not garbage. If it does, then there's no reason to remove this line. If it does not, then that should have been mentioned in the patch as the reason why this is being done. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Saturday, November 26, 2022 12:35 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support > P010 format > > On 11/25/2022 8:26 PM, Dong, Ruijing wrote: > > [AMD Official Use Only - General] > > > > Will it make sense to accept P010 input, however encode to h264 > 8bit? > > If it works (the encoder accepts the 10 bit input even if it encodes > it > as 8bit), then i don't see why not. I assume it would also be faster > than using swscale to convert said 10bit input to nv12 before passing > that to the encoder. > > Removing support for a pixel format as input in an encoder needs a > reason other than "It's rarely used", more so when it's a single > line. > It either needs to not work, or somehow get in the way of further > improvements. Oh sorry, I noticed that there was a misunderstanding. When I said "It's rarely used", I didn't mean that as a justification for the removal, it was meant as an explanation why none of the hwaccels has implemented it. softworkz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Saturday, November 26, 2022 12:25 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support > P010 format > > On 11/25/2022 8:20 PM, Soft Works wrote: > > > > > >> -Original Message- > >> From: ffmpeg-devel On Behalf Of > >> James Almer > >> Sent: Friday, November 25, 2022 8:48 PM > >> To: ffmpeg-devel@ffmpeg.org > >> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't > support > >> P010 format > >> > >> On 11/25/2022 3:03 PM, Soft Works wrote: > >>> > >>> > >>>> -Original Message- > >>>> From: ffmpeg-devel On Behalf > Of > >>>> Anton Khirnov > >>>> Sent: Friday, November 25, 2022 2:46 PM > >>>> To: FFmpeg development discussions and patches >>>> de...@ffmpeg.org> > >>>> Cc: Haihao Xiang > >>>> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't > >> support > >>>> P010 format > >>>> > >>>> Why? > >>> > >>> It's rarely used. There's not even a hwaccel that can decode > this. > >> > >> The dxva2/d3d11 hwaccels seemingly do > > > > No, only for HEVC and VP9. Probably for AV1 as well in the near > future. > > Well, then that is a good reason to not remove support in this > encoder > for a pixel format that not only our software scaler can generate, > but > decoders using hwaccel backends can output too. That would be right when QSV would support it, but it doesn't, neither for decoding nor for encoding and there are no plans to implement it. I know this, because I had checked back with Intel on it, as I had been wondering about the existence of the MFX_PROFILE_AVC_HIGH10 constant, which is the profile for H.264 10bit encoding. It existed because an earlier version of MSDK had supported this, but only with their software implementations of H.264, never with HWA. And unlikely with ffmpeg as that constant has never been used there. Nvidia doesn't support it either. Neither decoding nor encoding. They don't even have a GUID constant mapping for the profile. https://www.ffmpeg.org/doxygen/3.2/nvEncodeAPI_8h_source.html (Line 151-) Best wishes, softworkz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
[AMD Official Use Only - General] We would like to add that in Mesa first to let vaapi path accept 10bit input and HW to convert it to 8bit if it makes sense to do so. Then get a chance to apply it to ffmpeg. Thanks Ruijing -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Friday, November 25, 2022 6:35 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format On 11/25/2022 8:26 PM, Dong, Ruijing wrote: > [AMD Official Use Only - General] > > Will it make sense to accept P010 input, however encode to h264 8bit? If it works (the encoder accepts the 10 bit input even if it encodes it as 8bit), then i don't see why not. I assume it would also be faster than using swscale to convert said 10bit input to nv12 before passing that to the encoder. Removing support for a pixel format as input in an encoder needs a reason other than "It's rarely used", more so when it's a single line. It either needs to not work, or somehow get in the way of further improvements. > > Thanks, > Ruijing > > -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Friday, November 25, 2022 6:25 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support > P010 format > > On 11/25/2022 8:20 PM, Soft Works wrote: >> >> >>> -Original Message- >>> From: ffmpeg-devel On Behalf Of >>> James Almer >>> Sent: Friday, November 25, 2022 8:48 PM >>> To: ffmpeg-devel@ffmpeg.org >>> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support >>> P010 format >>> >>> On 11/25/2022 3:03 PM, Soft Works wrote: >>>> >>>> >>>>> -Original Message- >>>>> From: ffmpeg-devel On Behalf Of >>>>> Anton Khirnov >>>>> Sent: Friday, November 25, 2022 2:46 PM >>>>> To: FFmpeg development discussions and patches >>>> de...@ffmpeg.org> >>>>> Cc: Haihao Xiang >>>>> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't >>> support >>>>> P010 format >>>>> >>>>> Why? >>>> >>>> It's rarely used. There's not even a hwaccel that can decode this. >>> >>> The dxva2/d3d11 hwaccels seemingly do >> >> No, only for HEVC and VP9. Probably for AV1 as well in the near future. > > Well, then that is a good reason to not remove support in this encoder for a > pixel format that not only our software scaler can generate, but decoders > using hwaccel backends can output too. > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fffmp > eg.org%2Fmailman%2Flistinfo%2Fffmpeg-develdata=05%7C01%7Cruijing. > dong%40amd.com%7Cbcfc4e8b332b4a42691908dacf3d87e7%7C3dd8961fe4884e608e > 11a82d994e183d%7C0%7C0%7C638050160442866421%7CUnknown%7CTWFpbGZsb3d8ey > JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300 > 0%7C%7C%7Csdata=8UN5OD1Yt2fmSkiHi4cLtnDryBlwpa8DF4Oi%2FMhjxPk%3D& > amp;reserved=0 > > To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org > with subject "unsubscribe". > > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fffmp > eg.org%2Fmailman%2Flistinfo%2Fffmpeg-develdata=05%7C01%7Cruijing. > dong%40amd.com%7Cbcfc4e8b332b4a42691908dacf3d87e7%7C3dd8961fe4884e608e > 11a82d994e183d%7C0%7C0%7C638050160442866421%7CUnknown%7CTWFpbGZsb3d8ey > JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300 > 0%7C%7C%7Csdata=8UN5OD1Yt2fmSkiHi4cLtnDryBlwpa8DF4Oi%2FMhjxPk%3D& > amp;reserved=0 > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmpeg-develdata=05%7C01%7Cruijing.dong%40amd.com%7Cbcfc4e8b332b4a42691908dacf3d87e7%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638050160442866421%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=8UN5OD1Yt2fmSkiHi4cLtnDryBlwpa8DF4Oi%2FMhjxPk%3Dreserved=0 To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". <>___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
On 11/25/2022 8:26 PM, Dong, Ruijing wrote: [AMD Official Use Only - General] Will it make sense to accept P010 input, however encode to h264 8bit? If it works (the encoder accepts the 10 bit input even if it encodes it as 8bit), then i don't see why not. I assume it would also be faster than using swscale to convert said 10bit input to nv12 before passing that to the encoder. Removing support for a pixel format as input in an encoder needs a reason other than "It's rarely used", more so when it's a single line. It either needs to not work, or somehow get in the way of further improvements. Thanks, Ruijing -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Friday, November 25, 2022 6:25 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format On 11/25/2022 8:20 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Friday, November 25, 2022 8:48 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format On 11/25/2022 3:03 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Anton Khirnov Sent: Friday, November 25, 2022 2:46 PM To: FFmpeg development discussions and patches Cc: Haihao Xiang Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format Why? It's rarely used. There's not even a hwaccel that can decode this. The dxva2/d3d11 hwaccels seemingly do No, only for HEVC and VP9. Probably for AV1 as well in the near future. Well, then that is a good reason to not remove support in this encoder for a pixel format that not only our software scaler can generate, but decoders using hwaccel backends can output too. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmpeg-develdata=05%7C01%7Cruijing.dong%40amd.com%7Cf449421fd89948ad96cc08dacf3c324b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638050154742304108%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=xFeOvsaJw%2F9BlPifrqx33Pv8GurJ1N2lVyuUYHIOClo%3Dreserved=0 To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
[AMD Official Use Only - General] Will it make sense to accept P010 input, however encode to h264 8bit? Thanks, Ruijing -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Friday, November 25, 2022 6:25 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format On 11/25/2022 8:20 PM, Soft Works wrote: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> James Almer >> Sent: Friday, November 25, 2022 8:48 PM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support >> P010 format >> >> On 11/25/2022 3:03 PM, Soft Works wrote: >>> >>> >>>> -Original Message- >>>> From: ffmpeg-devel On Behalf Of >>>> Anton Khirnov >>>> Sent: Friday, November 25, 2022 2:46 PM >>>> To: FFmpeg development discussions and patches >>> de...@ffmpeg.org> >>>> Cc: Haihao Xiang >>>> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't >> support >>>> P010 format >>>> >>>> Why? >>> >>> It's rarely used. There's not even a hwaccel that can decode this. >> >> The dxva2/d3d11 hwaccels seemingly do > > No, only for HEVC and VP9. Probably for AV1 as well in the near future. Well, then that is a good reason to not remove support in this encoder for a pixel format that not only our software scaler can generate, but decoders using hwaccel backends can output too. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmpeg-develdata=05%7C01%7Cruijing.dong%40amd.com%7Cf449421fd89948ad96cc08dacf3c324b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638050154742304108%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=xFeOvsaJw%2F9BlPifrqx33Pv8GurJ1N2lVyuUYHIOClo%3Dreserved=0 To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". <>___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
On 11/25/2022 8:20 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Friday, November 25, 2022 8:48 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format On 11/25/2022 3:03 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Anton Khirnov Sent: Friday, November 25, 2022 2:46 PM To: FFmpeg development discussions and patches Cc: Haihao Xiang Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format Why? It's rarely used. There's not even a hwaccel that can decode this. The dxva2/d3d11 hwaccels seemingly do No, only for HEVC and VP9. Probably for AV1 as well in the near future. Well, then that is a good reason to not remove support in this encoder for a pixel format that not only our software scaler can generate, but decoders using hwaccel backends can output too. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Friday, November 25, 2022 8:48 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support > P010 format > > On 11/25/2022 3:03 PM, Soft Works wrote: > > > > > >> -Original Message- > >> From: ffmpeg-devel On Behalf Of > >> Anton Khirnov > >> Sent: Friday, November 25, 2022 2:46 PM > >> To: FFmpeg development discussions and patches >> de...@ffmpeg.org> > >> Cc: Haihao Xiang > >> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't > support > >> P010 format > >> > >> Why? > > > > It's rarely used. There's not even a hwaccel that can decode this. > > The dxva2/d3d11 hwaccels seemingly do No, only for HEVC and VP9. Probably for AV1 as well in the near future. But not for H.264. Not for the 3 decoder GUIDs that ffmpeg supports.. https://www.ffmpeg.org/doxygen/5.1/dxva2_8c_source.html (Line 39-41) ...neither for any of the others which are known. I'm doing some comprehensive detection of HW capabilities, which includes enumerating DXVA2/DX11VA decoders and "render targets" (which map to color formats). I have a large collection of such detection logs and I've never seen any H.264 DXVA2/DX11VA decoder which would support 10bit decoding. Here's an example how it looks like for a system with contemporary Nvidia and Intel GPUs: "Detection Log", "Debug: Create DXGI Factory", "Debug: DXGI Factory created", "Debug: Detected 3 video adapters.", "Info: Adapter #0: 'NVIDIA Quadro RTX 4000' Id:7857 (Driver: , Vendor: 4318)", "Debug: Device successfully created", "Debug: VideoDevice successfully created", "Info: 86695f12-340e-4f04-9fd3-9253dd327460: DXVA2_ModeMPEG2and1_VLD MPEG-2 & MPEG-1 variable-length decoder - mpeg2video", "Info: ee27417f-5e28-4e65-beea-1d26b508adc9: DXVA2_ModeMPEG2_VLD MPEG-2 variable-length decoder - mpeg2video", "Info: 6f3ec719-3735-42cc-8063-65cc3cb36616: DXVA2_ModeMPEG1_VLD MPEG-1 variable-length decoder - mpeg1video", "Info: 1b81bea4-a0c7-11d3-b984-00c04f2e73c5: DXVA2_ModeVC1_D2010 VC-1 variable-length decoder (2010) - vc1", "Info: 1b81bea3-a0c7-11d3-b984-00c04f2e73c5: DXVA2_ModeVC1_D VC-1 variable-length decoder - vc1", "Info: 32fcfe3f-de46-4a49-861b-ac71110649d5: - ", "Info: d79be8da-0cf1-4c81-b82a-69a4e236f43d: DXVA2_ModeH264_VLD_Stereo_Progressive_NoFGT H.264 MVC variable-length decoder, stereo, progressive - h264", "Info: f9aaccbb-c2b6-4cfc-8779-5707b1760552: DXVA2_ModeH264_VLD_Stereo_NoFGT H.264 MVC variable-length decoder, stereo - h264", "Info: 1b81be68-a0c7-11d3-b984-00c04f2e73c5: DXVA2_ModeH264_E H.264 variable-length decoder, no film grain technology - h264", "Info: 5b11d51b-2f4c-4452-bcc3-09f2a1160cc0: DXVA2_ModeHEVC_VLD_Main H.265 variable-length decoder, Main profile - hevc", "Info: 107af0e0-ef1a-4d19-aba8-67a163073d13: DXVA2_ModeHEVC_VLD_Main10 H.265 variable-length decoder, Main 10 profile - hevc", "Info: 20bb8b0a-97aa-4571-8e99-64e60606c1a6: - ", "Info: 15df9b21-06c4-47f1-841e-a67c97d7f312: - ", "Info: efd64d74-c9e8-41d7-a5e9-e9b0e39fa319: DXVA2_ModeMPEG4pt2_VLD_Simple MPEG-4 Part 2 variable-length decoder, Simple profile - mpeg4", "Info: ed418a9f-010d-4eda-9ae3-9a65358d8d2e: DXVA2_ModeMPEG4pt2_VLD_AdvSimple_NoGMC MPEG-4 Part 2 variable-length decoder, Simple & Advanced profile, no GMC - mpeg4", "Info: 9947ec6f-689b-11dc-a320-0019dbbc4184: DXVA2_nVidia_MPEG4_ASP MPEG-4 Part 2 nVidia bitstream decoder - mpeg4", "Info: 33fcfe41-de46-4a49-861b-ac71110649d5: - ", "Info: 463707f8-a1d0-4585-876d-83aa6d60b89e: DXVA2_ModeVP9_VLD_Profile0 VP9 Profile 0 - vp9", "Info: a4c749ef-6ecf-48aa-8448-50a7a1165ff7: DXVA2_ModeVP9_VLD_10bit_Profile2 VP9 10 bit Profile 2 - vp9", "Info: dda19dc7-93b5-49f5-a9b3-2bda28a2ce6e: - ", "Info: 6affd11e-1d96-42b1-a215-93a31f09a53d: - ", "Info: 914c84a3-4078-4fa9-984c-e2f262cb5c9c: - ", "Info: 8a1a1031-29bc-46d0-a007-e9b092ca6767: - ", "Debug:DXVA2_ModeMPEG2and1_VLD - ColorFormat #0: NV12 => nv12", "Debug: Supported Resolutions: 160x120, 176x144, 320x240, 352x288, 720x480, 720x240, 720x576, 1280x720, 1920x1080, 2048x1024, 2048x1080, 3140x2160, 3680x1536, 3840x2160", "Debug: Unsupported Resolutions: 4096x2048, 4096x2160, 4096x2176, 7680x4320, 8192x4320, 8192x4352", "Debug: Max Resolution: 3840x2160", "Debug:DXVA2_ModeMPEG2and1_VLD - ColorFormat #1: Opaque420 => yuv42
Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
On 11/25/2022 3:03 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Anton Khirnov Sent: Friday, November 25, 2022 2:46 PM To: FFmpeg development discussions and patches Cc: Haihao Xiang Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format Why? It's rarely used. There's not even a hwaccel that can decode this. The dxva2/d3d11 hwaccels seemingly do, as does the qsv decoder. And being rarely used alone is not a reason to remove something. There needs to be some benefit to justify it (Simplifying maintenance, removing legacy code, etc). Also, p010 can be generated by swscale, and the only other software pixel format supported in this list is nv12, which is 8bit. If we remove p010, we would be making 10bit encodings not longer work with the output of software decoders as input, right? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
> -Original Message- > From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Friday, November 25, 2022 2:46 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Haihao Xiang > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support > P010 format > > Why? It's rarely used. There's not even a hwaccel that can decode this. softworkz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
Why? -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
From: Haihao Xiang
Signed-off-by: Haihao Xiang
---
libavcodec/qsvenc_h264.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavcodec/qsvenc_h264.c b/libavcodec/qsvenc_h264.c
index 0ff7356346..bbdedc3335 100644
--- a/libavcodec/qsvenc_h264.c
+++ b/libavcodec/qsvenc_h264.c
@@ -197,7 +197,6 @@ const FFCodec ff_h264_qsv_encoder = {
.close = qsv_enc_close,
.p.capabilities = AV_CODEC_CAP_DELAY | AV_CODEC_CAP_HYBRID,
.p.pix_fmts = (const enum AVPixelFormat[]){ AV_PIX_FMT_NV12,
-AV_PIX_FMT_P010,
AV_PIX_FMT_QSV,
AV_PIX_FMT_NONE },
.p.priv_class = ,
--
2.25.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
