Re: [FFmpeg-devel] [PATCH] libavcodec/exr: Fix blank output when data window != display window

2017-01-07 Thread Moritz Barsnick 
On Fri, Jan 06, 2017 at 18:08:44 +0100, Martin Vignali wrote:
> Did you try,all the official display/data window sample ?

I did have a look at a few selected samples, and ffmpeg doesn't seem to
handle them:

http://ffmpeg.org/pipermail/ffmpeg-user/2017-January/034831.html

I'm not sure
https://github.com/openexr/openexr-images/tree/master/DisplayWindow
is the "specification", but any EXR decoder should be able to handle
all the listed file, IIUC.

Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavcodec/exr: Fix blank output when data window != display window

2017-01-06 Thread Kevin Wheatley 
No, just this kind.

Behind the images when data = display window, the most common case
OpenEXR file we have, is with a reduced data window that resides
completely inside the display window, though this particular bug would
impact any files where the value of ymax+1 is not equal to the height.

Kevin
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavcodec/exr: Fix blank output when data window != display window

2017-01-06 Thread Paul B Mahol 
On 1/6/17, Kevin Wheatley  wrote:
> The following is a sample EXR that needs the patch to correctly
> process in FFmpeg.
>
> Kevin
>

patch applied.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavcodec/exr: Fix blank output when data window != display window

2017-01-06 Thread Martin Vignali 
Hello,

Did you try,all the official display/data window sample ?

I will try to take a look this week end.
Thanks for the sample

Martin
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavcodec/exr: Fix blank output when data window != display window

2017-01-06 Thread Kevin Wheatley 
The following is a sample EXR that needs the patch to correctly
process in FFmpeg.

Kevin
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] libavcodec/exr: Fix blank output when data window != display window

2017-01-03 Thread Kevin Wheatley 
looks like there is a bug in commit
1a08758e7c4e14a9ea8d2fef6c33ad411b2d3c40 relating to the handling of
ptr in decode_frame after decode_block is called, before this commit
ptr would have been incremented for each line in the data window, now
after the commit it is left at the start of the first included line
rather than the line after the data window then the code sets the
remaining lines to 0 and thus the whole image is over written.

Fix by adjusting ptr to the correct line after decode_block returns

Signed-off-by: Kevin Wheatley 


0001-libavcodec-exr-Fix-blank-output-when-data-window-dis.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel