Re: [FFmpeg-devel] [PATCH] libavformat/movenc: mov: added subtitle codec tags to codec tag list
On 2/25/2019 7:50 AM, Paweł Wegner wrote: > This fixes avformat_query_codec incorrectly returning 0 for > mov container and mov_text subtitles. > > Signed-off-by: Paweł Wegner > --- > libavformat/movenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 77943304b5..8969d5b170 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -6858,7 +6858,7 @@ AVOutputFormat ff_mov_muxer = { > .deinit= mov_free, > .flags = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH | > AVFMT_TS_NEGATIVE, > .codec_tag = (const AVCodecTag* const []){ > -ff_codec_movvideo_tags, ff_codec_movaudio_tags, 0 > +ff_codec_movvideo_tags, ff_codec_movaudio_tags, > ff_codec_movsubtitle_tags, 0 > }, > .check_bitstream = mov_check_bitstream, > .priv_class= _muxer_class, Applied, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] libavformat/movenc: mov: added subtitle codec tags to codec tag list
On Wed, Mar 13, 2019 at 12:08 PM Paweł Wegner wrote: > On Mon, Mar 4, 2019 at 10:52 AM Paweł Wegner > wrote: > >> On Mon, Mar 4, 2019 at 10:50 AM Paweł Wegner >> wrote: >> >>> ping >>> >>> On Mon, Feb 25, 2019 at 11:50 AM Paweł Wegner >>> wrote: >>> This fixes avformat_query_codec incorrectly returning 0 for mov container and mov_text subtitles. Signed-off-by: Paweł Wegner --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 77943304b5..8969d5b170 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -6858,7 +6858,7 @@ AVOutputFormat ff_mov_muxer = { .deinit= mov_free, .flags = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH | AVFMT_TS_NEGATIVE, .codec_tag = (const AVCodecTag* const []){ -ff_codec_movvideo_tags, ff_codec_movaudio_tags, 0 +ff_codec_movvideo_tags, ff_codec_movaudio_tags, ff_codec_movsubtitle_tags, 0 }, .check_bitstream = mov_check_bitstream, .priv_class= _muxer_class, -- 2.17.1 Sorry for top posted ping. >> > ping x2 > ping x3 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] libavformat/movenc: mov: added subtitle codec tags to codec tag list
On Mon, Mar 4, 2019 at 10:52 AM Paweł Wegner wrote: > On Mon, Mar 4, 2019 at 10:50 AM Paweł Wegner > wrote: > >> ping >> >> On Mon, Feb 25, 2019 at 11:50 AM Paweł Wegner >> wrote: >> >>> This fixes avformat_query_codec incorrectly returning 0 for >>> mov container and mov_text subtitles. >>> >>> Signed-off-by: Paweł Wegner >>> --- >>> libavformat/movenc.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c >>> index 77943304b5..8969d5b170 100644 >>> --- a/libavformat/movenc.c >>> +++ b/libavformat/movenc.c >>> @@ -6858,7 +6858,7 @@ AVOutputFormat ff_mov_muxer = { >>> .deinit= mov_free, >>> .flags = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH | >>> AVFMT_TS_NEGATIVE, >>> .codec_tag = (const AVCodecTag* const []){ >>> -ff_codec_movvideo_tags, ff_codec_movaudio_tags, 0 >>> +ff_codec_movvideo_tags, ff_codec_movaudio_tags, >>> ff_codec_movsubtitle_tags, 0 >>> }, >>> .check_bitstream = mov_check_bitstream, >>> .priv_class= _muxer_class, >>> -- >>> 2.17.1 >>> >>> Sorry for top posted ping. > ping x2 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] libavformat/movenc: mov: added subtitle codec tags to codec tag list
ping On Mon, Feb 25, 2019 at 11:50 AM Paweł Wegner wrote: > This fixes avformat_query_codec incorrectly returning 0 for > mov container and mov_text subtitles. > > Signed-off-by: Paweł Wegner > --- > libavformat/movenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 77943304b5..8969d5b170 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -6858,7 +6858,7 @@ AVOutputFormat ff_mov_muxer = { > .deinit= mov_free, > .flags = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH | > AVFMT_TS_NEGATIVE, > .codec_tag = (const AVCodecTag* const []){ > -ff_codec_movvideo_tags, ff_codec_movaudio_tags, 0 > +ff_codec_movvideo_tags, ff_codec_movaudio_tags, > ff_codec_movsubtitle_tags, 0 > }, > .check_bitstream = mov_check_bitstream, > .priv_class= _muxer_class, > -- > 2.17.1 > > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] libavformat/movenc: mov: added subtitle codec tags to codec tag list
On Mon, Mar 4, 2019 at 10:50 AM Paweł Wegner wrote: > ping > > On Mon, Feb 25, 2019 at 11:50 AM Paweł Wegner > wrote: > >> This fixes avformat_query_codec incorrectly returning 0 for >> mov container and mov_text subtitles. >> >> Signed-off-by: Paweł Wegner >> --- >> libavformat/movenc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavformat/movenc.c b/libavformat/movenc.c >> index 77943304b5..8969d5b170 100644 >> --- a/libavformat/movenc.c >> +++ b/libavformat/movenc.c >> @@ -6858,7 +6858,7 @@ AVOutputFormat ff_mov_muxer = { >> .deinit= mov_free, >> .flags = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH | >> AVFMT_TS_NEGATIVE, >> .codec_tag = (const AVCodecTag* const []){ >> -ff_codec_movvideo_tags, ff_codec_movaudio_tags, 0 >> +ff_codec_movvideo_tags, ff_codec_movaudio_tags, >> ff_codec_movsubtitle_tags, 0 >> }, >> .check_bitstream = mov_check_bitstream, >> .priv_class= _muxer_class, >> -- >> 2.17.1 >> >> Sorry for top posted ping. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH] libavformat/movenc: mov: added subtitle codec tags to codec tag list
This fixes avformat_query_codec incorrectly returning 0 for mov container and mov_text subtitles. Signed-off-by: Paweł Wegner --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 77943304b5..8969d5b170 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -6858,7 +6858,7 @@ AVOutputFormat ff_mov_muxer = { .deinit= mov_free, .flags = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH | AVFMT_TS_NEGATIVE, .codec_tag = (const AVCodecTag* const []){ -ff_codec_movvideo_tags, ff_codec_movaudio_tags, 0 +ff_codec_movvideo_tags, ff_codec_movaudio_tags, ff_codec_movsubtitle_tags, 0 }, .check_bitstream = mov_check_bitstream, .priv_class= _muxer_class, -- 2.17.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel