[FFmpeg-devel] [PATCH]Don't claim 16bit support for the noise filter

2014-10-16 Thread Carl Eugen Hoyos 
Hi!

The noise filter claims to support 16bit formats but the output looks broken:
$ ffmpeg -f lavfi -i testsrc=s=3840x2160 -vf 
format=yuv444p16le,noise=c0s=10:allf=t -vcodec mpeg4 -qscale 2 -t 1 out.mov

Attached patch removes the 16bit support, fixes ticket #4017, ticket #4029 for 
16bit support already exists.

Carl Eugen
diff --git a/libavfilter/vf_noise.c b/libavfilter/vf_noise.c
index 1028a3c..7296567 100644
--- a/libavfilter/vf_noise.c
+++ b/libavfilter/vf_noise.c
@@ -174,7 +174,7 @@ static int query_formats(AVFilterContext *ctx)
 
 for (fmt = 0; av_pix_fmt_desc_get(fmt); fmt++) {
 const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(fmt);
-if (desc-flags  AV_PIX_FMT_FLAG_PLANAR  
!((desc-comp[0].depth_minus1 + 1)  7))
+if (desc-flags  AV_PIX_FMT_FLAG_PLANAR  desc-comp[0].depth_minus1 
== 7)
 ff_add_format(formats, fmt);
 }
 
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]Don't claim 16bit support for the noise filter

2014-10-16 Thread Michael Niedermayer 
On Thu, Oct 16, 2014 at 11:57:08AM +0200, Carl Eugen Hoyos wrote:
 Hi!
 
 The noise filter claims to support 16bit formats but the output looks broken:
 $ ffmpeg -f lavfi -i testsrc=s=3840x2160 -vf 
 format=yuv444p16le,noise=c0s=10:allf=t -vcodec mpeg4 -qscale 2 -t 1 out.mov
 
 Attached patch removes the 16bit support, fixes ticket #4017, ticket #4029 
 for 
 16bit support already exists.

fixed differently

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]Don't claim 16bit support for the noise filter

2014-10-16 Thread Carl Eugen Hoyos 
Michael Niedermayer michaelni at gmx.at writes:

  Attached patch removes the 16bit support, fixes 
  ticket #4017, ticket #4029 for 16bit support 
  already exists.
 
 fixed differently

Thank you!

Carl Eugen

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel