Re: [FFmpeg-devel] [PATCH]lavc/cfhd: Drop an unused function
On 1/14/19, Carl Eugen Hoyos wrote: > 2019-01-14 17:39 GMT+01:00, Paul B Mahol : >> On 1/14/19, Carl Eugen Hoyos wrote: >>> 2018-08-23 16:00 GMT+02:00, Carl Eugen Hoyos : >>> Attached patch removes an unused function from cfhd.c. >>> >>> Ping, the function seems less needed than expected (and >>> can be resurrected anytime). > >> NACK >> >> Please refrain from pinging this patch. > > What do you suggest? Fix it properly, by reusing function obviously. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH]lavc/cfhd: Drop an unused function
2019-01-14 17:39 GMT+01:00, Paul B Mahol : > On 1/14/19, Carl Eugen Hoyos wrote: >> 2018-08-23 16:00 GMT+02:00, Carl Eugen Hoyos : >> >>> Attached patch removes an unused function from cfhd.c. >> >> Ping, the function seems less needed than expected (and >> can be resurrected anytime). > NACK > > Please refrain from pinging this patch. What do you suggest? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH]lavc/cfhd: Drop an unused function
On 1/14/19, Carl Eugen Hoyos wrote: > 2018-08-23 16:00 GMT+02:00, Carl Eugen Hoyos : > >> Attached patch removes an unused function from cfhd.c. > > Ping, the function seems less needed than expected (and > can be resurrected anytime). > > Carl Eugen > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > NACK Please refrain from pinging this patch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH]lavc/cfhd: Drop an unused function
2018-08-23 16:00 GMT+02:00, Carl Eugen Hoyos : > Attached patch removes an unused function from cfhd.c. Ping, the function seems less needed than expected (and can be resurrected anytime). Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH]lavc/cfhd: Drop an unused function
On 8/23/18, Gagandeep Singh wrote: > On Thu, Aug 23, 2018 at 7:33 PM Paul B Mahol wrote: > >> On 8/23/18, Carl Eugen Hoyos wrote: >> > Hi! >> > >> > Attached patch removes an unused function from cfhd.c. >> > >> > Please comment, Carl Eugen >> > >> >> Not acceptable. Function is needed, but was dropped due programmer's >> error. >> > I just noticed. Will add it back in the updated patch that i will work on > saturday. So, you worked out something? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH]lavc/cfhd: Drop an unused function
On 8/23/18, Carl Eugen Hoyos wrote: > Hi! > > Attached patch removes an unused function from cfhd.c. > > Please comment, Carl Eugen > Not acceptable. Function is needed, but was dropped due programmer's error. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH]lavc/cfhd: Drop an unused function
Hi!
Attached patch removes an unused function from cfhd.c.
Please comment, Carl Eugen
From 191c7baea8b820d07bbcf1ddb50ffcff8f6c6a08 Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos
Date: Thu, 23 Aug 2018 15:56:06 +0200
Subject: [PATCH] lavc/cfhd: Remove an unused function.
---
libavcodec/cfhd.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c
index 846d334..616f5af 100644
--- a/libavcodec/cfhd.c
+++ b/libavcodec/cfhd.c
@@ -136,20 +136,6 @@ static inline void peak_table(int16_t *band, Peak *peak, int length)
band[i] = bytestream2_get_le16(>base);
}
-static inline void process_alpha(int16_t *alpha, int width)
-{
-int i, channel;
-for (i = 0; i < width; i++) {
-channel = alpha[i];
-channel -= ALPHA_COMPAND_DC_OFFSET;
-channel <<= 3;
-channel *= ALPHA_COMPAND_GAIN;
-channel >>= 16;
-channel = av_clip_uintp2(channel, 12);
-alpha[i] = channel;
-}
-}
-
static inline void filter(int16_t *output, ptrdiff_t out_stride,
int16_t *low, ptrdiff_t low_stride,
int16_t *high, ptrdiff_t high_stride,
--
1.7.10.4
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
