Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

[Roger Pack]

On 12/11/15, Lou Logan  wrote:
> On Wed, 9 Dec 2015 21:24:06 +0100, Hendrik Leppkes wrote:
>
>> libvo-aacenc doesn't see any development anymore.
>> Its an encoder taken from the android sdk a long time ago, but AOSP
>> replaced it with fdk-aac, so libvo-aacenc is EOL.
>>
>> And its quality is horrible.

Maybe just output a warning message for now with their alternatives...

> We should remove the wrapper. I'm tired to telling users to use a
> different encoder–especially when they try to encode more than 2
> channels and get a non-informative error:
>
>   [libvo_aacenc @ 0x3211780] Unable to set encoding parameters

Maybe we should modify that message to be more helpful as well :)

-roger-
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

[Lou Logan]

On Wed, 9 Dec 2015 21:24:06 +0100, Hendrik Leppkes wrote:

> libvo-aacenc doesn't see any development anymore.
> Its an encoder taken from the android sdk a long time ago, but AOSP
> replaced it with fdk-aac, so libvo-aacenc is EOL.
> 
> And its quality is horrible.

We should remove the wrapper. I'm tired to telling users to use a
different encoder–especially when they try to encode more than 2
channels and get a non-informative error:

  [libvo_aacenc @ 0x3211780] Unable to set encoding parameters
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

[Carl Eugen Hoyos]

On Wednesday 09 December 2015 09:24:06 pm Hendrik Leppkes wrote:
> On Wed, Dec 9, 2015 at 7:09 PM, James Almer  wrote:
> > On 12/5/2015 9:31 PM, Carl Eugen Hoyos wrote:
> >> Hi!
> >>
> >> I prefer attached patch over removing the encoder immediately.

> And its quality is horrible.
>
> No idea why we would mark it experimental however. The built-in
> encoder will always take precedence, so a user has to explicitly
> request it as it is.

I am thinking of the many scripts using libvo-aac and the many 
users who automatically request it with -c:a whenever they encode 
aac.

I will commit in a few days if there are no objections.

Thank you, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

[Hendrik Leppkes]

On Fri, Dec 11, 2015 at 12:07 AM, Carl Eugen Hoyos  wrote:
> On Wednesday 09 December 2015 09:24:06 pm Hendrik Leppkes wrote:
>> On Wed, Dec 9, 2015 at 7:09 PM, James Almer  wrote:
>> > On 12/5/2015 9:31 PM, Carl Eugen Hoyos wrote:
>> >> Hi!
>> >>
>> >> I prefer attached patch over removing the encoder immediately.
>
>> And its quality is horrible.
>>
>> No idea why we would mark it experimental however. The built-in
>> encoder will always take precedence, so a user has to explicitly
>> request it as it is.
>
> I am thinking of the many scripts using libvo-aac and the many
> users who automatically request it with -c:a whenever they encode
> aac.
>

So you intentionally want to break all the scripts? Doesn't sound like
a good thing.

- Hendrik
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

[Carl Eugen Hoyos]

On Sunday 06 December 2015 01:31:17 am Carl Eugen Hoyos wrote:
> Hi!
>
> I prefer attached patch over removing the encoder immediately.

No opinions?

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

[Claudio Freire]

On Wed, Dec 9, 2015 at 11:15 AM, Carl Eugen Hoyos  wrote:
> On Sunday 06 December 2015 01:31:17 am Carl Eugen Hoyos wrote:
>> Hi!
>>
>> I prefer attached patch over removing the encoder immediately.
>
> No opinions?
>
> Carl Eugen


LGTM, but I don't use the libvo-aac, so... :-p
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

[James Almer]

On 12/5/2015 9:31 PM, Carl Eugen Hoyos wrote:
> Hi!
> 
> I prefer attached patch over removing the encoder immediately.
> 
> Carl Eugen

What is experimental? Our wrapper or the library?
If the latter then maybe it would be better to use a static init function
to mark the encoder as experimental after making a libvo-aac version check,
assuming a new version is good enough to not be considered experimental.

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

[Carl Eugen Hoyos]

Hi!

I prefer attached patch over removing the encoder immediately.

Carl Eugen
diff --git a/Changelog b/Changelog
index ad13d88..6555351 100644
--- a/Changelog
+++ b/Changelog
@@ -42,6 +42,7 @@ version :
 - mipsdspr1 option has been renamed to mipsdsp
 - aemphasis filter
 - mips32r5 option has been removed
+- add experimental flag to the libvo-aac encoder
 
 
 version 2.8:
diff --git a/libavcodec/libvo-aacenc.c b/libavcodec/libvo-aacenc.c
index 7f21ad2..7b983b7 100644
--- a/libavcodec/libvo-aacenc.c
+++ b/libavcodec/libvo-aacenc.c
@@ -194,7 +194,8 @@ AVCodec ff_libvo_aacenc_encoder = {
 .encode2= aac_encode_frame,
 .close  = aac_encode_close,
 .supported_samplerates = mpeg4audio_sample_rates,
-.capabilities   = AV_CODEC_CAP_SMALL_LAST_FRAME | AV_CODEC_CAP_DELAY,
+.capabilities   = AV_CODEC_CAP_SMALL_LAST_FRAME | AV_CODEC_CAP_DELAY |
+  AV_CODEC_CAP_EXPERIMENTAL,
 .sample_fmts= (const enum AVSampleFormat[]){ AV_SAMPLE_FMT_S16,
  AV_SAMPLE_FMT_NONE },
 };
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel