Re: [FFmpeg-devel] [PATCH]lsws/input: Do not define unused functions

2017-03-20 Thread Michael Niedermayer
On Mon, Mar 13, 2017 at 10:02:22AM +0100, Carl Eugen Hoyos wrote:
> 2017-03-11 13:13 GMT+01:00 Michael Niedermayer :
> > On Tue, Mar 07, 2017 at 09:30:18AM +0100, Carl Eugen Hoyos wrote:
> >> Hi!
> >>
> >> Attached patch fixes a few warnings when compiling with newer gcc.
> >>
> >> Please comment, Carl Eugen
> >
> > might be simpler t use av_unused
> 
> Do you think the code is less readable now?

doesnt matter

sorry for the late repy, i missed the mail

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH]lsws/input: Do not define unused functions

2017-03-13 Thread Carl Eugen Hoyos
2017-03-11 13:13 GMT+01:00 Michael Niedermayer :
> On Tue, Mar 07, 2017 at 09:30:18AM +0100, Carl Eugen Hoyos wrote:
>> Hi!
>>
>> Attached patch fixes a few warnings when compiling with newer gcc.
>>
>> Please comment, Carl Eugen
>
> might be simpler t use av_unused

Do you think the code is less readable now?

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH]lsws/input: Do not define unused functions

2017-03-11 Thread Michael Niedermayer
On Tue, Mar 07, 2017 at 09:30:18AM +0100, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch fixes a few warnings when compiling with newer gcc.
> 
> Please comment, Carl Eugen

might be simpler t use av_unused

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

You can kill me, but you cannot change the truth.


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH]lsws/input: Do not define unused functions

2017-03-09 Thread Carl Eugen Hoyos
2017-03-07 9:55 GMT+01:00 Paul B Mahol :
> On 3/7/17, Carl Eugen Hoyos  wrote:
>> Hi!
>>
>> Attached patch fixes a few warnings when compiling with newer gcc.
>>
>> Please comment, Carl Eugen
>>
>
> lgtm

Patch applied.

Thank you, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH]lsws/input: Do not define unused functions

2017-03-07 Thread Paul B Mahol
On 3/7/17, Carl Eugen Hoyos  wrote:
> Hi!
>
> Attached patch fixes a few warnings when compiling with newer gcc.
>
> Please comment, Carl Eugen
>

lgtm
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel