Re: [FFmpeg-devel] [PATCH 0/1] af_hdcd: Process stereo channels together, fix #5727
On Thu, Jul 28, 2016 at 12:18:01AM -0500, Burt P. wrote: > > My suggestion is that you send your public key to > > Michael and commit yourself including adding yourself > > as maintainer of hdcd. > > I don't know enough about what that would mean. I'm also not > an expert user of git. you can be maintainer and leave pushing to someone else if you feel that you dont know git well enough. What a maintainer does is "maintain" the code. Like if some other developer sends a patch, the maintainer should try to review it when he has time, if theres a bug the maintainer, author, commiter, reviewer (that is the maintainer and anyone who bears responsibility for introducing the bug) should try to fix it when they have time, The maintainer should also get reviewed patched pushed, either by pushing or pestering someone else to push you seem the most active and interrested developer for hdcd, so it would make sense for you to be the maintainer of hdcd [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerning the gods, I have no means of knowing whether they exist or not or of what sort they may be, because of the obscurity of the subject, and the brevity of human life -- Protagoras signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 0/1] af_hdcd: Process stereo channels together, fix #5727
> My suggestion is that you send your public key to > Michael and commit yourself including adding yourself > as maintainer of hdcd. I don't know enough about what that would mean. I'm also not an expert user of git. >> One strange case is John Mellencamp - [1994] Mr. Happy Go Lucky >> 06. Emotional Love, where there is one extra HDCD packet in one >> channel, and that target_gain value ends up being ignored. > > Is this a regression against the code in current git head? > Or just a (possibly) unsolved issue? This patch causes the target_gain in that packet to be ignored, where before it would not have been. This is correct, however, if you're trying to replicate HDCD decoding as described in the paper mentioned in #5727. Although, aside from being unmatched in the other channel, the packet appears completely legit. Its just a weird example where the output is different with the new code. Most of the time the two processing modes output is exactly the same. >> This patch is against master, so it also includes the changes in an >> earlier (not yet applied) patch set for HDCD detection, PE mode, >> cdt counter, and code comments. > > Please split the patches as much as it makes sense. > Those other patches have been applied today. I'll split this one up and resubmit as a set. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 0/1] af_hdcd: Process stereo channels together, fix #5727
Burt P gmail.com> writes: > For review, a fix for #5727. Please test and comment. My suggestion is that you send your public key to Michael and commit yourself including adding yourself as maintainer of hdcd. [...] > One strange case is John Mellencamp - [1994] Mr. Happy Go Lucky > 06. Emotional Love, where there is one extra HDCD packet in one > channel, and that target_gain value ends up being ignored. Is this a regression against the code in current git head? Or just a (possibly) unsolved issue? > This patch is against master, so it also includes the changes in an > earlier (not yet applied) patch set for HDCD detection, PE mode, > cdt counter, and code comments. Please split the patches as much as it makes sense. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH 0/1] af_hdcd: Process stereo channels together, fix #5727
For review, a fix for #5727. Please test and comment. I've made new versions of the processing functions that process stereo channels together so that the rule regarding target_gain can be implemented. The target_gain used for both channels will now be the last valid target_gain that matched between channels. The old single-channel functions are still there, so that testing is possible, and for compatibility with the original fb2k code. They can be used by: -af hdcd=process_stereo=0 I've tested several HDCD flac and the majority come out exactly the same using either path, but there have been a few differences where control codes do not appear at exactly the same sample, so there is a few samples of delay before they match up. One strange case is John Mellencamp - [1994] Mr. Happy Go Lucky 06. Emotional Love, where there is one extra HDCD packet in one channel, and that target_gain value ends up being ignored. This patch is against master, so it also includes the changes in an earlier (not yet applied) patch set for HDCD detection, PE mode, cdt counter, and code comments. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
