[FFmpeg-devel] [PATCH 0/1] re: Add Sega FILM muxer

2018-04-02 Thread misty 
From: Misty De Meo 

> I assume you copied the demuxer but shouldn't you be here as well?

Good point, added!

> I honestly think your comment style (i.e. C vs C++) should be consistent
> throughout the file, but that's just me.

OK, updated all the single-line comments to use the same format as the
multiline comments.

Misty De Meo (1):
  Add Sega FILM muxer

 Changelog |   1 +
 doc/general.texi  |   2 +-
 libavformat/Makefile  |   1 +
 libavformat/allformats.c  |   1 +
 libavformat/segafilmenc.c | 398 ++
 libavformat/version.h |   2 +-
 6 files changed, 403 insertions(+), 2 deletions(-)
 create mode 100644 libavformat/segafilmenc.c

-- 
2.16.3

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 0/1] re: Add Sega FILM muxer

2018-04-01 Thread misty 
From: Misty De Meo 

I've resolved the one TODO that remained by adding support for the one other
supported video codec in this container.

Is there anything else that you'd like to see changed? I understand the
concerns about this too niche, but I have been speaking to a number of other
people who would like to use this for their own projects. :) It's niche, but
it won't go unused.

Misty De Meo (1):
  Add Sega FILM muxer

 Changelog |   1 +
 doc/general.texi  |   2 +-
 libavformat/Makefile  |   1 +
 libavformat/allformats.c  |   1 +
 libavformat/segafilmenc.c | 397 ++
 libavformat/version.h |   2 +-
 6 files changed, 402 insertions(+), 2 deletions(-)
 create mode 100644 libavformat/segafilmenc.c

-- 
2.16.3

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 0/1] re: Add Sega FILM muxer

2018-03-26 Thread misty 
From: Misty De Meo 

I reviewed the contributing guide one more time, and noticed I'd missed two
items from the new muxer list. Updated the patch with:

* Marked Sega FILM as having a muxer in general.texi
* Bumped the minor version of libavformat

Misty De Meo (1):
  Add Sega FILM muxer

 Changelog |   1 +
 doc/general.texi  |   2 +-
 libavformat/Makefile  |   1 +
 libavformat/allformats.c  |   1 +
 libavformat/segafilmenc.c | 377 ++
 libavformat/version.h |   2 +-
 6 files changed, 382 insertions(+), 2 deletions(-)
 create mode 100644 libavformat/segafilmenc.c

-- 
2.16.2

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 0/1] re: Add Sega FILM muxer

2018-03-23 Thread misty 
From: Misty De Meo 

> Just move allocation after all declarations.

OK, changed.

> Do you check that this condition is set in code?
>
> I mean, if user set codec for wrong case.

Oh, good point. I thought about this, and then realized that for mono audio,
there is no difference between planar and non-planar. If the muxer only accepts
planar then it'll work in both cases and there doesn't have to be a special
check. That also matches the behaviour of the demuxer, which marks streams as
planar regardless of channel layout.

> this is set but never used

Good catch - removed. Left over from an older version of the header generation.

Misty De Meo (1):
  Add Sega FILM muxer

 Changelog |   1 +
 libavformat/Makefile  |   1 +
 libavformat/allformats.c  |   1 +
 libavformat/segafilmenc.c | 377 ++
 4 files changed, 380 insertions(+)
 create mode 100644 libavformat/segafilmenc.c

-- 
2.16.2

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel