Re: [FFmpeg-devel] [PATCH 0/5] Add SDL2 support & drop SDL1 support
2016-09-25 5:59 GMT+02:00 James Almer : > As Lukas suggested in another email, it would be a good idea > to keep using "sdl" instead of "sdl2" on things like the outdev > name and the configure option (--enable/disable-sdl). So > basically, anything an user could interact with. If this gets changed, please change it quickly. (+1) Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 0/5] Add SDL2 support & drop SDL1 support
On 9/24/2016 1:17 PM, Josh de Kock wrote: > On 22/09/2016 20:28, Josh de Kock wrote: >> Hopefully the final iteration of this set--it drops SDL1 support >> entirely rather than adding another ffplay version and keeping the >> SDL1 output device. All of it has been reviewed before, so there >> shouldn't be too much (or anything to change). >> >> Josh de Kock (3): >> lavd: Add SDL2 output device >> MAINTAINERS: update my entries >> lavd: drop SDL1 device & drop SDL1 support in general >> >> Lukasz Marek (1): >> lavd/opengl: use SDL2 >> >> Marton Balint (1): >> ffplay: add SDL2 support >> >> Changelog| 4 + >> MAINTAINERS | 1 + >> configure| 51 ++-- >> ffplay.c | 594 >> --- >> libavdevice/Makefile | 2 +- >> libavdevice/alldevices.c | 2 +- >> libavdevice/opengl_enc.c | 109 - >> libavdevice/sdl.c| 377 -- >> libavdevice/sdl2.c | 377 ++ >> 9 files changed, 702 insertions(+), 815 deletions(-) >> delete mode 100644 libavdevice/sdl.c >> create mode 100644 libavdevice/sdl2.c >> > > Set applied. > > -- > Josh As Lukas suggested in another email, it would be a good idea to keep using "sdl" instead of "sdl2" on things like the outdev name and the configure option (--enable/disable-sdl). So basically, anything an user could interact with. The configure option being dropped broke at least one of the FATE clients, and surely plenty of other scripts out there. We have afaik never for other external libraries made such changes after support for a new version was added, even if support for the old was dropped. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 0/5] Add SDL2 support & drop SDL1 support
On 24 September 2016 at 18:17, Josh de Kock wrote: > On 22/09/2016 20:28, Josh de Kock wrote: > >> Hopefully the final iteration of this set--it drops SDL1 support >> entirely rather than adding another ffplay version and keeping the >> SDL1 output device. All of it has been reviewed before, so there >> shouldn't be too much (or anything to change). >> >> Josh de Kock (3): >> lavd: Add SDL2 output device >> MAINTAINERS: update my entries >> lavd: drop SDL1 device & drop SDL1 support in general >> >> Lukasz Marek (1): >> lavd/opengl: use SDL2 >> >> Marton Balint (1): >> ffplay: add SDL2 support >> >> Changelog| 4 + >> MAINTAINERS | 1 + >> configure| 51 ++-- >> ffplay.c | 594 -- >> - >> libavdevice/Makefile | 2 +- >> libavdevice/alldevices.c | 2 +- >> libavdevice/opengl_enc.c | 109 - >> libavdevice/sdl.c| 377 -- >> libavdevice/sdl2.c | 377 ++ >> 9 files changed, 702 insertions(+), 815 deletions(-) >> delete mode 100644 libavdevice/sdl.c >> create mode 100644 libavdevice/sdl2.c >> >> > Set applied. > You ignored my review (at least part of it) regarding sdl2 device. http://ffmpeg.org/pipermail/ffmpeg-devel/2016-September/199732.html ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 0/5] Add SDL2 support & drop SDL1 support
2016-09-24 18:17 GMT+02:00 Josh de Kock : > On 22/09/2016 20:28, Josh de Kock wrote: > Set applied. Please write a short news entry for the homepage. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 0/5] Add SDL2 support & drop SDL1 support
On 22/09/2016 20:28, Josh de Kock wrote: Hopefully the final iteration of this set--it drops SDL1 support entirely rather than adding another ffplay version and keeping the SDL1 output device. All of it has been reviewed before, so there shouldn't be too much (or anything to change). Josh de Kock (3): lavd: Add SDL2 output device MAINTAINERS: update my entries lavd: drop SDL1 device & drop SDL1 support in general Lukasz Marek (1): lavd/opengl: use SDL2 Marton Balint (1): ffplay: add SDL2 support Changelog| 4 + MAINTAINERS | 1 + configure| 51 ++-- ffplay.c | 594 --- libavdevice/Makefile | 2 +- libavdevice/alldevices.c | 2 +- libavdevice/opengl_enc.c | 109 - libavdevice/sdl.c| 377 -- libavdevice/sdl2.c | 377 ++ 9 files changed, 702 insertions(+), 815 deletions(-) delete mode 100644 libavdevice/sdl.c create mode 100644 libavdevice/sdl2.c Set applied. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH 0/5] Add SDL2 support & drop SDL1 support
Hopefully the final iteration of this set--it drops SDL1 support entirely rather than adding another ffplay version and keeping the SDL1 output device. All of it has been reviewed before, so there shouldn't be too much (or anything to change). Josh de Kock (3): lavd: Add SDL2 output device MAINTAINERS: update my entries lavd: drop SDL1 device & drop SDL1 support in general Lukasz Marek (1): lavd/opengl: use SDL2 Marton Balint (1): ffplay: add SDL2 support Changelog| 4 + MAINTAINERS | 1 + configure| 51 ++-- ffplay.c | 594 --- libavdevice/Makefile | 2 +- libavdevice/alldevices.c | 2 +- libavdevice/opengl_enc.c | 109 - libavdevice/sdl.c| 377 -- libavdevice/sdl2.c | 377 ++ 9 files changed, 702 insertions(+), 815 deletions(-) delete mode 100644 libavdevice/sdl.c create mode 100644 libavdevice/sdl2.c -- 2.8.4 (Apple Git-73) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel