Re: [FFmpeg-devel] [PATCH 02/13] lavfi/vf_deshake: check fclose return value
On Tue, Jan 12, 2016 at 10:53 AM, Tobias Rapp wrote: > On 12.01.2016 05:25, Ganesh Ajjanagadde wrote: >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavfilter/vf_deshake.c | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/libavfilter/vf_deshake.c b/libavfilter/vf_deshake.c >> index e7ece44..a89506b 100644 >> --- a/libavfilter/vf_deshake.c >> +++ b/libavfilter/vf_deshake.c >> @@ -423,7 +423,10 @@ static av_cold void uninit(AVFilterContext *ctx) >> av_freep(&deshake->angles); >> deshake->angles_size = 0; >> if (deshake->fp) >> -fclose(deshake->fp); >> +if (fclose(deshake->fp)) >> +av_log(ctx, AV_LOG_WARNING, >> + "Unable to close motion search log \"%s\": %s\n", >> + deshake->filename, av_err2str(AVERROR(errno))); >> } >> >> static int filter_frame(AVFilterLink *link, AVFrame *in) >> > > Nit-pick: Maybe put the inner "if" inside braces? sure, noted. > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 02/13] lavfi/vf_deshake: check fclose return value
On 12.01.2016 05:25, Ganesh Ajjanagadde wrote: Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_deshake.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_deshake.c b/libavfilter/vf_deshake.c index e7ece44..a89506b 100644 --- a/libavfilter/vf_deshake.c +++ b/libavfilter/vf_deshake.c @@ -423,7 +423,10 @@ static av_cold void uninit(AVFilterContext *ctx) av_freep(&deshake->angles); deshake->angles_size = 0; if (deshake->fp) -fclose(deshake->fp); +if (fclose(deshake->fp)) +av_log(ctx, AV_LOG_WARNING, + "Unable to close motion search log \"%s\": %s\n", + deshake->filename, av_err2str(AVERROR(errno))); } static int filter_frame(AVFilterLink *link, AVFrame *in) Nit-pick: Maybe put the inner "if" inside braces? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 02/13] lavfi/vf_deshake: check fclose return value
On Mon, Jan 11, 2016 at 11:25:04PM -0500, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavfilter/vf_deshake.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The greatest way to live with honor in this world is to be what we pretend to be. -- Socrates signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH 02/13] lavfi/vf_deshake: check fclose return value
Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_deshake.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_deshake.c b/libavfilter/vf_deshake.c index e7ece44..a89506b 100644 --- a/libavfilter/vf_deshake.c +++ b/libavfilter/vf_deshake.c @@ -423,7 +423,10 @@ static av_cold void uninit(AVFilterContext *ctx) av_freep(&deshake->angles); deshake->angles_size = 0; if (deshake->fp) -fclose(deshake->fp); +if (fclose(deshake->fp)) +av_log(ctx, AV_LOG_WARNING, + "Unable to close motion search log \"%s\": %s\n", + deshake->filename, av_err2str(AVERROR(errno))); } static int filter_frame(AVFilterLink *link, AVFrame *in) -- 2.7.0 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
