Re: [FFmpeg-devel] [PATCH 08/11] avfilter/vf_signature: use av_strlcpy instead of strcpy

2017-06-12 Thread Michael Niedermayer 
On Sun, Jun 11, 2017 at 04:05:50PM +0200, Timo Rothenpieler wrote:
> Fixes CID 1403236
> ---
>  libavfilter/vf_signature.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/vf_signature.c b/libavfilter/vf_signature.c
> index f0078ba1a6..c20b0bfabb 100644
> --- a/libavfilter/vf_signature.c
> +++ b/libavfilter/vf_signature.c
> @@ -576,7 +576,7 @@ static int export(AVFilterContext *ctx, StreamContext 
> *sc, int input)
>  /* error already handled */
>  av_assert0(av_get_frame_filename(filename, sizeof(filename), 
> sic->filename, input) == 0);
>  } else {
> -strcpy(filename, sic->filename);
> +av_strlcpy(filename, sic->filename, sizeof(filename));

missing error handling, if its truncated
but better than before, so patch ok

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 08/11] avfilter/vf_signature: use av_strlcpy instead of strcpy

2017-06-11 Thread Timo Rothenpieler 
Fixes CID 1403236
---
 libavfilter/vf_signature.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/vf_signature.c b/libavfilter/vf_signature.c
index f0078ba1a6..c20b0bfabb 100644
--- a/libavfilter/vf_signature.c
+++ b/libavfilter/vf_signature.c
@@ -576,7 +576,7 @@ static int export(AVFilterContext *ctx, StreamContext *sc, 
int input)
 /* error already handled */
 av_assert0(av_get_frame_filename(filename, sizeof(filename), 
sic->filename, input) == 0);
 } else {
-strcpy(filename, sic->filename);
+av_strlcpy(filename, sic->filename, sizeof(filename));
 }
 if (sic->format == FORMAT_XML) {
 return xml_export(ctx, sc, filename);
-- 
2.13.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel