Re: [FFmpeg-devel] [PATCH 1/2] cmdutils: print missing caps in print_codec().

[Mark Thompson]

On 26/05/18 14:14, Jun Zhao wrote:
> print full caps type in print_codec().
> 
> Signed-off-by: Jun Zhao 
> ---
>  fftools/cmdutils.c | 10 ++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
> index 8ffc9d2..4f2e0a2 100644
> --- a/fftools/cmdutils.c
> +++ b/fftools/cmdutils.c
> @@ -1414,6 +1414,16 @@ static void print_codec(const AVCodec *c)
> AV_CODEC_CAP_SLICE_THREADS |
> AV_CODEC_CAP_AUTO_THREADS))
>  printf("threads ");
> +if (c->capabilities & AV_CODEC_CAP_AVOID_PROBING)
> +printf("avoidprob ");

I think make it "avoidprobe" or "avoidprobing"?  "prob" doesn't make it obvious 
what it's short for.

> +if (c->capabilities & AV_CODEC_CAP_INTRA_ONLY)
> +printf("intraonly ");
> + if (c->capabilities & AV_CODEC_CAP_LOSSLESS)
> +printf("lossless ");
> +if (c->capabilities & AV_CODEC_CAP_HARDWARE)
> +printf("hardware ");
> +if (c->capabilities & AV_CODEC_CAP_HYBRID)
> +printf("hybrid ");
>  if (!c->capabilities)
>  printf("none");
>  printf("\n");
> 

Otherwise looks fine.

Thanks,

- Mark
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] cmdutils: print missing caps in print_codec().

[Reto Kromer]

Jun Zhao wrote:

>print full caps type in print_codec().
>
>Signed-off-by: Jun Zhao 
>---
> fftools/cmdutils.c | 10 ++
> 1 file changed, 10 insertions(+)
>
>diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
>index 8ffc9d2..4f2e0a2 100644
>--- a/fftools/cmdutils.c
>+++ b/fftools/cmdutils.c
>@@ -1414,6 +1414,16 @@ static void print_codec(const AVCodec *c)
>AV_CODEC_CAP_SLICE_THREADS |
>AV_CODEC_CAP_AUTO_THREADS))
> printf("threads ");
>+if (c->capabilities & AV_CODEC_CAP_AVOID_PROBING)
>+printf("avoidprob ");
>+if (c->capabilities & AV_CODEC_CAP_INTRA_ONLY)
>+printf("intraonly ");
>+ if (c->capabilities & AV_CODEC_CAP_LOSSLESS)
>+printf("lossless ");

nit: alignment

>+if (c->capabilities & AV_CODEC_CAP_HARDWARE)
>+printf("hardware ");
>+if (c->capabilities & AV_CODEC_CAP_HYBRID)
>+printf("hybrid ");
> if (!c->capabilities)
> printf("none");
> printf("\n");

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/2] cmdutils: print missing caps in print_codec().

[Jun Zhao]

print full caps type in print_codec().

Signed-off-by: Jun Zhao 
---
 fftools/cmdutils.c | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
index 8ffc9d2..4f2e0a2 100644
--- a/fftools/cmdutils.c
+++ b/fftools/cmdutils.c
@@ -1414,6 +1414,16 @@ static void print_codec(const AVCodec *c)
AV_CODEC_CAP_SLICE_THREADS |
AV_CODEC_CAP_AUTO_THREADS))
 printf("threads ");
+if (c->capabilities & AV_CODEC_CAP_AVOID_PROBING)
+printf("avoidprob ");
+if (c->capabilities & AV_CODEC_CAP_INTRA_ONLY)
+printf("intraonly ");
+ if (c->capabilities & AV_CODEC_CAP_LOSSLESS)
+printf("lossless ");
+if (c->capabilities & AV_CODEC_CAP_HARDWARE)
+printf("hardware ");
+if (c->capabilities & AV_CODEC_CAP_HYBRID)
+printf("hybrid ");
 if (!c->capabilities)
 printf("none");
 printf("\n");
-- 
2.7.4

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel