Re: [FFmpeg-devel] [PATCH 1/3] dnxhddec: initialize with mb-aligned dimensions

[Michael Niedermayer]

On Thu, Oct 01, 2015 at 11:11:16PM +0200, Christophe Gisquet wrote:
> Hi,
> 
> 2015-10-01 22:34 GMT+02:00 Hendrik Leppkes :
> >> +avctx->coded_width  = FFALIGN(avctx->width, 16);
> >> +avctx->coded_height = FFALIGN(avctx->coded_height, 16);
> >
> > Intentional that this is not ->height, but ->coded_height?
> 
> Huh, yes, and the worse is it was intended to fix coded_height.
> 
> Here's an updated patch.
> 
> -- 
> Christophe

>  dnxhddec.c |3 +++
>  1 file changed, 3 insertions(+)
> eb1fc6c12568d69bc0fd161fc86c5b2acb5ae6b4  
> 0001-dnxhddec-initialize-with-mb-aligned-dimensions.patch
> From c10e86ce4469b81ac66b7fa2dd233efd191f508c Mon Sep 17 00:00:00 2001
> From: Christophe Gisquet 
> Date: Wed, 30 Sep 2015 10:14:59 +0200
> Subject: [PATCH 1/3] dnxhddec: initialize with mb-aligned dimensions
> 
> The coded size is a multiple of the macroblock size, which is 16.

applied

thanks

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] dnxhddec: initialize with mb-aligned dimensions

[Christophe Gisquet]

Hi,

2015-10-01 22:34 GMT+02:00 Hendrik Leppkes :
>> +avctx->coded_width  = FFALIGN(avctx->width, 16);
>> +avctx->coded_height = FFALIGN(avctx->coded_height, 16);
>
> Intentional that this is not ->height, but ->coded_height?

Huh, yes, and the worse is it was intended to fix coded_height.

Here's an updated patch.

-- 
Christophe
From c10e86ce4469b81ac66b7fa2dd233efd191f508c Mon Sep 17 00:00:00 2001
From: Christophe Gisquet 
Date: Wed, 30 Sep 2015 10:14:59 +0200
Subject: [PATCH 1/3] dnxhddec: initialize with mb-aligned dimensions

The coded size is a multiple of the macroblock size, which is 16.
---
 libavcodec/dnxhddec.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavcodec/dnxhddec.c b/libavcodec/dnxhddec.c
index e3dec78..755cf9a 100644
--- a/libavcodec/dnxhddec.c
+++ b/libavcodec/dnxhddec.c
@@ -87,6 +87,9 @@ static av_cold int dnxhd_decode_init(AVCodecContext *avctx)
 ctx->cid = -1;
 avctx->colorspace = AVCOL_SPC_BT709;
 
+avctx->coded_width  = FFALIGN(avctx->width,  16);
+avctx->coded_height = FFALIGN(avctx->height, 16);
+
 ctx->rows = av_mallocz_array(avctx->thread_count, sizeof(RowContext));
 if (!ctx->rows)
 return AVERROR(ENOMEM);
-- 
2.5.2

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/3] dnxhddec: initialize with mb-aligned dimensions

[Christophe Gisquet]

The coded size is a multiple of the macroblock size, which is 16.
---
 libavcodec/dnxhddec.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavcodec/dnxhddec.c b/libavcodec/dnxhddec.c
index e3dec78..3985318 100644
--- a/libavcodec/dnxhddec.c
+++ b/libavcodec/dnxhddec.c
@@ -87,6 +87,9 @@ static av_cold int dnxhd_decode_init(AVCodecContext *avctx)
 ctx->cid = -1;
 avctx->colorspace = AVCOL_SPC_BT709;
 
+avctx->coded_width  = FFALIGN(avctx->width, 16);
+avctx->coded_height = FFALIGN(avctx->coded_height, 16);
+
 ctx->rows = av_mallocz_array(avctx->thread_count, sizeof(RowContext));
 if (!ctx->rows)
 return AVERROR(ENOMEM);
-- 
2.5.2

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] dnxhddec: initialize with mb-aligned dimensions

[Hendrik Leppkes]

On Thu, Oct 1, 2015 at 10:01 PM, Christophe Gisquet
 wrote:
> The coded size is a multiple of the macroblock size, which is 16.
> ---
>  libavcodec/dnxhddec.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/libavcodec/dnxhddec.c b/libavcodec/dnxhddec.c
> index e3dec78..3985318 100644
> --- a/libavcodec/dnxhddec.c
> +++ b/libavcodec/dnxhddec.c
> @@ -87,6 +87,9 @@ static av_cold int dnxhd_decode_init(AVCodecContext *avctx)
>  ctx->cid = -1;
>  avctx->colorspace = AVCOL_SPC_BT709;
>
> +avctx->coded_width  = FFALIGN(avctx->width, 16);
> +avctx->coded_height = FFALIGN(avctx->coded_height, 16);

Intentional that this is not ->height, but ->coded_height?

> +
>  ctx->rows = av_mallocz_array(avctx->thread_count, sizeof(RowContext));
>  if (!ctx->rows)
>  return AVERROR(ENOMEM);
> --
> 2.5.2
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel