Re: [FFmpeg-devel] [PATCH 1/3] tests/audiomatch: add free to make static analysis tools happy

2020-12-10 Thread myp...@gmail.com 
On Thu, Dec 10, 2020 at 4:11 PM Anton Khirnov  wrote:
>
> Quoting Jun Zhao (2020-12-09 10:53:08)
> > From: Jun Zhao 
> >
> > Signed-off-by: Jun Zhao 
> > ---
> >  tests/audiomatch.c | 11 +--
> >  1 file changed, 9 insertions(+), 2 deletions(-)
>
> looks ok
>
Pushed, thx
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/3] tests/audiomatch: add free to make static analysis tools happy

2020-12-10 Thread Anton Khirnov 
Quoting Jun Zhao (2020-12-09 10:53:08)
> From: Jun Zhao 
> 
> Signed-off-by: Jun Zhao 
> ---
>  tests/audiomatch.c | 11 +--
>  1 file changed, 9 insertions(+), 2 deletions(-)

looks ok

-- 
Anton Khirnov
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/3] tests/audiomatch: add free to make static analysis tools happy

2020-12-09 Thread Jun Zhao 
From: Jun Zhao 

Signed-off-by: Jun Zhao 
---
 tests/audiomatch.c | 11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/tests/audiomatch.c b/tests/audiomatch.c
index bb9deca..56a60bd 100644
--- a/tests/audiomatch.c
+++ b/tests/audiomatch.c
@@ -82,9 +82,9 @@ int main(int argc, char **argv) {
 signal = malloc(siglen * sizeof(*signal));
 
 if (fread(data  , 1, datlen, f[0]) != datlen)
-return 1;
+goto read_fail;
 if (fread(signal, 1, siglen, f[1]) != siglen)
-return 1;
+goto read_fail;
 datlen /= 2;
 siglen /= 2;
 
@@ -111,5 +111,12 @@ int main(int argc, char **argv) {
 }
 printf("presig: %d postsig:%d c:%7.4f lenerr:%d\n", bestpos, datlen - 
siglen - bestpos, bestc / sigamp, datlen - siglen);
 
+free(data);
+free(signal);
 return 0;
+
+read_fail:
+free(data);
+free(signal);
+return 1;
 }
-- 
2.7.4

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".