Re: [FFmpeg-devel] [PATCH 1/4] avcodec/notchlc: Check init_get_bits8() for failure

[Michael Niedermayer]

On Mon, May 13, 2024 at 03:20:08AM +0200, Michael Niedermayer wrote:
> Fixes: CID1500300 Unchecked return value
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer 
> ---
>  libavcodec/notchlc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

will apply the remaining patches of this set

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

What does censorship reveal? It reveals fear. -- Julian Assange


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/4] avcodec/notchlc: Check init_get_bits8() for failure

[Michael Niedermayer]

Fixes: CID1500300 Unchecked return value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer 
---
 libavcodec/notchlc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libavcodec/notchlc.c b/libavcodec/notchlc.c
index 6dd3f884407..30427f4ba92 100644
--- a/libavcodec/notchlc.c
+++ b/libavcodec/notchlc.c
@@ -243,7 +243,9 @@ static int decode_blocks(AVCodecContext *avctx, AVFrame *p,
 
 bytestream2_seek(&dgb, s->y_data_offset + row_offset, SEEK_SET);
 
-init_get_bits8(&bit, dgb.buffer, bytestream2_get_bytes_left(&dgb));
+ret = init_get_bits8(&bit, dgb.buffer, 
bytestream2_get_bytes_left(&dgb));
+if (ret < 0)
+return ret;
 for (int x = 0; x < avctx->width; x += 4) {
 unsigned item = bytestream2_get_le32(gb);
 unsigned y_min = item & 4095;
-- 
2.43.2

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".