Re: [FFmpeg-devel] [PATCH 1/7] avutil/random_seed: Avoid dead returns

2024-05-27 Thread Michael Niedermayer
On Tue, May 21, 2024 at 04:46:46AM +0200, Michael Niedermayer wrote:
> Fixes: CID1538296 Structurally dead code
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer 
> ---
>  libavutil/random_seed.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

will apply patches 1-6

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


[FFmpeg-devel] [PATCH 1/7] avutil/random_seed: Avoid dead returns

2024-05-20 Thread Michael Niedermayer
Fixes: CID1538296 Structurally dead code

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer 
---
 libavutil/random_seed.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libavutil/random_seed.c b/libavutil/random_seed.c
index 6d399cee49c..8a4e4f1fc0b 100644
--- a/libavutil/random_seed.c
+++ b/libavutil/random_seed.c
@@ -158,10 +158,10 @@ int av_random_bytes(uint8_t* buf, size_t len)
 #elif CONFIG_OPENSSL
 if (RAND_bytes(buf, len) == 1)
 return 0;
-err = AVERROR_EXTERNAL;
-#endif
-
+return AVERROR_EXTERNAL;
+#else
 return err;
+#endif
 }
 
 uint32_t av_get_random_seed(void)
-- 
2.45.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".