Re: [FFmpeg-devel] [PATCH 2/2] lavfi/dnn: Remove DNN native backend

2023-01-03 Thread Fu, Ting



> -Original Message-
> From: ffmpeg-devel  On Behalf Of
> Marton Balint
> Sent: Sunday, January 1, 2023 06:20 PM
> To: FFmpeg development discussions and patches  de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavfi/dnn: Remove DNN native
> backend
> 
> 
> 
> On Fri, 30 Dec 2022, Ting Fu wrote:
> 
> > According to discussion in
> > https://etherpad.mit.edu/p/FF_dev_meeting_20221202.
> > The DNN native backend should be removed at first step.
> > All the DNN native backend related code is deleted.
> 
> You should explain why it is being removed. The cited URL is not giving
> any explanations.
> 
> Thanks,
> Marton
> 
Hi Marton,

Hope the email here can explain: 
http://ffmpeg.org/pipermail/ffmpeg-devel/2022-December/304534.html
As I noticed, the native backend only supports a few models, which was an 
outcome after many layers' implementation in FFmpeg DNN module. Naturally, it 
would take many other works to support other models.
What's more, due to its' ordinary, unsatisfied performance, almost users choose 
other well-developed DNN framework for inference.

I believe that's the main reason to remove native from DNN module.

Thank you
Ting Fu
> 
> >
> > Signed-off-by: Ting Fu 
> > ---
> > libavfilter/dnn/Makefile  |  10 -
> > libavfilter/dnn/dnn_backend_native.c  | 561 --
> > libavfilter/dnn/dnn_backend_native.h  | 149 -
> > .../dnn/dnn_backend_native_layer_avgpool.c| 147 -
> > .../dnn/dnn_backend_native_layer_avgpool.h|  69 ---
> > .../dnn/dnn_backend_native_layer_conv2d.c | 265 -
> > .../dnn/dnn_backend_native_layer_conv2d.h |  68 ---
> > .../dnn/dnn_backend_native_layer_dense.c  | 151 -
> > .../dnn/dnn_backend_native_layer_dense.h  |  65 --
> > .../dnn_backend_native_layer_depth2space.c| 102 
> > .../dnn_backend_native_layer_depth2space.h|  72 ---
> > .../dnn/dnn_backend_native_layer_mathbinary.c | 193 --
> > .../dnn/dnn_backend_native_layer_mathbinary.h |  54 --
> > .../dnn/dnn_backend_native_layer_mathunary.c  | 156 -
> > .../dnn/dnn_backend_native_layer_mathunary.h  |  92 ---
> > .../dnn/dnn_backend_native_layer_maximum.c|  83 ---
> > .../dnn/dnn_backend_native_layer_maximum.h|  44 --
> > .../dnn/dnn_backend_native_layer_pad.c| 268 -
> > .../dnn/dnn_backend_native_layer_pad.h|  43 --
> > libavfilter/dnn/dnn_backend_native_layers.c   |  42 --
> > libavfilter/dnn/dnn_backend_native_layers.h   |  38 --
> > libavfilter/dnn/dnn_backend_tf.c  | 368 +---
> > libavfilter/dnn/dnn_interface.c   |  10 +-
> > libavfilter/tests/dnn-layer-avgpool.c | 197 --
> > libavfilter/tests/dnn-layer-conv2d.c  | 248 
> > libavfilter/tests/dnn-layer-dense.c   | 131 
> > libavfilter/tests/dnn-layer-depth2space.c | 102 
> > libavfilter/tests/dnn-layer-mathbinary.c  | 214 ---
> > libavfilter/tests/dnn-layer-mathunary.c   | 148 -
> > libavfilter/tests/dnn-layer-maximum.c |  71 ---
> > libavfilter/tests/dnn-layer-pad.c | 239 
> > tests/Makefile|   1 -
> > tests/fate/dnn.mak|  45 --
> > 33 files changed, 6 insertions(+), 4440 deletions(-)
> > delete mode 100644 libavfilter/dnn/dnn_backend_native.c
> > delete mode 100644 libavfilter/dnn/dnn_backend_native.h
> > delete mode 100644 libavfilter/dnn/dnn_backend_native_layer_avgpool.c
> > delete mode 100644 libavfilter/dnn/dnn_backend_native_layer_avgpool.h
> > delete mode 100644 libavfilter/dnn/dnn_backend_native_layer_conv2d.c
> > delete mode 100644 libavfilter/dnn/dnn_backend_native_layer_conv2d.h
> > delete mode 100644 libavfilter/dnn/dnn_backend_native_layer_dense.c
> > delete mode 100644 libavfilter/dnn/dnn_backend_native_layer_dense.h
> > delete mode 100644
> libavfilter/dnn/dnn_backend_native_layer_depth2space.c
> > delete mode 100644
> libavfilter/dnn/dnn_backend_native_layer_depth2space.h
> > delete mode 100644
> libavfilter/dnn/dnn_backend_native_layer_mathbinary.c
> > delete mode 100644
> libavfilter/dnn/dnn_backend_native_layer_mathbinary.h
> > delete mode 100644
> libavfilter/dnn/dnn_backend_native_layer_mathunary.c
> > delete mode 100644
> libavfilter/dnn/dnn_backend_native_layer_mathunary.h
> > delete mode 100644
> libavfilter/dnn/dnn_backend_native_layer_maximum.c
> > delete mode 100644
> libavfilter/dnn/dnn_backend_native_layer_maximum.h
> > delete mode 100644 libavfilter/dnn/dnn_backend_na

Re: [FFmpeg-devel] [PATCH 2/2] lavfi/dnn: Remove DNN native backend

2023-01-02 Thread Fu, Ting



> -Original Message-
> From: ffmpeg-devel  On Behalf Of
> Michael Niedermayer
> Sent: Monday, January 2, 2023 07:26 AM
> To: FFmpeg development discussions and patches  de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavfi/dnn: Remove DNN native
> backend
> 
> On Fri, Dec 30, 2022 at 04:42:56PM +0800, Ting Fu wrote:
> > According to discussion in
> > https://etherpad.mit.edu/p/FF_dev_meeting_20221202.
> > The DNN native backend should be removed at first step.
> > All the DNN native backend related code is deleted.
> >
> > Signed-off-by: Ting Fu 
> 
> This patch seems breaking
> 
> make testprogs
> make: *** No rule to make target 'libavfilter/tests/dnn-layer-avgpool.c',
> needed by 'libavfilter/tests/dnn-layer-avgpool.o'.  Stop.
> 
> and with a distclean and some configure
> 
> make testprogs
> LDlibavfilter/tests/dnn-layer-avgpool
> gcc: error: libavfilter/tests/dnn-layer-avgpool.o: No such file or directory
> ffbuild/library.mak:118: recipe for target 
> 'libavfilter/tests/dnn-layer-avgpool'
> failed
> make: *** [libavfilter/tests/dnn-layer-avgpool] Error 1
Hi Michael,

Sorry for 'make testprogs' failed.
This was caused by not deleting code in make target 'testprogs' in 
libavfilter/Makefile.
I have done it and updated V2. Local make passed for all targets.

Thank you
Ting Fu
> 
> [...]
> 
> --
> Michael GnuPG fingerprint:
> 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> The educated differ from the uneducated as much as the living from the
> dead. -- Aristotle
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


Re: [FFmpeg-devel] [PATCH 2/2] lavfi/dnn: Remove DNN native backend

2023-01-01 Thread Michael Niedermayer
On Fri, Dec 30, 2022 at 04:42:56PM +0800, Ting Fu wrote:
> According to discussion in
> https://etherpad.mit.edu/p/FF_dev_meeting_20221202.
> The DNN native backend should be removed at first step.
> All the DNN native backend related code is deleted.
> 
> Signed-off-by: Ting Fu 

This patch seems breaking 

make testprogs
make: *** No rule to make target 'libavfilter/tests/dnn-layer-avgpool.c', 
needed by 'libavfilter/tests/dnn-layer-avgpool.o'.  Stop.

and with a distclean and some configure

make testprogs
LD  libavfilter/tests/dnn-layer-avgpool
gcc: error: libavfilter/tests/dnn-layer-avgpool.o: No such file or directory
ffbuild/library.mak:118: recipe for target 
'libavfilter/tests/dnn-layer-avgpool' failed
make: *** [libavfilter/tests/dnn-layer-avgpool] Error 1

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


Re: [FFmpeg-devel] [PATCH 2/2] lavfi/dnn: Remove DNN native backend

2023-01-01 Thread Jean-Baptiste Kempf
On Fri, 30 Dec 2022, at 09:42, Ting Fu wrote:
> According to discussion in
> https://etherpad.mit.edu/p/FF_dev_meeting_20221202.
> The DNN native backend should be removed at first step.
> All the DNN native backend related code is deleted.
>
> Signed-off-by: Ting Fu 

LGTM.

-- 
Jean-Baptiste Kempf -  President
+33 672 704 734
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".