Re: [FFmpeg-devel] [PATCH 2/4] avcodec/dca: fix av_cold placement in declarations

2016-03-03 Thread Michael Niedermayer 
On Thu, Mar 03, 2016 at 12:57:36AM +0100, Hendrik Leppkes wrote:
> On Wed, Mar 2, 2016 at 8:31 PM, foo86  wrote:
> > ---
> >  libavcodec/dca_xll.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavcodec/dca_xll.c b/libavcodec/dca_xll.c
> > index cd1af81..ffe8ef3 100644
> > --- a/libavcodec/dca_xll.c
> > +++ b/libavcodec/dca_xll.c
> > @@ -602,7 +602,7 @@ static int chs_parse_band_data(DCAXllDecoder *s, 
> > DCAXllChSet *c, int band, int s
> >  return 0;
> >  }
> >
> > -static void av_cold chs_clear_band_data(DCAXllDecoder *s, DCAXllChSet *c, 
> > int band, int seg)
> > +static av_cold void chs_clear_band_data(DCAXllDecoder *s, DCAXllChSet *c, 
> > int band, int seg)
> >  {
> >  DCAXllBand *b = >bands[band];
> >  int i, offset, nsamples;
> > @@ -1242,7 +1242,7 @@ static void scale_down_mix(DCAXllDecoder *s, 
> > DCAXllChSet *o, int band)
> >
> >  // Clear all band data and replace non-residual encoded channels with lossy
> >  // counterparts
> > -static void av_cold force_lossy_output(DCAXllDecoder *s, DCAXllChSet *c)
> > +static av_cold void force_lossy_output(DCAXllDecoder *s, DCAXllChSet *c)
> >  {
> >  DCAContext *dca = s->avctx->priv_data;
> >  int band, ch;
> > --
> > 2.1.4
> 
> LGTM, thanks.

applied

thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/dca: fix av_cold placement in declarations

2016-03-02 Thread Hendrik Leppkes 
On Wed, Mar 2, 2016 at 8:31 PM, foo86  wrote:
> ---
>  libavcodec/dca_xll.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/dca_xll.c b/libavcodec/dca_xll.c
> index cd1af81..ffe8ef3 100644
> --- a/libavcodec/dca_xll.c
> +++ b/libavcodec/dca_xll.c
> @@ -602,7 +602,7 @@ static int chs_parse_band_data(DCAXllDecoder *s, 
> DCAXllChSet *c, int band, int s
>  return 0;
>  }
>
> -static void av_cold chs_clear_band_data(DCAXllDecoder *s, DCAXllChSet *c, 
> int band, int seg)
> +static av_cold void chs_clear_band_data(DCAXllDecoder *s, DCAXllChSet *c, 
> int band, int seg)
>  {
>  DCAXllBand *b = >bands[band];
>  int i, offset, nsamples;
> @@ -1242,7 +1242,7 @@ static void scale_down_mix(DCAXllDecoder *s, 
> DCAXllChSet *o, int band)
>
>  // Clear all band data and replace non-residual encoded channels with lossy
>  // counterparts
> -static void av_cold force_lossy_output(DCAXllDecoder *s, DCAXllChSet *c)
> +static av_cold void force_lossy_output(DCAXllDecoder *s, DCAXllChSet *c)
>  {
>  DCAContext *dca = s->avctx->priv_data;
>  int band, ch;
> --
> 2.1.4

LGTM, thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 2/4] avcodec/dca: fix av_cold placement in declarations

2016-03-02 Thread foo86 
---
 libavcodec/dca_xll.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/dca_xll.c b/libavcodec/dca_xll.c
index cd1af81..ffe8ef3 100644
--- a/libavcodec/dca_xll.c
+++ b/libavcodec/dca_xll.c
@@ -602,7 +602,7 @@ static int chs_parse_band_data(DCAXllDecoder *s, 
DCAXllChSet *c, int band, int s
 return 0;
 }
 
-static void av_cold chs_clear_band_data(DCAXllDecoder *s, DCAXllChSet *c, int 
band, int seg)
+static av_cold void chs_clear_band_data(DCAXllDecoder *s, DCAXllChSet *c, int 
band, int seg)
 {
 DCAXllBand *b = >bands[band];
 int i, offset, nsamples;
@@ -1242,7 +1242,7 @@ static void scale_down_mix(DCAXllDecoder *s, DCAXllChSet 
*o, int band)
 
 // Clear all band data and replace non-residual encoded channels with lossy
 // counterparts
-static void av_cold force_lossy_output(DCAXllDecoder *s, DCAXllChSet *c)
+static av_cold void force_lossy_output(DCAXllDecoder *s, DCAXllChSet *c)
 {
 DCAContext *dca = s->avctx->priv_data;
 int band, ch;
-- 
2.1.4

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel