Re: [FFmpeg-devel] [PATCH 2/5] copy stream metadata when using concat
Thanks! On Wed, Jul 1, 2015 at 3:56 PM, Michael Niedermayer wrote: > On Wed, Jul 01, 2015 at 01:49:06PM +0300, Vadim Belov wrote: > > --- > > libavformat/concatdec.c | 2 ++ > > 1 file changed, 2 insertions(+) > > applied > > thanks > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Into a blind darkness they enter who follow after the Ignorance, > they as if into a greater darkness enter who devote themselves > to the Knowledge alone. -- Isha Upanishad > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/5] copy stream metadata when using concat
On Wed, Jul 01, 2015 at 01:49:06PM +0300, Vadim Belov wrote: > --- > libavformat/concatdec.c | 2 ++ > 1 file changed, 2 insertions(+) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater darkness enter who devote themselves to the Knowledge alone. -- Isha Upanishad signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/5] copy stream metadata when using concat
Thanks Nicolas, I reconfigured Git and sent again. It was tested and the added functionality works. On Wed, Jul 1, 2015 at 1:19 PM, Nicolas George wrote: > Le tridi 13 messidor, an CCXXIII, Vadim Belov a écrit : > > From: unknown > > Not good. Please configure Git to include a valid name and address. > > > > > --- > > libavformat/concatdec.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c > > index f07cfd7..c61d5c2 100644 > > --- a/libavformat/concatdec.c > > +++ b/libavformat/concatdec.c > > @@ -172,6 +172,8 @@ static int copy_stream_props(AVStream *st, AVStream > *source_st) > > st->avg_frame_rate = source_st->avg_frame_rate; > > st->time_base = source_st->time_base; > > st->sample_aspect_ratio = source_st->sample_aspect_ratio; > > + > > +av_dict_copy(&st->metadata, source_st->metadata, 0); > > return 0; > > } > > Code change LGTM if tested. > > (I am a bit shocked that av_dict_copy() does not return an error code, but > that is not your fault.) > > Regards, > > -- > Nicolas George > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH 2/5] copy stream metadata when using concat
--- libavformat/concatdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index f07cfd7..c61d5c2 100644 --- a/libavformat/concatdec.c +++ b/libavformat/concatdec.c @@ -172,6 +172,8 @@ static int copy_stream_props(AVStream *st, AVStream *source_st) st->avg_frame_rate = source_st->avg_frame_rate; st->time_base = source_st->time_base; st->sample_aspect_ratio = source_st->sample_aspect_ratio; + +av_dict_copy(&st->metadata, source_st->metadata, 0); return 0; } -- 1.9.5.msysgit.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/5] copy stream metadata when using concat
Le tridi 13 messidor, an CCXXIII, Vadim Belov a écrit : > From: unknown Not good. Please configure Git to include a valid name and address. > > --- > libavformat/concatdec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c > index f07cfd7..c61d5c2 100644 > --- a/libavformat/concatdec.c > +++ b/libavformat/concatdec.c > @@ -172,6 +172,8 @@ static int copy_stream_props(AVStream *st, AVStream > *source_st) > st->avg_frame_rate = source_st->avg_frame_rate; > st->time_base = source_st->time_base; > st->sample_aspect_ratio = source_st->sample_aspect_ratio; > + > +av_dict_copy(&st->metadata, source_st->metadata, 0); > return 0; > } Code change LGTM if tested. (I am a bit shocked that av_dict_copy() does not return an error code, but that is not your fault.) Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH 2/5] copy stream metadata when using concat
From: unknown --- libavformat/concatdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index f07cfd7..c61d5c2 100644 --- a/libavformat/concatdec.c +++ b/libavformat/concatdec.c @@ -172,6 +172,8 @@ static int copy_stream_props(AVStream *st, AVStream *source_st) st->avg_frame_rate = source_st->avg_frame_rate; st->time_base = source_st->time_base; st->sample_aspect_ratio = source_st->sample_aspect_ratio; + +av_dict_copy(&st->metadata, source_st->metadata, 0); return 0; } -- 1.9.5.msysgit.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
