Re: [FFmpeg-devel] [PATCH 3/3] avformat/mpegts: include stream types for mpeg2 and aac

2016-06-21 Thread Michael Niedermayer 
On Sat, Jun 18, 2016 at 12:56:50PM +0200, Hendrik Leppkes wrote:
> On Tue, Jun 14, 2016 at 8:08 PM, Aman Gupta  wrote:
> > From: Aman Gupta 
> >
> > this removes the need to probe to discover mpeg2 and aac streams
> > inside mpegts containers, thus speeding up initial playback.
> > ---
> >  libavformat/mpegts.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
> > index 6acb797..f46984d 100644
> > --- a/libavformat/mpegts.c
> > +++ b/libavformat/mpegts.c
> > @@ -700,6 +700,7 @@ static const StreamType ISO_types[] = {
> >  { 0x11, AVMEDIA_TYPE_AUDIO, AV_CODEC_ID_AAC_LATM   }, /* LATM syntax */
> >  #endif
> >  { 0x1b, AVMEDIA_TYPE_VIDEO, AV_CODEC_ID_H264   },
> > +{ 0x1c, AVMEDIA_TYPE_AUDIO, AV_CODEC_ID_AAC},
> >  { 0x20, AVMEDIA_TYPE_VIDEO, AV_CODEC_ID_H264   },
> >  { 0x21, AVMEDIA_TYPE_VIDEO, AV_CODEC_ID_JPEG2000   },
> >  { 0x24, AVMEDIA_TYPE_VIDEO, AV_CODEC_ID_HEVC   },
> 
> I can see 1c in the latest spec for AAC audio, so thats probably fine.

applied this hunk

thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mpegts: include stream types for mpeg2 and aac

2016-06-18 Thread Hendrik Leppkes 
On Tue, Jun 14, 2016 at 8:08 PM, Aman Gupta  wrote:
> From: Aman Gupta 
>
> this removes the need to probe to discover mpeg2 and aac streams
> inside mpegts containers, thus speeding up initial playback.
> ---
>  libavformat/mpegts.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
> index 6acb797..f46984d 100644
> --- a/libavformat/mpegts.c
> +++ b/libavformat/mpegts.c
> @@ -700,6 +700,7 @@ static const StreamType ISO_types[] = {
>  { 0x11, AVMEDIA_TYPE_AUDIO, AV_CODEC_ID_AAC_LATM   }, /* LATM syntax */
>  #endif
>  { 0x1b, AVMEDIA_TYPE_VIDEO, AV_CODEC_ID_H264   },
> +{ 0x1c, AVMEDIA_TYPE_AUDIO, AV_CODEC_ID_AAC},
>  { 0x20, AVMEDIA_TYPE_VIDEO, AV_CODEC_ID_H264   },
>  { 0x21, AVMEDIA_TYPE_VIDEO, AV_CODEC_ID_JPEG2000   },
>  { 0x24, AVMEDIA_TYPE_VIDEO, AV_CODEC_ID_HEVC   },

I can see 1c in the latest spec for AAC audio, so thats probably fine.

> @@ -726,6 +727,7 @@ static const StreamType HDMV_types[] = {
>
>  /* ATSC ? */
>  static const StreamType MISC_types[] = {
> +{ 0x80, AVMEDIA_TYPE_VIDEO, AV_CODEC_ID_MPEG2VIDEO },
>  { 0x81, AVMEDIA_TYPE_AUDIO, AV_CODEC_ID_AC3 },
>  { 0x8a, AVMEDIA_TYPE_AUDIO, AV_CODEC_ID_DTS },
>  { 0 },

However, are there any specs that outline this value?

> --
> 2.8.1
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mpegts: include stream types for mpeg2 and aac

2016-06-18 Thread Michael Niedermayer 
On Tue, Jun 14, 2016 at 11:08:55AM -0700, Aman Gupta wrote:
> From: Aman Gupta 
> 
> this removes the need to probe to discover mpeg2 and aac streams
> inside mpegts containers, thus speeding up initial playback.
> ---
>  libavformat/mpegts.c | 2 ++
>  1 file changed, 2 insertions(+)

this is probably ok unless there was a reason why these where missing
but if it causes misdetection it could be reverted easily


[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 3/3] avformat/mpegts: include stream types for mpeg2 and aac

2016-06-14 Thread Aman Gupta 
From: Aman Gupta 

this removes the need to probe to discover mpeg2 and aac streams
inside mpegts containers, thus speeding up initial playback.
---
 libavformat/mpegts.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
index 6acb797..f46984d 100644
--- a/libavformat/mpegts.c
+++ b/libavformat/mpegts.c
@@ -700,6 +700,7 @@ static const StreamType ISO_types[] = {
 { 0x11, AVMEDIA_TYPE_AUDIO, AV_CODEC_ID_AAC_LATM   }, /* LATM syntax */
 #endif
 { 0x1b, AVMEDIA_TYPE_VIDEO, AV_CODEC_ID_H264   },
+{ 0x1c, AVMEDIA_TYPE_AUDIO, AV_CODEC_ID_AAC},
 { 0x20, AVMEDIA_TYPE_VIDEO, AV_CODEC_ID_H264   },
 { 0x21, AVMEDIA_TYPE_VIDEO, AV_CODEC_ID_JPEG2000   },
 { 0x24, AVMEDIA_TYPE_VIDEO, AV_CODEC_ID_HEVC   },
@@ -726,6 +727,7 @@ static const StreamType HDMV_types[] = {
 
 /* ATSC ? */
 static const StreamType MISC_types[] = {
+{ 0x80, AVMEDIA_TYPE_VIDEO, AV_CODEC_ID_MPEG2VIDEO },
 { 0x81, AVMEDIA_TYPE_AUDIO, AV_CODEC_ID_AC3 },
 { 0x8a, AVMEDIA_TYPE_AUDIO, AV_CODEC_ID_DTS },
 { 0 },
-- 
2.8.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel