Re: [FFmpeg-devel] [PATCH 3/3] avutil/dict: constify av_dict_get return

2023-06-05 Thread Anton Khirnov
Quoting Marvin Scholz (2023-05-01 13:44:56)
> ---
>  doc/examples/qsv_transcode.c   |  2 +-
>  libavcodec/libaomenc.c |  2 +-
>  libavcodec/libkvazaar.c|  2 +-
>  libavcodec/libsvtav1.c |  2 +-
>  libavcodec/libvpxenc.c |  2 +-
>  libavcodec/libx264.c   |  2 +-
>  libavcodec/libx265.c   |  2 +-
>  libavcodec/mjpegdec.c  |  2 +-
>  libavcodec/qsvenc.c|  2 +-
>  libavfilter/avfilter.c |  2 +-
>  libavfilter/f_bench.c  |  2 +-
>  libavfilter/f_drawgraph.c  |  2 +-
>  libavfilter/f_select.c |  4 +--
>  libavfilter/vf_cover_rect.c|  2 +-
>  libavfilter/vf_drawtext.c  |  2 +-
>  libavformat/aiffenc.c  |  2 +-
>  libavformat/argo_asf.c |  2 +-
>  libavformat/asfenc.c   |  6 ++--
>  libavformat/au.c   |  2 +-
>  libavformat/avformat.h |  2 +-
>  libavformat/avidec.c   |  2 +-
>  libavformat/avienc.c   |  2 +-
>  libavformat/avio.c |  4 +--
>  libavformat/dashenc.c  |  6 ++--
>  libavformat/dvenc.c|  2 +-
>  libavformat/flacdec.c  |  2 +-
>  libavformat/flacenc.c  |  6 ++--
>  libavformat/flvdec.c   |  2 +-
>  libavformat/gxfenc.c   |  2 +-
>  libavformat/http.c |  8 +++---
>  libavformat/id3v2.c|  6 ++--
>  libavformat/id3v2enc.c |  2 +-
>  libavformat/imfdec.c   |  2 +-
>  libavformat/matroskadec.c  |  2 +-
>  libavformat/mov.c  |  6 ++--
>  libavformat/movenc.c   | 46 +++---
>  libavformat/mp3enc.c   |  6 ++--
>  libavformat/mpegtsenc.c|  6 ++--
>  libavformat/mux.c  |  2 +-
>  libavformat/mux_utils.c|  2 +-
>  libavformat/mxfenc.c   | 14 -
>  libavformat/riffenc.c  |  2 +-
>  libavformat/rmenc.c|  2 +-
>  libavformat/sapenc.c   |  2 +-
>  libavformat/sdp.c  |  2 +-
>  libavformat/segment.c  |  4 +--
>  libavformat/soxenc.c   |  2 +-
>  libavformat/tee.c  |  2 +-
>  libavformat/ttmlenc.c  |  4 +--
>  libavformat/wavenc.c   |  4 +--
>  libavformat/webmdashenc.c  | 30 +--
>  libavutil/dict.c   |  9 +-
>  libavutil/dict.h   |  5 
>  libavutil/hwcontext_cuda.c |  2 +-
>  libavutil/hwcontext_qsv.c  |  2 +-
>  libavutil/hwcontext_vulkan.c   |  8 +++---
>  libavutil/version.h|  1 +
>  tests/api/api-threadmessage-test.c |  2 +-
>  58 files changed, 136 insertions(+), 123 deletions(-)

IMO this is an API break, and so should be postponed until the next
major bump.

-- 
Anton Khirnov
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


[FFmpeg-devel] [PATCH 3/3] avutil/dict: constify av_dict_get return

2023-05-01 Thread Marvin Scholz
---
 doc/examples/qsv_transcode.c   |  2 +-
 libavcodec/libaomenc.c |  2 +-
 libavcodec/libkvazaar.c|  2 +-
 libavcodec/libsvtav1.c |  2 +-
 libavcodec/libvpxenc.c |  2 +-
 libavcodec/libx264.c   |  2 +-
 libavcodec/libx265.c   |  2 +-
 libavcodec/mjpegdec.c  |  2 +-
 libavcodec/qsvenc.c|  2 +-
 libavfilter/avfilter.c |  2 +-
 libavfilter/f_bench.c  |  2 +-
 libavfilter/f_drawgraph.c  |  2 +-
 libavfilter/f_select.c |  4 +--
 libavfilter/vf_cover_rect.c|  2 +-
 libavfilter/vf_drawtext.c  |  2 +-
 libavformat/aiffenc.c  |  2 +-
 libavformat/argo_asf.c |  2 +-
 libavformat/asfenc.c   |  6 ++--
 libavformat/au.c   |  2 +-
 libavformat/avformat.h |  2 +-
 libavformat/avidec.c   |  2 +-
 libavformat/avienc.c   |  2 +-
 libavformat/avio.c |  4 +--
 libavformat/dashenc.c  |  6 ++--
 libavformat/dvenc.c|  2 +-
 libavformat/flacdec.c  |  2 +-
 libavformat/flacenc.c  |  6 ++--
 libavformat/flvdec.c   |  2 +-
 libavformat/gxfenc.c   |  2 +-
 libavformat/http.c |  8 +++---
 libavformat/id3v2.c|  6 ++--
 libavformat/id3v2enc.c |  2 +-
 libavformat/imfdec.c   |  2 +-
 libavformat/matroskadec.c  |  2 +-
 libavformat/mov.c  |  6 ++--
 libavformat/movenc.c   | 46 +++---
 libavformat/mp3enc.c   |  6 ++--
 libavformat/mpegtsenc.c|  6 ++--
 libavformat/mux.c  |  2 +-
 libavformat/mux_utils.c|  2 +-
 libavformat/mxfenc.c   | 14 -
 libavformat/riffenc.c  |  2 +-
 libavformat/rmenc.c|  2 +-
 libavformat/sapenc.c   |  2 +-
 libavformat/sdp.c  |  2 +-
 libavformat/segment.c  |  4 +--
 libavformat/soxenc.c   |  2 +-
 libavformat/tee.c  |  2 +-
 libavformat/ttmlenc.c  |  4 +--
 libavformat/wavenc.c   |  4 +--
 libavformat/webmdashenc.c  | 30 +--
 libavutil/dict.c   |  9 +-
 libavutil/dict.h   |  5 
 libavutil/hwcontext_cuda.c |  2 +-
 libavutil/hwcontext_qsv.c  |  2 +-
 libavutil/hwcontext_vulkan.c   |  8 +++---
 libavutil/version.h|  1 +
 tests/api/api-threadmessage-test.c |  2 +-
 58 files changed, 136 insertions(+), 123 deletions(-)

diff --git a/doc/examples/qsv_transcode.c b/doc/examples/qsv_transcode.c
index 48128b200c..cc4c203d94 100644
--- a/doc/examples/qsv_transcode.c
+++ b/doc/examples/qsv_transcode.c
@@ -87,7 +87,7 @@ static int dynamic_set_parameter(AVCodecContext *avctx)
 frame_number++;
 if (current_setting_number < setting_number &&
 frame_number == dynamic_setting[current_setting_number].frame_number) {
-AVDictionaryEntry *e = NULL;
+const AVDictionaryEntry *e = NULL;
 ret = str_to_dict(dynamic_setting[current_setting_number++].optstr, 
);
 if (ret < 0) {
 fprintf(stderr, "The dynamic parameter is wrong\n");
diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c
index 0b88102c77..8a32f31677 100644
--- a/libavcodec/libaomenc.c
+++ b/libavcodec/libaomenc.c
@@ -999,7 +999,7 @@ static av_cold int aom_init(AVCodecContext *avctx,
 
 #if AOM_ENCODER_ABI_VERSION >= 23
 {
-AVDictionaryEntry *en = NULL;
+const AVDictionaryEntry *en = NULL;
 
 while ((en = av_dict_get(ctx->aom_params, "", en, 
AV_DICT_IGNORE_SUFFIX))) {
 int ret = aom_codec_set_option(>encoder, en->key, en->value);
diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c
index 168486f4ec..f9f3ce8e52 100644
--- a/libavcodec/libkvazaar.c
+++ b/libavcodec/libkvazaar.c
@@ -103,7 +103,7 @@ static av_cold int libkvazaar_init(AVCodecContext *avctx)
 if (ctx->kvz_params) {
 AVDictionary *dict = NULL;
 if (!av_dict_parse_string(, ctx->kvz_params, "=", ",", 0)) {
-AVDictionaryEntry *entry = NULL;
+const AVDictionaryEntry *entry = NULL;
 while ((entry = av_dict_get(dict, "", entry, 
AV_DICT_IGNORE_SUFFIX))) {
 if (!api->config_parse(cfg, entry->key, entry->value)) {
 av_log(avctx, AV_LOG_WARNING, "Invalid option: %s=%s.\n",
diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
index 9174e2753c..e959c1cab0 100644
--- a/libavcodec/libsvtav1.c
+++ b/libavcodec/libsvtav1.c
@@ -151,7 +151,7 @@ static int config_enc_params(EbSvtAv1EncConfiguration 
*param,
 {
 SvtContext *svt_enc = avctx->priv_data;
 const AVPixFmtDescriptor *desc;
-AVDictionaryEntry *en = NULL;
+const AVDictionaryEntry *en = NULL;
 
 // Update