Re: [FFmpeg-devel] [PATCH 3/3] dnxhdenc: mark CID 1260 encoder experimental

2015-10-07 Thread Michael Niedermayer
On Mon, Oct 05, 2015 at 08:44:46PM +0200, Christophe Gisquet wrote:
> The MBAFF handling recently introduced on the decoder side shows that
> the encoder does not support it correctly. Therefore, make the related
> profile experimental.
> 
> Furthermore, current encoder logic treats it as unable to encode as
> progressive, which isn't the case.
> ---
>  libavcodec/dnxhddata.c | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/libavcodec/dnxhddata.c b/libavcodec/dnxhddata.c
> index ffc8018..d8027b5 100644
> --- a/libavcodec/dnxhddata.c
> +++ b/libavcodec/dnxhddata.c
> @@ -1158,6 +1158,11 @@ int ff_dnxhd_find_cid(AVCodecContext *avctx, int 
> bit_depth)
>  if (cid->width == avctx->width && cid->height == avctx->height &&
>  interlaced == !!(avctx->flags & AV_CODEC_FLAG_INTERLACED_DCT) &&
>  !(cid->flags & DNXHD_444) && cid->bit_depth == bit_depth) {
> +if (avctx->strict_std_compliance > FF_COMPLIANCE_EXPERIMENTAL &&
> +cid->flags & DNXHD_MBAFF) {
> +av_log(avctx, AV_LOG_WARNING, "Profile selected is 
> experimental");

added a \n (otherwise it gets prepended without whitespace)

applied

thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


[FFmpeg-devel] [PATCH 3/3] dnxhdenc: mark CID 1260 encoder experimental

2015-10-05 Thread Christophe Gisquet
The MBAFF handling recently introduced on the decoder side shows that
the encoder does not support it correctly. Therefore, make the related
profile experimental.

Furthermore, current encoder logic treats it as unable to encode as
progressive, which isn't the case.
---
 libavcodec/dnxhddata.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/libavcodec/dnxhddata.c b/libavcodec/dnxhddata.c
index ffc8018..d8027b5 100644
--- a/libavcodec/dnxhddata.c
+++ b/libavcodec/dnxhddata.c
@@ -1158,6 +1158,11 @@ int ff_dnxhd_find_cid(AVCodecContext *avctx, int 
bit_depth)
 if (cid->width == avctx->width && cid->height == avctx->height &&
 interlaced == !!(avctx->flags & AV_CODEC_FLAG_INTERLACED_DCT) &&
 !(cid->flags & DNXHD_444) && cid->bit_depth == bit_depth) {
+if (avctx->strict_std_compliance > FF_COMPLIANCE_EXPERIMENTAL &&
+cid->flags & DNXHD_MBAFF) {
+av_log(avctx, AV_LOG_WARNING, "Profile selected is 
experimental");
+continue;
+}
 for (j = 0; j < FF_ARRAY_ELEMS(cid->bit_rates); j++) {
 if (cid->bit_rates[j] == mbs)
 return cid->cid;
-- 
2.5.2

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel