Re: [FFmpeg-devel] [PATCH 3/3] ffmpeg: do not catch SIGQUIT.

2016-03-19 Thread Michael Niedermayer 
On Sun, Mar 13, 2016 at 12:07:48PM +0100, Nicolas George wrote:
> SIGQUIT is meant for debugging purposes. A signal handler will
> corrupt stack traces and make everything more complicated.
> 
> Signed-off-by: Nicolas George 
> ---
>  ffmpeg.c | 1 -
>  1 file changed, 1 deletion(-)

LGTM thx


[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 3/3] ffmpeg: do not catch SIGQUIT.

2016-03-13 Thread Nicolas George 
SIGQUIT is meant for debugging purposes. A signal handler will
corrupt stack traces and make everything more complicated.

Signed-off-by: Nicolas George 
---
 ffmpeg.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ffmpeg.c b/ffmpeg.c
index 45a22fa..f0e4966 100644
--- a/ffmpeg.c
+++ b/ffmpeg.c
@@ -383,7 +383,6 @@ void term_init(void)
 
 tcsetattr (0, TCSANOW, );
 }
-signal(SIGQUIT, sigterm_handler); /* Quit (POSIX).  */
 }
 #endif
 
-- 
2.7.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel