Re: [FFmpeg-devel] [PATCH 3/4] avcodec/msrleenc: Remove useless private class

[Tomas Härdin]

sön 2023-07-16 klockan 16:51 +0200 skrev Andreas Rheinhardt:
> A private class for an encoder without options is useless.

Might be useful for explicitly using 8-bit encoding even when palette
size would permit 4-bit MSRLE. But on the other hand if anyone wants to
add 4-bit support then they can also add this stuff back in. So OK.

/Tomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 3/4] avcodec/msrleenc: Remove useless private class

[Andreas Rheinhardt]

A private class for an encoder without options is useless.

Signed-off-by: Andreas Rheinhardt 
---
 libavcodec/msrleenc.c | 8 
 1 file changed, 8 deletions(-)

diff --git a/libavcodec/msrleenc.c b/libavcodec/msrleenc.c
index 264d57e178..d5931f42fe 100644
--- a/libavcodec/msrleenc.c
+++ b/libavcodec/msrleenc.c
@@ -31,7 +31,6 @@
 #include "encode.h"
 
 typedef struct MSRLEContext {
-const AVClass *class;
 int curframe;
 AVFrame *last_frame;
 } MSRLEContext;
@@ -282,12 +281,6 @@ static int msrle_encode_close(AVCodecContext *avctx)
 return 0;
 }
 
-static const AVClass msrle_class = {
-.class_name = "Microsoft RLE encoder",
-.item_name  = av_default_item_name,
-.version= LIBAVUTIL_VERSION_INT,
-};
-
 const FFCodec ff_msrle_encoder = {
 .p.name = "msrle",
 CODEC_LONG_NAME("Microsoft RLE"),
@@ -301,6 +294,5 @@ const FFCodec ff_msrle_encoder = {
 .p.pix_fmts = (const enum AVPixelFormat[]){
 AV_PIX_FMT_PAL8, AV_PIX_FMT_NONE
 },
-.p.priv_class   = _class,
 .caps_internal  = FF_CODEC_CAP_INIT_CLEANUP,
 };
-- 
2.34.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".