Re: [FFmpeg-devel] [PATCH 3/4] smacker: remove dead code

2014-07-18 Thread Paul B Mahol
On Fri, Jul 18, 2014 at 4:25 AM, Timothy Gu timothyg...@gmail.com wrote:

 Signed-off-by: Timothy Gu timothyg...@gmail.com
 ---
  libavcodec/smacker.c | 2 --
  1 file changed, 2 deletions(-)

 diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c
 index 644beb3..518bdad 100644
 --- a/libavcodec/smacker.c
 +++ b/libavcodec/smacker.c
 @@ -438,7 +438,6 @@ static int decode_frame(AVCodecContext *avctx, void
 *data, int *got_frame,
  bw = avctx-width  2;
  bh = avctx-height  2;
  blocks = bw * bh;
 -out = smk-pic-data[0];
  stride = smk-pic-linesize[0];
  while(blk  blocks) {
  int type, run, mode;
 @@ -499,7 +498,6 @@ static int decode_frame(AVCodecContext *avctx, void
 *data, int *got_frame,
  out += stride;
  out[0] = out[1] = pix  0xFF;
  out[2] = out[3] = pix  8;
 -out += stride;



 break;
  case 2:
  for(i = 0; i  2; i++) {
 --
 1.9.1

 ___
 ffmpeg-devel mailing list
 ffmpeg-devel@ffmpeg.org
 http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


lgtm
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH 3/4] smacker: remove dead code

2014-07-18 Thread Michael Niedermayer
On Fri, Jul 18, 2014 at 10:04:05AM +0200, Paul B Mahol wrote:
 On Fri, Jul 18, 2014 at 4:25 AM, Timothy Gu timothyg...@gmail.com wrote:
 
  Signed-off-by: Timothy Gu timothyg...@gmail.com
  ---
   libavcodec/smacker.c | 2 --
   1 file changed, 2 deletions(-)
 
  diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c
  index 644beb3..518bdad 100644
  --- a/libavcodec/smacker.c
  +++ b/libavcodec/smacker.c
  @@ -438,7 +438,6 @@ static int decode_frame(AVCodecContext *avctx, void
  *data, int *got_frame,
   bw = avctx-width  2;
   bh = avctx-height  2;
   blocks = bw * bh;
  -out = smk-pic-data[0];
   stride = smk-pic-linesize[0];
   while(blk  blocks) {
   int type, run, mode;
  @@ -499,7 +498,6 @@ static int decode_frame(AVCodecContext *avctx, void
  *data, int *got_frame,
   out += stride;
   out[0] = out[1] = pix  0xFF;
   out[2] = out[3] = pix  8;
  -out += stride;
 
 
 
  break;
   case 2:
   for(i = 0; i  2; i++) {
  --
  1.9.1
 
  ___
  ffmpeg-devel mailing list
  ffmpeg-devel@ffmpeg.org
  http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 
 
 lgtm

applied

thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


[FFmpeg-devel] [PATCH 3/4] smacker: remove dead code

2014-07-17 Thread Timothy Gu
Signed-off-by: Timothy Gu timothyg...@gmail.com
---
 libavcodec/smacker.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c
index 644beb3..518bdad 100644
--- a/libavcodec/smacker.c
+++ b/libavcodec/smacker.c
@@ -438,7 +438,6 @@ static int decode_frame(AVCodecContext *avctx, void *data, 
int *got_frame,
 bw = avctx-width  2;
 bh = avctx-height  2;
 blocks = bw * bh;
-out = smk-pic-data[0];
 stride = smk-pic-linesize[0];
 while(blk  blocks) {
 int type, run, mode;
@@ -499,7 +498,6 @@ static int decode_frame(AVCodecContext *avctx, void *data, 
int *got_frame,
 out += stride;
 out[0] = out[1] = pix  0xFF;
 out[2] = out[3] = pix  8;
-out += stride;
 break;
 case 2:
 for(i = 0; i  2; i++) {
-- 
1.9.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel