Re: [FFmpeg-devel] [PATCH 3/6] lavc/audiotoolboxenc: fix iOS build

[crossle song]

OK, I'll try your all patch before about audiotoolbox

On Wed, Mar 30, 2016 at 5:01 AM, Rodger Combs 
wrote:

>
> > On Mar 27, 2016, at 21:13, crossle song  wrote:
> >
> > Work well on iPhone 6, but on  iPhone 4S iOS 9.0, return  [aac_at @
> > 0x1702a400] Encode error: -50, can not work
>
> I don't have a test setup for iOS devices (nor a 4S to test on); does this
> case work correctly with your patch, but not mine? What's the full ffmpeg
> command you're using to test? (Or is this using lavc in another
> application?)
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/6] lavc/audiotoolboxenc: fix iOS build

[crossle song]

Please merge the audiotoolbox patch

On Wed, Mar 30, 2016 at 10:07 AM, crossle song 
wrote:

> OK, I'll try your all patch before about audiotoolbox
>
> On Wed, Mar 30, 2016 at 5:01 AM, Rodger Combs 
> wrote:
>
>>
>> > On Mar 27, 2016, at 21:13, crossle song  wrote:
>> >
>> > Work well on iPhone 6, but on  iPhone 4S iOS 9.0, return  [aac_at @
>> > 0x1702a400] Encode error: -50, can not work
>>
>> I don't have a test setup for iOS devices (nor a 4S to test on); does
>> this case work correctly with your patch, but not mine? What's the full
>> ffmpeg command you're using to test? (Or is this using lavc in another
>> application?)
>> ___
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/6] lavc/audiotoolboxenc: fix iOS build

[Rodger Combs]

> On Mar 27, 2016, at 21:13, crossle song  wrote:
> 
> Work well on iPhone 6, but on  iPhone 4S iOS 9.0, return  [aac_at @
> 0x1702a400] Encode error: -50, can not work

I don't have a test setup for iOS devices (nor a 4S to test on); does this case 
work correctly with your patch, but not mine? What's the full ffmpeg command 
you're using to test? (Or is this using lavc in another application?)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/6] lavc/audiotoolboxenc: fix iOS build

[crossle song]

Work well on iPhone 6, but on  iPhone 4S iOS 9.0, return  [aac_at @
0x1702a400] Encode error: -50, can not work

On Mon, Mar 28, 2016 at 8:47 AM, Michael Niedermayer  wrote:

> On Sun, Mar 27, 2016 at 12:20:24PM -0500, Rodger Combs wrote:
> > ---
> >  libavcodec/audiotoolboxenc.c | 7 ++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
>
> does this fix?
>
> http://fate.ffmpeg.org/report.cgi?time=20160323070044=arm64-darwin-clang-apple-6.0
>
> should be ok
>
> thx
>
> [...]
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> When the tyrant has disposed of foreign enemies by conquest or treaty, and
> there is nothing more to fear from them, then he is always stirring up
> some war or other, in order that the people may require a leader. -- Plato
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/6] lavc/audiotoolboxenc: fix iOS build

[Michael Niedermayer]

On Sun, Mar 27, 2016 at 12:20:24PM -0500, Rodger Combs wrote:
> ---
>  libavcodec/audiotoolboxenc.c | 7 ++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

does this fix?
http://fate.ffmpeg.org/report.cgi?time=20160323070044=arm64-darwin-clang-apple-6.0

should be ok

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 3/6] lavc/audiotoolboxenc: fix iOS build

[Rodger Combs]

---
 libavcodec/audiotoolboxenc.c | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/libavcodec/audiotoolboxenc.c b/libavcodec/audiotoolboxenc.c
index 22352da..2fca15b 100644
--- a/libavcodec/audiotoolboxenc.c
+++ b/libavcodec/audiotoolboxenc.c
@@ -307,6 +307,7 @@ static av_cold int ffat_init_encoder(AVCodecContext *avctx)
   sizeof(avctx->bits_per_raw_sample),
   >bits_per_raw_sample);
 
+#if !TARGET_OS_IPHONE
 if (at->mode == -1)
 at->mode = (avctx->flags & AV_CODEC_FLAG_QSCALE) ?
kAudioCodecBitRateControlMode_Variable :
@@ -325,7 +326,9 @@ static av_cold int ffat_init_encoder(AVCodecContext *avctx)
 q = 127 - q * 9;
 AudioConverterSetProperty(at->converter, 
kAudioCodecPropertySoundQualityForVBR,
   sizeof(q), );
-} else if (avctx->bit_rate > 0) {
+} else
+#endif
+if (avctx->bit_rate > 0) {
 UInt32 rate = avctx->bit_rate;
 UInt32 size;
 status = AudioConverterGetPropertyInfo(at->converter,
@@ -553,12 +556,14 @@ static const AVProfile aac_profiles[] = {
 
 #define AE AV_OPT_FLAG_AUDIO_PARAM | AV_OPT_FLAG_ENCODING_PARAM
 static const AVOption options[] = {
+#if !TARGET_OS_IPHONE
 {"aac_at_mode", "ratecontrol mode", offsetof(ATDecodeContext, mode), 
AV_OPT_TYPE_INT, {.i64 = -1}, -1, kAudioCodecBitRateControlMode_Variable, AE, 
"mode"},
 {"auto", "VBR if global quality is given; CBR otherwise", 0, 
AV_OPT_TYPE_CONST, {.i64 = -1}, INT_MIN, INT_MAX, AE, "mode"},
 {"cbr",  "constant bitrate", 0, AV_OPT_TYPE_CONST, {.i64 = 
kAudioCodecBitRateControlMode_Constant}, INT_MIN, INT_MAX, AE, "mode"},
 {"abr",  "long-term average bitrate", 0, AV_OPT_TYPE_CONST, {.i64 = 
kAudioCodecBitRateControlMode_LongTermAverage}, INT_MIN, INT_MAX, AE, "mode"},
 {"cvbr", "constrained variable bitrate", 0, AV_OPT_TYPE_CONST, {.i64 = 
kAudioCodecBitRateControlMode_VariableConstrained}, INT_MIN, INT_MAX, AE, 
"mode"},
 {"vbr" , "variable bitrate", 0, AV_OPT_TYPE_CONST, {.i64 = 
kAudioCodecBitRateControlMode_Variable}, INT_MIN, INT_MAX, AE, "mode"},
+#endif
 {"aac_at_quality", "quality vs speed control", offsetof(ATDecodeContext, 
quality), AV_OPT_TYPE_INT, {.i64 = 0}, 0, 2, AE},
 { NULL },
 };
-- 
2.7.3

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel