Re: [FFmpeg-devel] [PATCH 7/7] doc/encoders: Fix libkvazaar documentation

[Carl Eugen Hoyos]

Arttu Ylä-Outinen  tut.fi> writes:

> Removes the -threads option from libkvazaar documentation 
> since it does not work with libkvazaar.

Why?
(Is this something that has to be fixed in FFmpeg?)

> -cfg->threads = avctx->thread_count;

Please clarify in the description that the patch is not 
documentation (-only).

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 7/7] doc/encoders: Fix libkvazaar documentation

[Arttu Ylä-Outinen]

Removes the -threads option from libkvazaar documentation since it does
not work with libkvazaar.

Signed-off-by: Arttu Ylä-Outinen 
---
 doc/encoders.texi   |3 ---
 libavcodec/libkvazaar.c |1 -
 2 files changed, 4 deletions(-)

diff --git a/doc/encoders.texi b/doc/encoders.texi
index 3550bcc..bf364fd 100644
--- a/doc/encoders.texi
+++ b/doc/encoders.texi
@@ -2397,9 +2397,6 @@ configuration. You need to explicitly configure the build 
with
 @item b
 Set target video bitrate in bit/s and enable rate control.
 
-@item threads
-Set number of encoding threads.
-
 @item kvazaar-params
 Set kvazaar parameters as a list of @var{name}=@var{value} pairs separated
 by commas (,). See kvazaar documentation for a list of options.
diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c
index 0cf890f..3000f6a 100644
--- a/libavcodec/libkvazaar.c
+++ b/libavcodec/libkvazaar.c
@@ -74,7 +74,6 @@ static av_cold int libkvazaar_init(AVCodecContext *avctx)
 cfg->height = avctx->height;
 cfg->framerate =
   avctx->time_base.den / (double)(avctx->time_base.num * 
avctx->ticks_per_frame);
-cfg->threads = avctx->thread_count;
 cfg->target_bitrate = avctx->bit_rate;
 cfg->vui.sar_width = avctx->sample_aspect_ratio.num;
 cfg->vui.sar_height = avctx->sample_aspect_ratio.den;
-- 
1.7.9.5

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 7/7] doc/encoders: Fix libkvazaar documentation

[Arttu Ylä-Outinen]

On 2015-09-28 15:12, Carl Eugen Hoyos wrote:

Arttu Ylä-Outinen  tut.fi> writes:


Removes the -threads option from libkvazaar documentation
since it does not work with libkvazaar.

Why?
(Is this something that has to be fixed in FFmpeg?)


The -threads option is ignored and the thread_count field of the 
AVCodecContext is always set to one because libkvazaar does not have any 
of the codec capabilities AV_CODEC_CAP_{FRAME,SLICE,AUTO}_THREADS.



-cfg->threads = avctx->thread_count;

Please clarify in the description that the patch is not
documentation (-only).


I'll fix the description.

- Arttu
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel