Re: [FFmpeg-devel] [PATCH 7/7] libavfilter: Adds proper file descriptions to dnn_srcnn.h and dnn_espcn.h.
I asked the student to prepare a patch, before he was working on fixing the issues pointed in the previous patches. 2018-08-14 15:46 GMT-03:00 Rostislav Pehlivanov : > On Thu, 2 Aug 2018 at 19:54, Sergey Lavrushkin wrote: > >> --- >> libavfilter/dnn_espcn.h | 3 ++- >> libavfilter/dnn_srcnn.h | 3 ++- >> 2 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/libavfilter/dnn_espcn.h b/libavfilter/dnn_espcn.h >> index 9344aa90fe..e0013fe1dd 100644 >> --- a/libavfilter/dnn_espcn.h >> +++ b/libavfilter/dnn_espcn.h >> @@ -20,7 +20,8 @@ >> >> /** >> * @file >> - * Default cnn weights for x2 upscaling with espcn model. >> + * This file contains CNN weights for ESPCN model ( >> https://arxiv.org/abs/1609.05158), >> + * auto generated by scripts provided in the repository: >> https://github.com/HighVoltageRocknRoll/sr.git. >> */ >> >> #ifndef AVFILTER_DNN_ESPCN_H >> diff --git a/libavfilter/dnn_srcnn.h b/libavfilter/dnn_srcnn.h >> index 4f5332ce18..8bf563bd62 100644 >> --- a/libavfilter/dnn_srcnn.h >> +++ b/libavfilter/dnn_srcnn.h >> @@ -20,7 +20,8 @@ >> >> /** >> * @file >> - * Default cnn weights for x2 upscaling with srcnn model. >> + * This file contains CNN weights for SRCNN model ( >> https://arxiv.org/abs/1501.00092), >> + * auto generated by scripts provided in the repository: >> https://github.com/HighVoltageRocknRoll/sr.git. >> */ >> >> #ifndef AVFILTER_DNN_SRCNN_H >> -- >> 2.14.1 >> >> ___ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> > > Soo, when are you going to remove *all* the models from lavfi? > All need to be removed before we make a release. > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 7/7] libavfilter: Adds proper file descriptions to dnn_srcnn.h and dnn_espcn.h.
On Thu, 2 Aug 2018 at 19:54, Sergey Lavrushkin wrote: > --- > libavfilter/dnn_espcn.h | 3 ++- > libavfilter/dnn_srcnn.h | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/dnn_espcn.h b/libavfilter/dnn_espcn.h > index 9344aa90fe..e0013fe1dd 100644 > --- a/libavfilter/dnn_espcn.h > +++ b/libavfilter/dnn_espcn.h > @@ -20,7 +20,8 @@ > > /** > * @file > - * Default cnn weights for x2 upscaling with espcn model. > + * This file contains CNN weights for ESPCN model ( > https://arxiv.org/abs/1609.05158), > + * auto generated by scripts provided in the repository: > https://github.com/HighVoltageRocknRoll/sr.git. > */ > > #ifndef AVFILTER_DNN_ESPCN_H > diff --git a/libavfilter/dnn_srcnn.h b/libavfilter/dnn_srcnn.h > index 4f5332ce18..8bf563bd62 100644 > --- a/libavfilter/dnn_srcnn.h > +++ b/libavfilter/dnn_srcnn.h > @@ -20,7 +20,8 @@ > > /** > * @file > - * Default cnn weights for x2 upscaling with srcnn model. > + * This file contains CNN weights for SRCNN model ( > https://arxiv.org/abs/1501.00092), > + * auto generated by scripts provided in the repository: > https://github.com/HighVoltageRocknRoll/sr.git. > */ > > #ifndef AVFILTER_DNN_SRCNN_H > -- > 2.14.1 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > Soo, when are you going to remove *all* the models from lavfi? All need to be removed before we make a release. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 7/7] libavfilter: Adds proper file descriptions to dnn_srcnn.h and dnn_espcn.h.
Patch pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 7/7] libavfilter: Adds proper file descriptions to dnn_srcnn.h and dnn_espcn.h.
Updated patch. 2018-08-02 21:52 GMT+03:00 Sergey Lavrushkin : > --- > libavfilter/dnn_espcn.h | 3 ++- > libavfilter/dnn_srcnn.h | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/dnn_espcn.h b/libavfilter/dnn_espcn.h > index 9344aa90fe..e0013fe1dd 100644 > --- a/libavfilter/dnn_espcn.h > +++ b/libavfilter/dnn_espcn.h > @@ -20,7 +20,8 @@ > > /** > * @file > - * Default cnn weights for x2 upscaling with espcn model. > + * This file contains CNN weights for ESPCN model ( > https://arxiv.org/abs/1609.05158), > + * auto generated by scripts provided in the repository: > https://github.com/HighVoltageRocknRoll/sr.git. > */ > > #ifndef AVFILTER_DNN_ESPCN_H > diff --git a/libavfilter/dnn_srcnn.h b/libavfilter/dnn_srcnn.h > index 4f5332ce18..8bf563bd62 100644 > --- a/libavfilter/dnn_srcnn.h > +++ b/libavfilter/dnn_srcnn.h > @@ -20,7 +20,8 @@ > > /** > * @file > - * Default cnn weights for x2 upscaling with srcnn model. > + * This file contains CNN weights for SRCNN model ( > https://arxiv.org/abs/1501.00092), > + * auto generated by scripts provided in the repository: > https://github.com/HighVoltageRocknRoll/sr.git. > */ > > #ifndef AVFILTER_DNN_SRCNN_H > -- > 2.14.1 > > From c2060d992664087fcfffa447768a6ad8f5e38623 Mon Sep 17 00:00:00 2001 From: Sergey Lavrushkin Date: Thu, 2 Aug 2018 19:56:23 +0300 Subject: [PATCH 8/9] libavfilter: Adds proper file descriptions to dnn_srcnn.h and dnn_espcn.h. --- libavfilter/dnn_espcn.h | 3 ++- libavfilter/dnn_srcnn.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavfilter/dnn_espcn.h b/libavfilter/dnn_espcn.h index 9344aa90fe..e0013fe1dd 100644 --- a/libavfilter/dnn_espcn.h +++ b/libavfilter/dnn_espcn.h @@ -20,7 +20,8 @@ /** * @file - * Default cnn weights for x2 upscaling with espcn model. + * This file contains CNN weights for ESPCN model (https://arxiv.org/abs/1609.05158), + * auto generated by scripts provided in the repository: https://github.com/HighVoltageRocknRoll/sr.git. */ #ifndef AVFILTER_DNN_ESPCN_H diff --git a/libavfilter/dnn_srcnn.h b/libavfilter/dnn_srcnn.h index 4f5332ce18..8bf563bd62 100644 --- a/libavfilter/dnn_srcnn.h +++ b/libavfilter/dnn_srcnn.h @@ -20,7 +20,8 @@ /** * @file - * Default cnn weights for x2 upscaling with srcnn model. + * This file contains CNN weights for SRCNN model (https://arxiv.org/abs/1501.00092), + * auto generated by scripts provided in the repository: https://github.com/HighVoltageRocknRoll/sr.git. */ #ifndef AVFILTER_DNN_SRCNN_H -- 2.14.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH 7/7] libavfilter: Adds proper file descriptions to dnn_srcnn.h and dnn_espcn.h.
--- libavfilter/dnn_espcn.h | 3 ++- libavfilter/dnn_srcnn.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavfilter/dnn_espcn.h b/libavfilter/dnn_espcn.h index 9344aa90fe..e0013fe1dd 100644 --- a/libavfilter/dnn_espcn.h +++ b/libavfilter/dnn_espcn.h @@ -20,7 +20,8 @@ /** * @file - * Default cnn weights for x2 upscaling with espcn model. + * This file contains CNN weights for ESPCN model (https://arxiv.org/abs/1609.05158), + * auto generated by scripts provided in the repository: https://github.com/HighVoltageRocknRoll/sr.git. */ #ifndef AVFILTER_DNN_ESPCN_H diff --git a/libavfilter/dnn_srcnn.h b/libavfilter/dnn_srcnn.h index 4f5332ce18..8bf563bd62 100644 --- a/libavfilter/dnn_srcnn.h +++ b/libavfilter/dnn_srcnn.h @@ -20,7 +20,8 @@ /** * @file - * Default cnn weights for x2 upscaling with srcnn model. + * This file contains CNN weights for SRCNN model (https://arxiv.org/abs/1501.00092), + * auto generated by scripts provided in the repository: https://github.com/HighVoltageRocknRoll/sr.git. */ #ifndef AVFILTER_DNN_SRCNN_H -- 2.14.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
