Re: [FFmpeg-devel] [PATCH 8/9] checkasm/vp8dsp: Use declare_func_emms only when needed

2022-10-07 Thread Ronald S. Bultje 
Hi,

On Fri, Oct 7, 2022 at 9:25 PM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:

> There is no MMX code for loop filters since commit
> 6a551f14050674fb685920eb1b0640810cacccf9, so use declare_func
> instead of declare_func_emms() to also test that we are not
> in MMX mode after return.
>
> Signed-off-by: Andreas Rheinhardt 
> ---
>  tests/checkasm/vp8dsp.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>

LGTM.

Ronald
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 8/9] checkasm/vp8dsp: Use declare_func_emms only when needed

2022-10-07 Thread Andreas Rheinhardt 
There is no MMX code for loop filters since commit
6a551f14050674fb685920eb1b0640810cacccf9, so use declare_func
instead of declare_func_emms() to also test that we are not
in MMX mode after return.

Signed-off-by: Andreas Rheinhardt 
---
 tests/checkasm/vp8dsp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/checkasm/vp8dsp.c b/tests/checkasm/vp8dsp.c
index c3af54fbfd..87b03d71d5 100644
--- a/tests/checkasm/vp8dsp.c
+++ b/tests/checkasm/vp8dsp.c
@@ -384,7 +384,7 @@ static void check_loopfilter_16y(void)
 VP8DSPContext d;
 int dir, edge, force_hev;
 int flim_E = 20, flim_I = 10, hev_thresh = 7;
-declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *, ptrdiff_t, int, int, 
int);
+declare_func(void, uint8_t *, ptrdiff_t, int, int, int);
 
 ff_vp8dsp_init();
 
@@ -430,7 +430,7 @@ static void check_loopfilter_8uv(void)
 VP8DSPContext d;
 int dir, edge, force_hev;
 int flim_E = 20, flim_I = 10, hev_thresh = 7;
-declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *, uint8_t *, ptrdiff_t, 
int, int, int);
+declare_func(void, uint8_t *, uint8_t *, ptrdiff_t, int, int, int);
 
 ff_vp8dsp_init();
 
@@ -481,7 +481,7 @@ static void check_loopfilter_simple(void)
 VP8DSPContext d;
 int dir;
 int flim_E = 20, flim_I = 30, hev_thresh = 0;
-declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *, ptrdiff_t, int);
+declare_func(void, uint8_t *, ptrdiff_t, int);
 
 ff_vp8dsp_init();
 
-- 
2.34.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".